Re: [PATCH] arm64: defconfig: Enable modules for arm displays

From: Mark Brown <broonie@kernel.org>
To: Liviu Dudau <liviu.dudau@arm.com>
Cc: Carsten Haitzler <carsten.haitzler@foss.arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	carsten.haitzler@arm.com, soc@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] arm64: defconfig: Enable modules for arm displays
Date: Wed, 11 May 2022 14:13:03 +0100	[thread overview]
Message-ID: <Ynu2X/SwS7XqEEEs@sirena.org.uk> (raw)
In-Reply-To: <YnrF3Nc7NbcX6v3b@e110455-lin.cambridge.arm.com>

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

On Tue, May 10, 2022 at 09:06:52PM +0100, Liviu Dudau wrote:

> The quickest way is to harmonise the treatment of IRQs between tda998x and tda9950.
> The former treats the IRQ as optional, the later as mandatory. Given that (according
> to comments in the code) TDA998X is actually a TDA9989+TDA9950, it makes sense to
> treat the lack of IRQ the same way (make it optional, IMHO).

The check in tda9950 is sensible enough, the device relies on interrupts
to report the status of CEC operations so we'd need to poll constantly
which doesn't seem great.  It wouldn't be *so* bad for things initiated
by the device but given that CEC is a network and we might get messages
from other devices in the system at any time we'd need to poll
constantly even when otherwise idle which doesn't seem good.  I sent a
patch to lower the level of the log message, hopefully that's OK for
people.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]