* [PATCH] xfs/545: check for fallocate support before running test
@ 2022-05-24 19:52 Darrick J. Wong
2022-05-24 23:48 ` Dave Chinner
2022-05-27 6:18 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Darrick J. Wong @ 2022-05-24 19:52 UTC (permalink / raw)
To: Zorro Lang, Eryu Guan; +Cc: fstests, xfs
From: Darrick J. Wong <djwong@kernel.org>
This test fails when alwayscow mode is enabled:
--- xfs/545.out
+++ xfs/545.out.bad
@@ -1,4 +1,5 @@
QA output created by 545
+fallocate: Operation not supported
Creating directory system to dump using fsstress.
Fix this by checking for fallocate support first.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
tests/xfs/545 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/xfs/545 b/tests/xfs/545
index e3dd300a..dfe2f2dc 100755
--- a/tests/xfs/545
+++ b/tests/xfs/545
@@ -14,6 +14,7 @@ _begin_fstest auto quick dump
. ./common/dump
_supported_fs xfs
+_require_xfs_io_command "falloc"
_require_scratch
# A large stripe unit will put the root inode out quite far
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs/545: check for fallocate support before running test
2022-05-24 19:52 [PATCH] xfs/545: check for fallocate support before running test Darrick J. Wong
@ 2022-05-24 23:48 ` Dave Chinner
2022-05-27 6:18 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2022-05-24 23:48 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Zorro Lang, Eryu Guan, fstests, xfs
On Tue, May 24, 2022 at 12:52:19PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> This test fails when alwayscow mode is enabled:
>
> --- xfs/545.out
> +++ xfs/545.out.bad
> @@ -1,4 +1,5 @@
> QA output created by 545
> +fallocate: Operation not supported
> Creating directory system to dump using fsstress.
>
> Fix this by checking for fallocate support first.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs/545: check for fallocate support before running test
2022-05-24 19:52 [PATCH] xfs/545: check for fallocate support before running test Darrick J. Wong
2022-05-24 23:48 ` Dave Chinner
@ 2022-05-27 6:18 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-05-27 6:18 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Zorro Lang, Eryu Guan, fstests, xfs
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-27 6:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-24 19:52 [PATCH] xfs/545: check for fallocate support before running test Darrick J. Wong
2022-05-24 23:48 ` Dave Chinner
2022-05-27 6:18 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.