[PATCH] xfs/545: check for fallocate support before running test

[PATCH] xfs/545: check for fallocate support before running test

[Darrick J. Wong]

From: Darrick J. Wong <djwong@kernel.org>

This test fails when alwayscow mode is enabled:

--- xfs/545.out
+++ xfs/545.out.bad
@@ -1,4 +1,5 @@
 QA output created by 545
+fallocate: Operation not supported
 Creating directory system to dump using fsstress.

Fix this by checking for fallocate support first.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/xfs/545 |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/xfs/545 b/tests/xfs/545
index e3dd300a..dfe2f2dc 100755
--- a/tests/xfs/545
+++ b/tests/xfs/545
@@ -14,6 +14,7 @@ _begin_fstest auto quick dump
 . ./common/dump
 
 _supported_fs xfs
+_require_xfs_io_command "falloc"
 _require_scratch
 
 # A large stripe unit will put the root inode out quite far

Re: [PATCH] xfs/545: check for fallocate support before running test

[Dave Chinner]

On Tue, May 24, 2022 at 12:52:19PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> This test fails when alwayscow mode is enabled:
> 
> --- xfs/545.out
> +++ xfs/545.out.bad
> @@ -1,4 +1,5 @@
>  QA output created by 545
> +fallocate: Operation not supported
>  Creating directory system to dump using fsstress.
> 
> Fix this by checking for fallocate support first.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
-- 
Dave Chinner
david@fromorbit.com

Re: [PATCH] xfs/545: check for fallocate support before running test

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>