From: Mark Brown <broonie@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Corentin Labbe <clabbe@baylibre.com>,
calvin.johnson@oss.nxp.com, davem@davemloft.net,
edumazet@google.com, hkallweit1@gmail.com,
jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org,
kuba@kernel.org, lgirdwood@gmail.com, linux@armlinux.org.uk,
pabeni@redhat.com, robh+dt@kernel.org, samuel@sholland.org,
wens@csie.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators
Date: Thu, 19 May 2022 16:49:09 +0100 [thread overview]
Message-ID: <YoZm9eabWy/FNKu1@sirena.org.uk> (raw)
In-Reply-To: <YoYw2lKbgCiDXP0A@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]
On Thu, May 19, 2022 at 01:58:18PM +0200, Andrew Lunn wrote:
> On Thu, May 19, 2022 at 01:33:21PM +0200, Krzysztof Kozlowski wrote:
> > On 19/05/2022 13:31, Mark Brown wrote:
> > > On Thu, May 19, 2022 at 11:55:28AM +0200, Krzysztof Kozlowski wrote:
> > >> On 18/05/2022 22:09, Corentin Labbe wrote:
> > >>> + regulators:
> > >>> + description:
> > >>> + List of phandle to regulators needed for the PHY
> > >> I don't understand that... is your PHY defining the regulators or using
> > >> supplies? If it needs a regulator (as a supply), you need to document
> > >> supplies, using existing bindings.
> > > They're trying to have a generic driver which works with any random PHY
> > > so the binding has no idea what supplies it might need.
> > OK, that makes sense, but then question is why not using existing
> > naming, so "supplies" and "supply-names"?
> I'm not saying it is not possible, but in general, the names are not
> interesting. All that is needed is that they are all on, or
> potentially all off to save power on shutdown. We don't care how many
> there are, or what order they are enabled.
I think Krzysztof is referring to the name of the property rather than
the contents of the -names property there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Corentin Labbe <clabbe@baylibre.com>,
calvin.johnson@oss.nxp.com, davem@davemloft.net,
edumazet@google.com, hkallweit1@gmail.com,
jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org,
kuba@kernel.org, lgirdwood@gmail.com, linux@armlinux.org.uk,
pabeni@redhat.com, robh+dt@kernel.org, samuel@sholland.org,
wens@csie.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators
Date: Thu, 19 May 2022 16:49:09 +0100 [thread overview]
Message-ID: <YoZm9eabWy/FNKu1@sirena.org.uk> (raw)
In-Reply-To: <YoYw2lKbgCiDXP0A@lunn.ch>
[-- Attachment #1.1: Type: text/plain, Size: 1238 bytes --]
On Thu, May 19, 2022 at 01:58:18PM +0200, Andrew Lunn wrote:
> On Thu, May 19, 2022 at 01:33:21PM +0200, Krzysztof Kozlowski wrote:
> > On 19/05/2022 13:31, Mark Brown wrote:
> > > On Thu, May 19, 2022 at 11:55:28AM +0200, Krzysztof Kozlowski wrote:
> > >> On 18/05/2022 22:09, Corentin Labbe wrote:
> > >>> + regulators:
> > >>> + description:
> > >>> + List of phandle to regulators needed for the PHY
> > >> I don't understand that... is your PHY defining the regulators or using
> > >> supplies? If it needs a regulator (as a supply), you need to document
> > >> supplies, using existing bindings.
> > > They're trying to have a generic driver which works with any random PHY
> > > so the binding has no idea what supplies it might need.
> > OK, that makes sense, but then question is why not using existing
> > naming, so "supplies" and "supply-names"?
> I'm not saying it is not possible, but in general, the names are not
> interesting. All that is needed is that they are all on, or
> potentially all off to save power on shutdown. We don't care how many
> there are, or what order they are enabled.
I think Krzysztof is referring to the name of the property rather than
the contents of the -names property there.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-19 15:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 20:09 [PATCH v2 0/5] arm64: add ethernet to orange pi 3 Corentin Labbe
2022-05-18 20:09 ` Corentin Labbe
2022-05-18 20:09 ` [PATCH v2 1/5] regulator: Add of_get_regulator_from_list Corentin Labbe
2022-05-18 20:09 ` Corentin Labbe
2022-05-18 20:09 ` [PATCH v2 2/5] regulator: Add regulator_bulk_get_all Corentin Labbe
2022-05-18 20:09 ` Corentin Labbe
2022-05-18 20:09 ` [PATCH v2 3/5] phy: handle optional regulator for PHY Corentin Labbe
2022-05-18 20:09 ` Corentin Labbe
2022-05-18 20:09 ` [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators Corentin Labbe
2022-05-18 20:09 ` Corentin Labbe
2022-05-19 0:08 ` Rob Herring
2022-05-19 0:08 ` Rob Herring
2022-05-19 9:55 ` Krzysztof Kozlowski
2022-05-19 9:55 ` Krzysztof Kozlowski
2022-05-19 11:31 ` Mark Brown
2022-05-19 11:31 ` Mark Brown
2022-05-19 11:33 ` Krzysztof Kozlowski
2022-05-19 11:33 ` Krzysztof Kozlowski
2022-05-19 11:58 ` Andrew Lunn
2022-05-19 11:58 ` Andrew Lunn
2022-05-19 15:49 ` Mark Brown [this message]
2022-05-19 15:49 ` Mark Brown
2022-05-20 7:57 ` Krzysztof Kozlowski
2022-05-20 7:57 ` Krzysztof Kozlowski
2022-05-20 8:15 ` LABBE Corentin
2022-05-20 8:15 ` LABBE Corentin
2022-05-20 10:19 ` Krzysztof Kozlowski
2022-05-20 10:19 ` Krzysztof Kozlowski
2022-05-19 20:17 ` Rob Herring
2022-05-19 20:17 ` Rob Herring
2022-05-18 20:09 ` [PATCH v2 5/5] arm64: dts: allwinner: orange-pi-3: Enable ethernet Corentin Labbe
2022-05-18 20:09 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoZm9eabWy/FNKu1@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andrew@lunn.ch \
--cc=calvin.johnson@oss.nxp.com \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.