From: Christoph Hellwig <hch@infradead.org>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org,
x86@kernel.org, linuxppc-dev@lists.ozlabs.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, hch@infradead.org,
m.szyprowski@samsung.com, jgross@suse.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
sstabellini@kernel.org, mpe@ellerman.id.au,
konrad.wilk@oracle.com, mst@redhat.com, jasowang@redhat.com,
joe.jin@oracle.com
Subject: Re: [PATCH RFC v1 3/7] swiotlb-xen: support highmem for xen specific code
Date: Wed, 8 Jun 2022 22:08:54 -0700 [thread overview]
Message-ID: <YqGAZoG6/pVX9NqN@infradead.org> (raw)
In-Reply-To: <20220609005553.30954-4-dongli.zhang@oracle.com>
On Wed, Jun 08, 2022 at 05:55:49PM -0700, Dongli Zhang wrote:
> @@ -109,19 +110,25 @@ int xen_swiotlb_fixup(void *buf, unsigned long nslabs, bool high)
> int rc;
> unsigned int order = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT);
> unsigned int i, dma_bits = order + PAGE_SHIFT;
> + unsigned int max_dma_bits = MAX_DMA32_BITS;
> dma_addr_t dma_handle;
> phys_addr_t p = virt_to_phys(buf);
>
> BUILD_BUG_ON(IO_TLB_SEGSIZE & (IO_TLB_SEGSIZE - 1));
> BUG_ON(nslabs % IO_TLB_SEGSIZE);
>
> + if (high) {
> + dma_bits = MAX_DMA64_BITS;
> + max_dma_bits = MAX_DMA64_BITS;
> + }
> +
I think you really want to pass the addressing bits or mask to the
remap callback and not do magic with a 'high' flag here.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: jgross@suse.com, dave.hansen@linux.intel.com, mst@redhat.com,
konrad.wilk@oracle.com, jasowang@redhat.com, x86@kernel.org,
joe.jin@oracle.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, hch@infradead.org,
iommu@lists.linux-foundation.org, mingo@redhat.com, bp@alien8.de,
sstabellini@kernel.org, xen-devel@lists.xenproject.org,
tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org,
m.szyprowski@samsung.com
Subject: Re: [PATCH RFC v1 3/7] swiotlb-xen: support highmem for xen specific code
Date: Wed, 8 Jun 2022 22:08:54 -0700 [thread overview]
Message-ID: <YqGAZoG6/pVX9NqN@infradead.org> (raw)
In-Reply-To: <20220609005553.30954-4-dongli.zhang@oracle.com>
On Wed, Jun 08, 2022 at 05:55:49PM -0700, Dongli Zhang wrote:
> @@ -109,19 +110,25 @@ int xen_swiotlb_fixup(void *buf, unsigned long nslabs, bool high)
> int rc;
> unsigned int order = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT);
> unsigned int i, dma_bits = order + PAGE_SHIFT;
> + unsigned int max_dma_bits = MAX_DMA32_BITS;
> dma_addr_t dma_handle;
> phys_addr_t p = virt_to_phys(buf);
>
> BUILD_BUG_ON(IO_TLB_SEGSIZE & (IO_TLB_SEGSIZE - 1));
> BUG_ON(nslabs % IO_TLB_SEGSIZE);
>
> + if (high) {
> + dma_bits = MAX_DMA64_BITS;
> + max_dma_bits = MAX_DMA64_BITS;
> + }
> +
I think you really want to pass the addressing bits or mask to the
remap callback and not do magic with a 'high' flag here.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: jgross@suse.com, dave.hansen@linux.intel.com, mst@redhat.com,
konrad.wilk@oracle.com, mpe@ellerman.id.au, jasowang@redhat.com,
x86@kernel.org, joe.jin@oracle.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, hch@infradead.org,
iommu@lists.linux-foundation.org, mingo@redhat.com, bp@alien8.de,
sstabellini@kernel.org, xen-devel@lists.xenproject.org,
tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH RFC v1 3/7] swiotlb-xen: support highmem for xen specific code
Date: Wed, 8 Jun 2022 22:08:54 -0700 [thread overview]
Message-ID: <YqGAZoG6/pVX9NqN@infradead.org> (raw)
In-Reply-To: <20220609005553.30954-4-dongli.zhang@oracle.com>
On Wed, Jun 08, 2022 at 05:55:49PM -0700, Dongli Zhang wrote:
> @@ -109,19 +110,25 @@ int xen_swiotlb_fixup(void *buf, unsigned long nslabs, bool high)
> int rc;
> unsigned int order = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT);
> unsigned int i, dma_bits = order + PAGE_SHIFT;
> + unsigned int max_dma_bits = MAX_DMA32_BITS;
> dma_addr_t dma_handle;
> phys_addr_t p = virt_to_phys(buf);
>
> BUILD_BUG_ON(IO_TLB_SEGSIZE & (IO_TLB_SEGSIZE - 1));
> BUG_ON(nslabs % IO_TLB_SEGSIZE);
>
> + if (high) {
> + dma_bits = MAX_DMA64_BITS;
> + max_dma_bits = MAX_DMA64_BITS;
> + }
> +
I think you really want to pass the addressing bits or mask to the
remap callback and not do magic with a 'high' flag here.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: jgross@suse.com, dave.hansen@linux.intel.com, mst@redhat.com,
konrad.wilk@oracle.com, mpe@ellerman.id.au, x86@kernel.org,
joe.jin@oracle.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, hch@infradead.org,
iommu@lists.linux-foundation.org, mingo@redhat.com, bp@alien8.de,
sstabellini@kernel.org, xen-devel@lists.xenproject.org,
tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org,
m.szyprowski@samsung.com
Subject: Re: [PATCH RFC v1 3/7] swiotlb-xen: support highmem for xen specific code
Date: Wed, 8 Jun 2022 22:08:54 -0700 [thread overview]
Message-ID: <YqGAZoG6/pVX9NqN@infradead.org> (raw)
In-Reply-To: <20220609005553.30954-4-dongli.zhang@oracle.com>
On Wed, Jun 08, 2022 at 05:55:49PM -0700, Dongli Zhang wrote:
> @@ -109,19 +110,25 @@ int xen_swiotlb_fixup(void *buf, unsigned long nslabs, bool high)
> int rc;
> unsigned int order = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT);
> unsigned int i, dma_bits = order + PAGE_SHIFT;
> + unsigned int max_dma_bits = MAX_DMA32_BITS;
> dma_addr_t dma_handle;
> phys_addr_t p = virt_to_phys(buf);
>
> BUILD_BUG_ON(IO_TLB_SEGSIZE & (IO_TLB_SEGSIZE - 1));
> BUG_ON(nslabs % IO_TLB_SEGSIZE);
>
> + if (high) {
> + dma_bits = MAX_DMA64_BITS;
> + max_dma_bits = MAX_DMA64_BITS;
> + }
> +
I think you really want to pass the addressing bits or mask to the
remap callback and not do magic with a 'high' flag here.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-06-09 5:09 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 0:55 [PATCH RFC v1 0/7] swiotlb: extra 64-bit buffer for dev->dma_io_tlb_mem Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` [PATCH RFC v1 1/7] swiotlb: introduce the highmem swiotlb buffer Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 5:04 ` Christoph Hellwig
2022-06-09 5:04 ` Christoph Hellwig
2022-06-09 5:04 ` Christoph Hellwig
2022-06-09 5:04 ` Christoph Hellwig
2022-06-09 0:55 ` [PATCH RFC v1 2/7] swiotlb: change the signature of remap function Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` [PATCH RFC v1 3/7] swiotlb-xen: support highmem for xen specific code Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 5:08 ` Christoph Hellwig [this message]
2022-06-09 5:08 ` Christoph Hellwig
2022-06-09 5:08 ` Christoph Hellwig
2022-06-09 5:08 ` Christoph Hellwig
2022-06-09 0:55 ` [PATCH RFC v1 4/7] swiotlb: to implement io_tlb_high_mem Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 5:05 ` Christoph Hellwig
2022-06-09 5:05 ` Christoph Hellwig
2022-06-09 5:05 ` Christoph Hellwig
2022-06-09 5:05 ` Christoph Hellwig
2022-06-10 21:56 ` Dongli Zhang
2022-06-10 21:56 ` Dongli Zhang
2022-06-10 21:56 ` Dongli Zhang
2022-06-10 21:56 ` Dongli Zhang
2022-06-13 6:04 ` Christoph Hellwig
2022-06-13 6:04 ` Christoph Hellwig
2022-06-13 6:04 ` Christoph Hellwig
2022-06-13 6:04 ` Christoph Hellwig
2022-06-09 0:55 ` [PATCH RFC v1 5/7] swiotlb: add interface to set dev->dma_io_tlb_mem Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 5:06 ` Christoph Hellwig
2022-06-09 5:06 ` Christoph Hellwig
2022-06-09 5:06 ` Christoph Hellwig
2022-06-09 5:06 ` Christoph Hellwig
2022-06-09 0:55 ` [PATCH RFC v1 6/7] virtio: use io_tlb_high_mem if it is active Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 5:07 ` Christoph Hellwig
2022-06-09 5:07 ` Christoph Hellwig
2022-06-09 5:07 ` Christoph Hellwig
2022-06-09 5:07 ` Christoph Hellwig
2022-06-09 0:55 ` [PATCH RFC v1 7/7] swiotlb: fix the slot_addr() overflow Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 0:55 ` Dongli Zhang
2022-06-09 5:07 ` Christoph Hellwig
2022-06-09 5:07 ` Christoph Hellwig
2022-06-09 5:07 ` Christoph Hellwig
2022-06-09 5:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqGAZoG6/pVX9NqN@infradead.org \
--to=hch@infradead.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dongli.zhang@oracle.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jasowang@redhat.com \
--cc=jgross@suse.com \
--cc=joe.jin@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.