* net/sched: act_police: more accurate MTU policing
@ 2022-06-10 14:58 Davide Caratti
2022-06-10 15:09 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Davide Caratti @ 2022-06-10 14:58 UTC (permalink / raw)
To: stable; +Cc: echaudro, i.maximets
hello,
Ilya reports bad TCP throughput when GSO packets hit an OVS rule that does
tc MTU policing. According to his observations [1], the problem is fixed
by upstream commit 4ddc844eb81d ("net/sched: act_police: more accurate MTU
policing"). Can we queue this commit for inclusion in stable trees?
thanks!
--
davide
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2022-June/394802.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: net/sched: act_police: more accurate MTU policing 2022-06-10 14:58 net/sched: act_police: more accurate MTU policing Davide Caratti @ 2022-06-10 15:09 ` Greg KH 2022-06-10 17:08 ` Davide Caratti 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2022-06-10 15:09 UTC (permalink / raw) To: Davide Caratti; +Cc: stable, echaudro, i.maximets On Fri, Jun 10, 2022 at 04:58:37PM +0200, Davide Caratti wrote: > hello, > > Ilya reports bad TCP throughput when GSO packets hit an OVS rule that does > tc MTU policing. According to his observations [1], the problem is fixed > by upstream commit 4ddc844eb81d ("net/sched: act_police: more accurate MTU > policing"). Can we queue this commit for inclusion in stable trees? Did you test this, and what kernel(s) do you want it applied to? thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: net/sched: act_police: more accurate MTU policing 2022-06-10 15:09 ` Greg KH @ 2022-06-10 17:08 ` Davide Caratti 2022-06-10 19:31 ` Ilya Maximets 2022-06-13 9:11 ` Greg KH 0 siblings, 2 replies; 6+ messages in thread From: Davide Caratti @ 2022-06-10 17:08 UTC (permalink / raw) To: Greg KH; +Cc: stable, echaudro, i.maximets hello Greg, thanks for looking at this! On Fri, Jun 10, 2022 at 05:09:21PM +0200, Greg KH wrote: > On Fri, Jun 10, 2022 at 04:58:37PM +0200, Davide Caratti wrote: > > hello, > > > > Ilya reports bad TCP throughput when GSO packets hit an OVS rule that does > > tc MTU policing. According to his observations [1], the problem is fixed > > by upstream commit 4ddc844eb81d ("net/sched: act_police: more accurate MTU > > policing"). Can we queue this commit for inclusion in stable trees? > > Did you test this, I tested it on upstream, RHEL8 and RHEL9 kernels. BTW, the kselftest I included in the commit only verifies the correct setting for the MTU threshold, not the GSO problem (to test GSO, we should use netperf / iperf3 rather than mausezahn to generate traffic). > and what kernel(s) do you want it applied to? the reported bug is in act_police since the very beginning; however, the patch should apply cleanly at least on 5.x kernels. On older ones, there might be a small conflict due to lack of RCU-ification of struct tcf_police_params. A conflict that gets fixed easily, but in case we need it I volunteer to write a patch for kernels older than 4.20. @Ilya, what is the minimum kernel usable for openvswitch with MTU policing? -- davide ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: net/sched: act_police: more accurate MTU policing 2022-06-10 17:08 ` Davide Caratti @ 2022-06-10 19:31 ` Ilya Maximets 2022-06-13 9:11 ` Greg KH 1 sibling, 0 replies; 6+ messages in thread From: Ilya Maximets @ 2022-06-10 19:31 UTC (permalink / raw) To: Davide Caratti, Greg KH; +Cc: i.maximets, stable, echaudro On 6/10/22 19:08, Davide Caratti wrote: > hello Greg, > > thanks for looking at this! > > On Fri, Jun 10, 2022 at 05:09:21PM +0200, Greg KH wrote: >> On Fri, Jun 10, 2022 at 04:58:37PM +0200, Davide Caratti wrote: >>> hello, >>> >>> Ilya reports bad TCP throughput when GSO packets hit an OVS rule that does >>> tc MTU policing. According to his observations [1], the problem is fixed >>> by upstream commit 4ddc844eb81d ("net/sched: act_police: more accurate MTU >>> policing"). Can we queue this commit for inclusion in stable trees? >> >> Did you test this, > > I tested it on upstream, RHEL8 and RHEL9 kernels. BTW, the kselftest I included > in the commit only verifies the correct setting for the MTU threshold, not > the GSO problem (to test GSO, we should use netperf / iperf3 rather than > mausezahn to generate traffic). > >> and what kernel(s) do you want it applied to? > > the reported bug is in act_police since the very beginning; however, the > patch should apply cleanly at least on 5.x kernels. On older ones, there > might be a small conflict due to lack of RCU-ification of struct > tcf_police_params. > A conflict that gets fixed easily, but in case we need it I volunteer to > write a patch for kernels older than 4.20. @Ilya, what is the > minimum kernel usable for openvswitch with MTU policing? act_police MTU check is supposed to be an alternative for OVS' check_pkt_len() action which was introduced in 5.2. So, backport to 5.2+ should be enough. Best regards, Ilya Maximets. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: net/sched: act_police: more accurate MTU policing 2022-06-10 17:08 ` Davide Caratti 2022-06-10 19:31 ` Ilya Maximets @ 2022-06-13 9:11 ` Greg KH 2022-06-13 9:43 ` Davide Caratti 1 sibling, 1 reply; 6+ messages in thread From: Greg KH @ 2022-06-13 9:11 UTC (permalink / raw) To: Davide Caratti; +Cc: stable, echaudro, i.maximets On Fri, Jun 10, 2022 at 07:08:48PM +0200, Davide Caratti wrote: > hello Greg, > > thanks for looking at this! > > On Fri, Jun 10, 2022 at 05:09:21PM +0200, Greg KH wrote: > > On Fri, Jun 10, 2022 at 04:58:37PM +0200, Davide Caratti wrote: > > > hello, > > > > > > Ilya reports bad TCP throughput when GSO packets hit an OVS rule that does > > > tc MTU policing. According to his observations [1], the problem is fixed > > > by upstream commit 4ddc844eb81d ("net/sched: act_police: more accurate MTU > > > policing"). Can we queue this commit for inclusion in stable trees? > > > > Did you test this, > > I tested it on upstream, RHEL8 and RHEL9 kernels. BTW, the kselftest I included > in the commit only verifies the correct setting for the MTU threshold, not > the GSO problem (to test GSO, we should use netperf / iperf3 rather than > mausezahn to generate traffic). > > > and what kernel(s) do you want it applied to? > > the reported bug is in act_police since the very beginning; however, the > patch should apply cleanly at least on 5.x kernels. On older ones, there > might be a small conflict due to lack of RCU-ification of struct > tcf_police_params. > A conflict that gets fixed easily, but in case we need it I volunteer to > write a patch for kernels older than 4.20. @Ilya, what is the > minimum kernel usable for openvswitch with MTU policing? > It does not apply to 5.10 or earlier, so please provide a working backport for those kernels if you wish it to be applied there. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: net/sched: act_police: more accurate MTU policing 2022-06-13 9:11 ` Greg KH @ 2022-06-13 9:43 ` Davide Caratti 0 siblings, 0 replies; 6+ messages in thread From: Davide Caratti @ 2022-06-13 9:43 UTC (permalink / raw) To: Greg KH; +Cc: stable, echaudro, i.maximets hello Greg, On Mon, Jun 13, 2022 at 11:11:18AM +0200, Greg KH wrote: > On Fri, Jun 10, 2022 at 07:08:48PM +0200, Davide Caratti wrote: > > hello Greg, [...] > > > and what kernel(s) do you want it applied to? > > > > the reported bug is in act_police since the very beginning; however, the > > patch should apply cleanly at least on 5.x kernels. On older ones, there > > might be a small conflict due to lack of RCU-ification of struct > > tcf_police_params. > > A conflict that gets fixed easily, but in case we need it I volunteer to > > write a patch for kernels older than 4.20. @Ilya, what is the > > minimum kernel usable for openvswitch with MTU policing? > > > > It does not apply to 5.10 or earlier, so please provide a working > backport for those kernels if you wish it to be applied there. sure, I will do that. thanks! -- davide ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-13 9:44 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-06-10 14:58 net/sched: act_police: more accurate MTU policing Davide Caratti 2022-06-10 15:09 ` Greg KH 2022-06-10 17:08 ` Davide Caratti 2022-06-10 19:31 ` Ilya Maximets 2022-06-13 9:11 ` Greg KH 2022-06-13 9:43 ` Davide Caratti
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.