All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] usb: gadget: dereference before null check
@ 2022-06-29  8:07 ` SebinSebastian
  0 siblings, 0 replies; 13+ messages in thread
From: SebinSebastian @ 2022-06-29  8:07 UTC (permalink / raw)
  Cc: mailmesebin00, skhan, Neal Liu, Felipe Balbi, Greg Kroah-Hartman,
	Joel Stanley, Andrew Jeffery, linux-aspeed, linux-usb,
	linux-arm-kernel, linux-kernel

Fix coverity warning dereferencing before null check. _ep and desc is
dereferenced on all paths until the check for null. Move the
initializations after the check for null.
Coverity issue: 1518209

Signed-off-by: SebinSebastian <mailmesebin00@gmail.com>
---
 drivers/usb/gadget/udc/aspeed_udc.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index d75a4e070bf7..96f8193fca15 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -341,10 +341,6 @@ static void ast_udc_stop_activity(struct ast_udc_dev *udc)
 static int ast_udc_ep_enable(struct usb_ep *_ep,
 			     const struct usb_endpoint_descriptor *desc)
 {
-	u16 maxpacket = usb_endpoint_maxp(desc);
-	struct ast_udc_ep *ep = to_ast_ep(_ep);
-	struct ast_udc_dev *udc = ep->udc;
-	u8 epnum = usb_endpoint_num(desc);
 	unsigned long flags;
 	u32 ep_conf = 0;
 	u8 dir_in;
@@ -356,6 +352,11 @@ static int ast_udc_ep_enable(struct usb_ep *_ep,
 		return -EINVAL;
 	}

+	u16 maxpacket = usb_endpoint_maxp(desc);
+	struct ast_udc_ep *ep = to_ast_ep(_ep);
+	struct ast_udc_dev *udc = ep->udc;
+	u8 epnum = usb_endpoint_num(desc);
+
 	if (!udc->driver) {
 		EP_DBG(ep, "bogus device state\n");
 		return -ESHUTDOWN;
--
2.34.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-06-30  3:53 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29  8:07 [PATCH -next] usb: gadget: dereference before null check SebinSebastian
2022-06-29  8:07 ` SebinSebastian
2022-06-29  8:24 ` Greg Kroah-Hartman
2022-06-29  8:24   ` Greg Kroah-Hartman
2022-06-29 12:14   ` Sebin Sebastian
2022-06-29 12:14     ` Sebin Sebastian
2022-06-29 15:31     ` Greg Kroah-Hartman
2022-06-29 15:31       ` Greg Kroah-Hartman
2022-06-30  3:51       ` Sebin Sebastian
2022-06-30  3:51         ` Sebin Sebastian
2022-06-29 12:39 ` kernel test robot
2022-06-29 17:56 ` kernel test robot
2022-06-29 17:56   ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.