From: Maciej Fijalkowski <maciej.fijalkowski@intel.com> To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Jesper Dangaard Brouer <hawk@kernel.org>, John Fastabend <john.fastabend@gmail.com>, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Ira Weiny <ira.weiny@intel.com>, alexanderduyck@fb.com Subject: Re: [PATCH] ixgbe: Use kmap_local_page in ixgbe_check_lbtest_frame() Date: Thu, 30 Jun 2022 12:10:22 +0200 [thread overview] Message-ID: <Yr12jl1nEqqVI3TT@boxer> (raw) In-Reply-To: <20220629085836.18042-1-fmdefrancesco@gmail.com> On Wed, Jun 29, 2022 at 10:58:36AM +0200, Fabio M. De Francesco wrote: > The use of kmap() is being deprecated in favor of kmap_local_page(). > > With kmap_local_page(), the mapping is per thread, CPU local and not > globally visible. Furthermore, the mapping can be acquired from any context > (including interrupts). > > Therefore, use kmap_local_page() in ixgbe_check_lbtest_frame() because > this mapping is per thread, CPU local, and not globally visible. Hi, I'd like to ask why kmap was there in the first place and not plain page_address() ? Alex? > > Suggested-by: Ira Weiny <ira.weiny@intel.com> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c > index 628d0eb0599f..e64d40482bfd 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c > @@ -1966,14 +1966,14 @@ static bool ixgbe_check_lbtest_frame(struct ixgbe_rx_buffer *rx_buffer, > > frame_size >>= 1; > > - data = kmap(rx_buffer->page) + rx_buffer->page_offset; > + data = kmap_local_page(rx_buffer->page) + rx_buffer->page_offset; > > if (data[3] != 0xFF || > data[frame_size + 10] != 0xBE || > data[frame_size + 12] != 0xAF) > match = false; > > - kunmap(rx_buffer->page); > + kunmap_local(data); > > return match; > } > -- > 2.36.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com> To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com> Cc: Jesper Dangaard Brouer <hawk@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, intel-wired-lan@lists.osuosl.org, alexanderduyck@fb.com, John Fastabend <john.fastabend@gmail.com>, Jesse Brandeburg <jesse.brandeburg@intel.com>, Alexei Starovoitov <ast@kernel.org>, Eric Dumazet <edumazet@google.com>, netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>, bpf@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>, Ira Weiny <ira.weiny@intel.com>, "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org Subject: Re: [Intel-wired-lan] [PATCH] ixgbe: Use kmap_local_page in ixgbe_check_lbtest_frame() Date: Thu, 30 Jun 2022 12:10:22 +0200 [thread overview] Message-ID: <Yr12jl1nEqqVI3TT@boxer> (raw) In-Reply-To: <20220629085836.18042-1-fmdefrancesco@gmail.com> On Wed, Jun 29, 2022 at 10:58:36AM +0200, Fabio M. De Francesco wrote: > The use of kmap() is being deprecated in favor of kmap_local_page(). > > With kmap_local_page(), the mapping is per thread, CPU local and not > globally visible. Furthermore, the mapping can be acquired from any context > (including interrupts). > > Therefore, use kmap_local_page() in ixgbe_check_lbtest_frame() because > this mapping is per thread, CPU local, and not globally visible. Hi, I'd like to ask why kmap was there in the first place and not plain page_address() ? Alex? > > Suggested-by: Ira Weiny <ira.weiny@intel.com> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c > index 628d0eb0599f..e64d40482bfd 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c > @@ -1966,14 +1966,14 @@ static bool ixgbe_check_lbtest_frame(struct ixgbe_rx_buffer *rx_buffer, > > frame_size >>= 1; > > - data = kmap(rx_buffer->page) + rx_buffer->page_offset; > + data = kmap_local_page(rx_buffer->page) + rx_buffer->page_offset; > > if (data[3] != 0xFF || > data[frame_size + 10] != 0xBE || > data[frame_size + 12] != 0xAF) > match = false; > > - kunmap(rx_buffer->page); > + kunmap_local(data); > > return match; > } > -- > 2.36.1 > _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-06-30 10:10 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-29 8:58 [PATCH] ixgbe: Use kmap_local_page in ixgbe_check_lbtest_frame() Fabio M. De Francesco 2022-06-29 8:58 ` [Intel-wired-lan] " Fabio M. De Francesco 2022-06-30 10:10 ` Maciej Fijalkowski [this message] 2022-06-30 10:10 ` Maciej Fijalkowski 2022-06-30 15:17 ` Alexander Duyck 2022-06-30 15:17 ` Alexander Duyck 2022-06-30 15:21 ` Maciej Fijalkowski 2022-06-30 15:21 ` Maciej Fijalkowski 2022-06-30 15:25 ` Eric Dumazet 2022-06-30 15:25 ` Eric Dumazet 2022-06-30 16:09 ` Alexander Duyck 2022-06-30 16:09 ` Alexander Duyck 2022-06-30 18:18 ` Fabio M. De Francesco 2022-06-30 18:18 ` Fabio M. De Francesco 2022-06-30 21:59 ` Alexander Duyck 2022-06-30 21:59 ` Alexander Duyck 2022-07-01 15:36 ` Fabio M. De Francesco 2022-07-01 15:36 ` Fabio M. De Francesco 2022-09-22 20:07 ` Anirudh Venkataramanan 2022-09-22 20:07 ` Anirudh Venkataramanan 2022-09-22 20:58 ` Alexander Duyck 2022-09-22 20:58 ` Alexander Duyck 2022-09-22 22:38 ` Anirudh Venkataramanan 2022-09-22 22:38 ` Anirudh Venkataramanan 2022-09-23 15:05 ` Fabio M. De Francesco 2022-09-23 15:05 ` Fabio M. De Francesco 2022-09-23 17:59 ` Anirudh Venkataramanan 2022-09-23 17:59 ` Anirudh Venkataramanan 2022-09-30 22:03 ` Fabio M. De Francesco 2022-09-30 22:03 ` Fabio M. De Francesco 2022-09-23 15:31 ` Alexander Duyck 2022-09-23 15:31 ` Alexander Duyck 2022-09-23 18:50 ` Anirudh Venkataramanan 2022-09-23 18:50 ` Anirudh Venkataramanan 2022-09-23 21:31 ` Alexander Duyck 2022-09-23 21:31 ` Alexander Duyck 2022-06-30 18:13 ` Fabio M. De Francesco 2022-06-30 18:13 ` Fabio M. De Francesco 2022-08-04 12:53 ` G, GurucharanX 2022-08-04 12:53 ` G, GurucharanX
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Yr12jl1nEqqVI3TT@boxer \ --to=maciej.fijalkowski@intel.com \ --cc=alexanderduyck@fb.com \ --cc=anthony.l.nguyen@intel.com \ --cc=ast@kernel.org \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=fmdefrancesco@gmail.com \ --cc=hawk@kernel.org \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=ira.weiny@intel.com \ --cc=jesse.brandeburg@intel.com \ --cc=john.fastabend@gmail.com \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.