All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Tong Tiangen <tongtiangen@huawei.com>
Cc: James Morse <james.morse@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Robin Murphy <robin.murphy@arm.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
	linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Xie XiuQi <xiexiuqi@huawei.com>, Guohanjun <guohanjun@huawei.com>
Subject: Re: [PATCH -next v5 2/8] arm64: extable: make uaaccess helper use extable type EX_TYPE_UACCESS_ERR_ZERO
Date: Mon, 20 Jun 2022 15:26:37 +0100	[thread overview]
Message-ID: <YrCDnc8ZjgbHAhGU@FVFF77S0Q05N> (raw)
In-Reply-To: <908f4c14-b9cb-71f8-7a3c-7569f7c89033@huawei.com>

On Mon, Jun 20, 2022 at 10:13:41PM +0800, Tong Tiangen wrote:
> 
> 
> 在 2022/6/20 17:10, Mark Rutland 写道:
> > On Mon, Jun 20, 2022 at 10:59:12AM +0800, Tong Tiangen wrote:
> > > 在 2022/6/18 20:40, Mark Rutland 写道:
> > > The following errors are reported during compilation:
> > > [...]
> > > arch/arm64/lib/clear_user.S:45: Error: invalid operands (*ABS* and *UND*
> > > sections) for `<<'
> > > [...]
> > 
> > As above, I'm not seeing this.
> > 
> > This suggests that the EX_DATA_REG() macro is going wrong somehow. Assuming the
> > operand types correspond to the LHS and RHS of the expression, this would mean
> > the GPR number is defined, but the REG value is not, and I can't currently see
> > how that can happen.
 
> Now I can compile success, both versions 9.4.0 and 11.2.0.
> 
> I should have made a mistake. There is no problem using your implementation.
> I will send a new version these days.

No problem; thanks for confirming!

Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Tong Tiangen <tongtiangen@huawei.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-mm@kvack.org, Paul Mackerras <paulus@samba.org>,
	Guohanjun <guohanjun@huawei.com>, Will Deacon <will@kernel.org>,
	"H . Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Xie XiuQi <xiexiuqi@huawei.com>, Borislav Petkov <bp@alien8.de>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	Robin Murphy <robin.murphy@arm.com>,
	linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH -next v5 2/8] arm64: extable: make uaaccess helper use extable type EX_TYPE_UACCESS_ERR_ZERO
Date: Mon, 20 Jun 2022 15:26:37 +0100	[thread overview]
Message-ID: <YrCDnc8ZjgbHAhGU@FVFF77S0Q05N> (raw)
In-Reply-To: <908f4c14-b9cb-71f8-7a3c-7569f7c89033@huawei.com>

On Mon, Jun 20, 2022 at 10:13:41PM +0800, Tong Tiangen wrote:
> 
> 
> 在 2022/6/20 17:10, Mark Rutland 写道:
> > On Mon, Jun 20, 2022 at 10:59:12AM +0800, Tong Tiangen wrote:
> > > 在 2022/6/18 20:40, Mark Rutland 写道:
> > > The following errors are reported during compilation:
> > > [...]
> > > arch/arm64/lib/clear_user.S:45: Error: invalid operands (*ABS* and *UND*
> > > sections) for `<<'
> > > [...]
> > 
> > As above, I'm not seeing this.
> > 
> > This suggests that the EX_DATA_REG() macro is going wrong somehow. Assuming the
> > operand types correspond to the LHS and RHS of the expression, this would mean
> > the GPR number is defined, but the REG value is not, and I can't currently see
> > how that can happen.
 
> Now I can compile success, both versions 9.4.0 and 11.2.0.
> 
> I should have made a mistake. There is no problem using your implementation.
> I will send a new version these days.

No problem; thanks for confirming!

Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Tong Tiangen <tongtiangen@huawei.com>
Cc: James Morse <james.morse@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Robin Murphy <robin.murphy@arm.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
	linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Xie XiuQi <xiexiuqi@huawei.com>, Guohanjun <guohanjun@huawei.com>
Subject: Re: [PATCH -next v5 2/8] arm64: extable: make uaaccess helper use extable type EX_TYPE_UACCESS_ERR_ZERO
Date: Mon, 20 Jun 2022 15:26:37 +0100	[thread overview]
Message-ID: <YrCDnc8ZjgbHAhGU@FVFF77S0Q05N> (raw)
In-Reply-To: <908f4c14-b9cb-71f8-7a3c-7569f7c89033@huawei.com>

On Mon, Jun 20, 2022 at 10:13:41PM +0800, Tong Tiangen wrote:
> 
> 
> 在 2022/6/20 17:10, Mark Rutland 写道:
> > On Mon, Jun 20, 2022 at 10:59:12AM +0800, Tong Tiangen wrote:
> > > 在 2022/6/18 20:40, Mark Rutland 写道:
> > > The following errors are reported during compilation:
> > > [...]
> > > arch/arm64/lib/clear_user.S:45: Error: invalid operands (*ABS* and *UND*
> > > sections) for `<<'
> > > [...]
> > 
> > As above, I'm not seeing this.
> > 
> > This suggests that the EX_DATA_REG() macro is going wrong somehow. Assuming the
> > operand types correspond to the LHS and RHS of the expression, this would mean
> > the GPR number is defined, but the REG value is not, and I can't currently see
> > how that can happen.
 
> Now I can compile success, both versions 9.4.0 and 11.2.0.
> 
> I should have made a mistake. There is no problem using your implementation.
> I will send a new version these days.

No problem; thanks for confirming!

Mark.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-06-20 15:01 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-28  6:50 [PATCH -next v5 0/8]arm64: add machine check safe support Tong Tiangen
2022-05-28  6:50 ` Tong Tiangen
2022-05-28  6:50 ` Tong Tiangen
2022-05-28  6:50 ` [PATCH -next v5 1/8] arm64: extable: add new extable type EX_TYPE_KACCESS_ERR_ZERO support Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-06-17  8:23   ` Mark Rutland
2022-06-17  8:23     ` Mark Rutland
2022-06-17  8:23     ` Mark Rutland
2022-06-18  2:44     ` Tong Tiangen
2022-06-18  2:44       ` Tong Tiangen
2022-06-18  2:44       ` Tong Tiangen
2022-05-28  6:50 ` [PATCH -next v5 2/8] arm64: extable: make uaaccess helper use extable type EX_TYPE_UACCESS_ERR_ZERO Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-06-17  8:24   ` Mark Rutland
2022-06-17  8:24     ` Mark Rutland
2022-06-17  8:24     ` Mark Rutland
2022-06-18  3:26     ` Tong Tiangen
2022-06-18  3:26       ` Tong Tiangen
2022-06-18  3:26       ` Tong Tiangen
2022-06-18  8:42       ` Tong Tiangen
2022-06-18  8:42         ` Tong Tiangen
2022-06-18  8:42         ` Tong Tiangen
2022-06-18 12:40         ` Mark Rutland
2022-06-18 12:40           ` Mark Rutland
2022-06-18 12:40           ` Mark Rutland
2022-06-20  2:59           ` Tong Tiangen
2022-06-20  2:59             ` Tong Tiangen
2022-06-20  2:59             ` Tong Tiangen
2022-06-20  9:10             ` Mark Rutland
2022-06-20  9:10               ` Mark Rutland
2022-06-20  9:10               ` Mark Rutland
2022-06-20 13:32               ` Tong Tiangen
2022-06-20 13:32                 ` Tong Tiangen
2022-06-20 13:32                 ` Tong Tiangen
2022-06-20 14:13               ` Tong Tiangen
2022-06-20 14:13                 ` Tong Tiangen
2022-06-20 14:13                 ` Tong Tiangen
2022-06-20 14:26                 ` Mark Rutland [this message]
2022-06-20 14:26                   ` Mark Rutland
2022-06-20 14:26                   ` Mark Rutland
2022-05-28  6:50 ` [PATCH -next v5 3/8] arm64: extable: move _cond_extable to _cond_uaccess_extable Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-06-17  8:31   ` Mark Rutland
2022-06-17  8:31     ` Mark Rutland
2022-06-17  8:31     ` Mark Rutland
2022-05-28  6:50 ` [PATCH -next v5 4/8] arm64: extable: cleanup redundant extable type EX_TYPE_FIXUP Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-06-17  8:43   ` Mark Rutland
2022-06-17  8:43     ` Mark Rutland
2022-06-17  8:43     ` Mark Rutland
2022-05-28  6:50 ` [PATCH -next v5 5/8] Add generic fallback version of copy_mc_to_user() Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-05-28  6:50 ` [PATCH -next v5 6/8] arm64: add support for machine check error safe Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-06-17  8:55   ` Mark Rutland
2022-06-17  8:55     ` Mark Rutland
2022-06-17  8:55     ` Mark Rutland
2022-06-18  9:18     ` Tong Tiangen
2022-06-18  9:18       ` Tong Tiangen
2022-06-18  9:18       ` Tong Tiangen
2022-06-18 12:52       ` Mark Rutland
2022-06-18 12:52         ` Mark Rutland
2022-06-18 12:52         ` Mark Rutland
2022-06-20  1:53         ` Tong Tiangen
2022-06-20  1:53           ` Tong Tiangen
2022-06-20  1:53           ` Tong Tiangen
2022-05-28  6:50 ` [PATCH -next v5 7/8] arm64: add uaccess to machine check safe Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-06-17  9:06   ` Mark Rutland
2022-06-17  9:06     ` Mark Rutland
2022-06-17  9:06     ` Mark Rutland
2022-06-18  9:27     ` Tong Tiangen
2022-06-18  9:27       ` Tong Tiangen
2022-06-18  9:27       ` Tong Tiangen
2022-06-18 11:35       ` Mark Rutland
2022-06-18 11:35         ` Mark Rutland
2022-06-18 11:35         ` Mark Rutland
2022-06-20  2:04         ` Tong Tiangen
2022-06-20  2:04           ` Tong Tiangen
2022-06-20  2:04           ` Tong Tiangen
2022-05-28  6:50 ` [PATCH -next v5 8/8] arm64: add cow " Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen
2022-05-28  6:50   ` Tong Tiangen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrCDnc8ZjgbHAhGU@FVFF77S0Q05N \
    --to=mark.rutland@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=guohanjun@huawei.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=robin.murphy@arm.com \
    --cc=tglx@linutronix.de \
    --cc=tongtiangen@huawei.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.