All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jiang Jian <jiangjian@cdjrlc.com>
Cc: mchehab@kernel.org, hyun.kwon@xilinx.com,
	michal.simek@xilinx.com, linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: xilinx: drop unexpected word 'with' in comments
Date: Mon, 27 Jun 2022 02:32:24 +0300	[thread overview]
Message-ID: <YrjsiEgcNWTFFkUc@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220623122948.54839-1-jiangjian@cdjrlc.com>

Hi Jiang,

Thank you for the patch.

On Thu, Jun 23, 2022 at 08:29:48PM +0800, Jiang Jian wrote:
> there is an unexpected word 'with' in the comments that need to be dropped
> 
> file - drivers/media/platform/xilinx/xilinx-vip.h
> line -31
> 
>  * Pad IDs. IP cores with with multiple inputs or outputs should define
> 
> changed to:
> 
>  * Pad IDs. IP cores with multiple inputs or outputs should define

The first line of the commit message is enough, the rest duplicates the
content of the patch. No need to resubmit, I'll fix this when applying.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
> ---
>  drivers/media/platform/xilinx/xilinx-vip.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/xilinx/xilinx-vip.h b/drivers/media/platform/xilinx/xilinx-vip.h
> index d0b0e0600952..1c8dd59067fe 100644
> --- a/drivers/media/platform/xilinx/xilinx-vip.h
> +++ b/drivers/media/platform/xilinx/xilinx-vip.h
> @@ -28,7 +28,7 @@ struct clk;
>  #define XVIP_MAX_HEIGHT			7680
>  
>  /*
> - * Pad IDs. IP cores with with multiple inputs or outputs should define
> + * Pad IDs. IP cores with multiple inputs or outputs should define
>   * their own values.
>   */
>  #define XVIP_PAD_SINK			0

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jiang Jian <jiangjian@cdjrlc.com>
Cc: mchehab@kernel.org, hyun.kwon@xilinx.com,
	michal.simek@xilinx.com, linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: xilinx: drop unexpected word 'with' in comments
Date: Mon, 27 Jun 2022 02:32:24 +0300	[thread overview]
Message-ID: <YrjsiEgcNWTFFkUc@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220623122948.54839-1-jiangjian@cdjrlc.com>

Hi Jiang,

Thank you for the patch.

On Thu, Jun 23, 2022 at 08:29:48PM +0800, Jiang Jian wrote:
> there is an unexpected word 'with' in the comments that need to be dropped
> 
> file - drivers/media/platform/xilinx/xilinx-vip.h
> line -31
> 
>  * Pad IDs. IP cores with with multiple inputs or outputs should define
> 
> changed to:
> 
>  * Pad IDs. IP cores with multiple inputs or outputs should define

The first line of the commit message is enough, the rest duplicates the
content of the patch. No need to resubmit, I'll fix this when applying.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
> ---
>  drivers/media/platform/xilinx/xilinx-vip.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/xilinx/xilinx-vip.h b/drivers/media/platform/xilinx/xilinx-vip.h
> index d0b0e0600952..1c8dd59067fe 100644
> --- a/drivers/media/platform/xilinx/xilinx-vip.h
> +++ b/drivers/media/platform/xilinx/xilinx-vip.h
> @@ -28,7 +28,7 @@ struct clk;
>  #define XVIP_MAX_HEIGHT			7680
>  
>  /*
> - * Pad IDs. IP cores with with multiple inputs or outputs should define
> + * Pad IDs. IP cores with multiple inputs or outputs should define
>   * their own values.
>   */
>  #define XVIP_PAD_SINK			0

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-06-26 23:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-23 12:29 [PATCH] media: xilinx: drop unexpected word 'with' in comments Jiang Jian
2022-06-23 12:29 ` Jiang Jian
2022-06-26 23:32 ` Laurent Pinchart [this message]
2022-06-26 23:32   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrjsiEgcNWTFFkUc@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=hyun.kwon@xilinx.com \
    --cc=jiangjian@cdjrlc.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=michal.simek@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.