From: Peter Zijlstra <peterz@infradead.org>
To: Guo Ren <guoren@kernel.org>
Cc: Palmer Dabbelt <palmer@rivosinc.com>,
Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@redhat.com>,
Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH V7 4/5] asm-generic: spinlock: Add combo spinlock (ticket & queued)
Date: Mon, 4 Jul 2022 15:45:48 +0200 [thread overview]
Message-ID: <YsLvDHYlLgmfzP4n@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJF2gTQ0cmGJHPR=TzeDJDigiEgBL5-KabbR2WkS=dGJV7jSJA@mail.gmail.com>
On Mon, Jul 04, 2022 at 09:13:40PM +0800, Guo Ren wrote:
> > Urggghhhh....
> >
> > I really don't think you want this in generic code. Also, I'm thinking
> > any arch that does this wants to make sure it doesn't inline any of this
> Your advice is the same with Arnd, I would move static_branch out of generic.
>
> > stuff. That is, said arch must not have ARCH_INLINE_SPIN_*
> What do you mean? I've tested with ARCH_INLINE_SPIN_* and it's okay
> with EXPORT_SYMBOL(use_qspinlock_key).
Well, with the static_branch and the two paths I just don't see the code
being sane/small enough to inline. I mean, sure, you can force it to
inline the thing, but I'm not sure that's wise.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Guo Ren <guoren@kernel.org>
Cc: Palmer Dabbelt <palmer@rivosinc.com>,
Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@redhat.com>,
Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH V7 4/5] asm-generic: spinlock: Add combo spinlock (ticket & queued)
Date: Mon, 4 Jul 2022 15:45:48 +0200 [thread overview]
Message-ID: <YsLvDHYlLgmfzP4n@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJF2gTQ0cmGJHPR=TzeDJDigiEgBL5-KabbR2WkS=dGJV7jSJA@mail.gmail.com>
On Mon, Jul 04, 2022 at 09:13:40PM +0800, Guo Ren wrote:
> > Urggghhhh....
> >
> > I really don't think you want this in generic code. Also, I'm thinking
> > any arch that does this wants to make sure it doesn't inline any of this
> Your advice is the same with Arnd, I would move static_branch out of generic.
>
> > stuff. That is, said arch must not have ARCH_INLINE_SPIN_*
> What do you mean? I've tested with ARCH_INLINE_SPIN_* and it's okay
> with EXPORT_SYMBOL(use_qspinlock_key).
Well, with the static_branch and the two paths I just don't see the code
being sane/small enough to inline. I mean, sure, you can force it to
inline the thing, but I'm not sure that's wise.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-07-04 13:46 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 8:17 [PATCH V7 0/5] riscv: Add qspinlock support with combo style guoren
2022-06-28 8:17 ` guoren
2022-06-28 8:17 ` [PATCH V7 1/5] asm-generic: ticket-lock: Remove unnecessary atomic_read guoren
2022-06-28 8:17 ` guoren
2022-06-28 18:05 ` Waiman Long
2022-06-28 18:05 ` Waiman Long
2022-06-29 2:12 ` Guo Ren
2022-06-29 2:12 ` Guo Ren
2022-06-29 8:27 ` David Laight
2022-06-29 8:27 ` David Laight
2022-07-01 15:18 ` Guo Ren
2022-07-01 15:18 ` Guo Ren
2022-07-04 9:52 ` Peter Zijlstra
2022-07-04 9:52 ` Peter Zijlstra
2022-07-04 11:10 ` Guo Ren
2022-07-04 11:10 ` Guo Ren
2022-06-28 8:17 ` [PATCH V7 2/5] asm-generic: ticket-lock: Use the same struct definitions with qspinlock guoren
2022-06-28 8:17 ` guoren
2022-06-28 8:17 ` [PATCH V7 3/5] asm-generic: ticket-lock: Move into ticket_spinlock.h guoren
2022-06-28 8:17 ` guoren
2022-06-28 8:17 ` [PATCH V7 4/5] asm-generic: spinlock: Add combo spinlock (ticket & queued) guoren
2022-06-28 8:17 ` guoren
2022-06-28 18:13 ` Waiman Long
2022-06-28 18:13 ` Waiman Long
2022-06-29 1:17 ` Guo Ren
2022-06-29 1:17 ` Guo Ren
2022-06-29 1:34 ` Waiman Long
2022-06-29 1:34 ` Waiman Long
2022-06-29 2:29 ` Guo Ren
2022-06-29 2:29 ` Guo Ren
2022-06-29 7:08 ` Arnd Bergmann
2022-06-29 7:08 ` Arnd Bergmann
2022-06-29 8:24 ` Guo Ren
2022-06-29 8:24 ` Guo Ren
2022-06-29 8:29 ` Arnd Bergmann
2022-06-29 8:29 ` Arnd Bergmann
2022-07-01 12:18 ` Guo Ren
2022-07-01 12:18 ` Guo Ren
2022-06-29 12:53 ` Waiman Long
2022-06-29 12:53 ` Waiman Long
2022-07-04 9:57 ` Peter Zijlstra
2022-07-04 9:57 ` Peter Zijlstra
2022-07-04 13:13 ` Guo Ren
2022-07-04 13:13 ` Guo Ren
2022-07-04 13:45 ` Peter Zijlstra [this message]
2022-07-04 13:45 ` Peter Zijlstra
2022-06-28 8:17 ` [PATCH V7 5/5] riscv: Add qspinlock support guoren
2022-06-28 8:17 ` guoren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsLvDHYlLgmfzP4n@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arnd@arndb.de \
--cc=boqun.feng@gmail.com \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=palmer@rivosinc.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.