From: Andi Shyti <andi.shyti@linux.intel.com> To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> Cc: paulo.r.zanoni@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, matthew.auld@intel.com, daniel.vetter@intel.com, Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>, christian.koenig@amd.com Subject: Re: [Intel-gfx] [RFC 02/10] drm/i915/vm_bind: Bind and unbind mappings Date: Thu, 7 Jul 2022 03:41:26 +0200 [thread overview] Message-ID: <YsY5xoqu3VdZhHfY@alfio.lan> (raw) In-Reply-To: <8a21c7a72aeb74f80bd471496c3dcd7b6dcd1df1.camel@linux.intel.com> Hi, [...] > > @@ -28,7 +28,6 @@ static u32 object_max_page_size(struct > > intel_memory_region **placements, > > max_page_size = max_t(u32, max_page_size, mr- > > >min_page_size); > > } > > > > - GEM_BUG_ON(!max_page_size); > > return max_page_size; > > } > > Should this change be separated out? It's not immediately clear to a > reviewer why it is included. no, it's not, indeed... and is it correct to assume that the default size is I915_GTT_PAGE_SIZE_4K? [...] > > +#define assert_vm_bind_held(vm) lockdep_assert_held(&(vm)- > > >vm_bind_lock) > > + > > +static inline void i915_gem_vm_bind_lock(struct i915_address_space > > *vm) > > +{ > > + mutex_lock(&vm->vm_bind_lock); > > +} > > + > > +static inline int > > +i915_gem_vm_bind_lock_interruptible(struct i915_address_space *vm) > > +{ > > + return mutex_lock_interruptible(&vm->vm_bind_lock); > > +} > > + > > +static inline void i915_gem_vm_bind_unlock(struct i915_address_space > > *vm) > > +{ > > + mutex_unlock(&vm->vm_bind_lock); > > +} > > + > > Kerneldoc for the inlines. do we really need these oneline wrappers? Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com> To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> Cc: paulo.r.zanoni@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, matthew.auld@intel.com, daniel.vetter@intel.com, christian.koenig@amd.com Subject: Re: [Intel-gfx] [RFC 02/10] drm/i915/vm_bind: Bind and unbind mappings Date: Thu, 7 Jul 2022 03:41:26 +0200 [thread overview] Message-ID: <YsY5xoqu3VdZhHfY@alfio.lan> (raw) In-Reply-To: <8a21c7a72aeb74f80bd471496c3dcd7b6dcd1df1.camel@linux.intel.com> Hi, [...] > > @@ -28,7 +28,6 @@ static u32 object_max_page_size(struct > > intel_memory_region **placements, > > max_page_size = max_t(u32, max_page_size, mr- > > >min_page_size); > > } > > > > - GEM_BUG_ON(!max_page_size); > > return max_page_size; > > } > > Should this change be separated out? It's not immediately clear to a > reviewer why it is included. no, it's not, indeed... and is it correct to assume that the default size is I915_GTT_PAGE_SIZE_4K? [...] > > +#define assert_vm_bind_held(vm) lockdep_assert_held(&(vm)- > > >vm_bind_lock) > > + > > +static inline void i915_gem_vm_bind_lock(struct i915_address_space > > *vm) > > +{ > > + mutex_lock(&vm->vm_bind_lock); > > +} > > + > > +static inline int > > +i915_gem_vm_bind_lock_interruptible(struct i915_address_space *vm) > > +{ > > + return mutex_lock_interruptible(&vm->vm_bind_lock); > > +} > > + > > +static inline void i915_gem_vm_bind_unlock(struct i915_address_space > > *vm) > > +{ > > + mutex_unlock(&vm->vm_bind_lock); > > +} > > + > > Kerneldoc for the inlines. do we really need these oneline wrappers? Andi
next prev parent reply other threads:[~2022-07-07 1:41 UTC|newest] Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-01 22:50 [RFC 00/10] drm/i915/vm_bind: Add VM_BIND functionality Niranjana Vishwanathapura 2022-07-01 22:50 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-01 22:50 ` [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl Niranjana Vishwanathapura 2022-07-01 22:50 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-05 9:59 ` Hellstrom, Thomas 2022-07-05 9:59 ` Hellstrom, Thomas 2022-07-07 1:18 ` [Intel-gfx] " Andi Shyti 2022-07-07 1:18 ` Andi Shyti 2022-07-07 5:06 ` Niranjana Vishwanathapura 2022-07-07 5:01 ` Niranjana Vishwanathapura 2022-07-07 5:01 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-07 7:32 ` Hellstrom, Thomas 2022-07-07 7:32 ` [Intel-gfx] " Hellstrom, Thomas 2022-07-08 12:58 ` Niranjana Vishwanathapura 2022-07-08 12:58 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-01 22:50 ` [RFC 02/10] drm/i915/vm_bind: Bind and unbind mappings Niranjana Vishwanathapura 2022-07-01 22:50 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-06 16:21 ` Thomas Hellström 2022-07-06 16:21 ` [Intel-gfx] " Thomas Hellström 2022-07-07 1:41 ` Andi Shyti [this message] 2022-07-07 1:41 ` Andi Shyti 2022-07-07 5:48 ` Niranjana Vishwanathapura 2022-07-07 5:43 ` Niranjana Vishwanathapura 2022-07-07 5:43 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-07 8:14 ` Thomas Hellström 2022-07-07 8:14 ` [Intel-gfx] " Thomas Hellström 2022-07-08 12:57 ` Niranjana Vishwanathapura 2022-07-08 12:57 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-18 10:55 ` Tvrtko Ursulin 2022-07-26 5:07 ` Niranjana Vishwanathapura 2022-07-26 8:40 ` Tvrtko Ursulin 2022-07-01 22:50 ` [RFC 03/10] drm/i915/vm_bind: Support private and shared BOs Niranjana Vishwanathapura 2022-07-01 22:50 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-07 10:31 ` Hellstrom, Thomas 2022-07-07 10:31 ` [Intel-gfx] " Hellstrom, Thomas 2022-07-08 13:14 ` Niranjana Vishwanathapura 2022-07-08 13:14 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-08 13:43 ` Hellstrom, Thomas 2022-07-08 13:43 ` [Intel-gfx] " Hellstrom, Thomas 2022-07-08 14:44 ` Hellstrom, Thomas 2022-07-08 14:44 ` [Intel-gfx] " Hellstrom, Thomas 2022-07-09 20:13 ` Niranjana Vishwanathapura 2022-07-09 20:13 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-07 13:27 ` Christian König 2022-07-07 13:27 ` [Intel-gfx] " Christian König 2022-07-08 13:23 ` Niranjana Vishwanathapura 2022-07-08 13:23 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-08 17:32 ` Christian König 2022-07-08 17:32 ` [Intel-gfx] " Christian König 2022-07-09 20:14 ` Niranjana Vishwanathapura 2022-07-09 20:14 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-01 22:50 ` [RFC 04/10] drm/i915/vm_bind: Add out fence support Niranjana Vishwanathapura 2022-07-01 22:50 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-01 22:50 ` [RFC 05/10] drm/i915/vm_bind: Handle persistent vmas Niranjana Vishwanathapura 2022-07-01 22:50 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-04 17:05 ` Zeng, Oak 2022-07-04 17:05 ` Zeng, Oak 2022-07-05 9:20 ` Ramalingam C 2022-07-05 9:20 ` Ramalingam C 2022-07-05 13:50 ` Zeng, Oak 2022-07-05 13:50 ` Zeng, Oak 2022-07-07 6:00 ` Niranjana Vishwanathapura 2022-07-07 11:27 ` Hellstrom, Thomas 2022-07-07 11:27 ` [Intel-gfx] " Hellstrom, Thomas 2022-07-08 15:06 ` Niranjana Vishwanathapura 2022-07-08 15:06 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-01 22:50 ` [RFC 06/10] drm/i915/vm_bind: Add I915_GEM_EXECBUFFER3 ioctl Niranjana Vishwanathapura 2022-07-01 22:50 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-07 14:41 ` Hellstrom, Thomas 2022-07-07 14:41 ` [Intel-gfx] " Hellstrom, Thomas 2022-07-07 19:38 ` Andi Shyti 2022-07-07 19:38 ` Andi Shyti 2022-07-08 12:22 ` Hellstrom, Thomas 2022-07-08 12:22 ` Hellstrom, Thomas 2022-07-08 13:47 ` Niranjana Vishwanathapura 2022-07-08 13:47 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-08 14:37 ` Hellstrom, Thomas 2022-07-08 14:37 ` [Intel-gfx] " Hellstrom, Thomas 2022-07-09 20:23 ` Niranjana Vishwanathapura 2022-07-09 20:23 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-01 22:50 ` [RFC 07/10] drm/i915/vm_bind: Handle persistent vmas in execbuf3 Niranjana Vishwanathapura 2022-07-01 22:50 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-07 14:54 ` Hellstrom, Thomas 2022-07-07 14:54 ` [Intel-gfx] " Hellstrom, Thomas 2022-07-08 12:44 ` Niranjana Vishwanathapura 2022-07-08 12:44 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-08 13:03 ` Hellstrom, Thomas 2022-07-08 13:03 ` [Intel-gfx] " Hellstrom, Thomas 2022-07-09 20:25 ` Niranjana Vishwanathapura 2022-07-09 20:25 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-01 22:50 ` [RFC 08/10] drm/i915/vm_bind: userptr dma-resv changes Niranjana Vishwanathapura 2022-07-01 22:50 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-07 13:11 ` Hellstrom, Thomas 2022-07-07 13:11 ` [Intel-gfx] " Hellstrom, Thomas 2022-07-08 14:51 ` Niranjana Vishwanathapura 2022-07-08 14:51 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-08 15:20 ` Hellstrom, Thomas 2022-07-08 15:20 ` [Intel-gfx] " Hellstrom, Thomas 2022-07-09 20:56 ` Niranjana Vishwanathapura 2022-07-09 20:56 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-08 12:17 ` Hellstrom, Thomas 2022-07-08 12:17 ` [Intel-gfx] " Hellstrom, Thomas 2022-07-08 14:54 ` Niranjana Vishwanathapura 2022-07-08 14:54 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-01 22:50 ` [RFC 09/10] drm/i915/vm_bind: Skip vma_lookup for persistent vmas Niranjana Vishwanathapura 2022-07-01 22:50 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-05 8:57 ` Thomas Hellström 2022-07-05 8:57 ` Thomas Hellström 2022-07-08 12:40 ` Niranjana Vishwanathapura 2022-07-08 12:40 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-01 22:50 ` [RFC 10/10] drm/i915/vm_bind: Fix vm->vm_bind_mutex and vm->mutex nesting Niranjana Vishwanathapura 2022-07-01 22:50 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-05 8:40 ` Thomas Hellström 2022-07-05 8:40 ` [Intel-gfx] " Thomas Hellström 2022-07-06 16:33 ` Ramalingam C 2022-07-06 16:33 ` [Intel-gfx] " Ramalingam C 2022-07-07 5:56 ` Niranjana Vishwanathapura 2022-07-07 5:56 ` [Intel-gfx] " Niranjana Vishwanathapura 2022-07-01 23:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/vm_bind: Add VM_BIND functionality Patchwork 2022-07-01 23:19 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-07-01 23:40 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YsY5xoqu3VdZhHfY@alfio.lan \ --to=andi.shyti@linux.intel.com \ --cc=christian.koenig@amd.com \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=matthew.auld@intel.com \ --cc=niranjana.vishwanathapura@intel.com \ --cc=paulo.r.zanoni@intel.com \ --cc=thomas.hellstrom@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.