* [PATCH v2 0/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support @ 2021-12-29 19:31 Laurent Pinchart 2021-12-29 19:31 ` [PATCH v2 1/3] " Laurent Pinchart ` (2 more replies) 0 siblings, 3 replies; 17+ messages in thread From: Laurent Pinchart @ 2021-12-29 19:31 UTC (permalink / raw) To: linux-renesas-soc Cc: devicetree, Rob Herring, Kieran Bingham, Geert Uytterhoeven, Magnus Damm, Chris Paterson Hello, This small patchs series adds two DT overlays that model a Mitsubishi AA1024XD12 panel connected to a Salvator-X(S) board or a Draak or Ebisu board. The panel is external to the development board and is optional, so DT overlays seem to be the best option to me. They can easily be applied by U-Boot. For instance, when booting a FIT image, a list of configurations can be specified. Here's the boot script I'm using (with the U-Boot bootcmd simply set to "dhcp && source"): -------- setenv bootargs "console=ttySC0,115200 rw root=/dev/nfs ip=dhcp" setenv bootfile gen3/kernel_fdt.itb setenv fdtfile r8a77965-salvator-xs.dtb setenv overlay_files "salvator-panel-aa104xd12.dtbo" for overlay in ${overlay_files}; do setenv overlaystring "${overlaystring}\\#conf-${overlay}" done tftpboot ${bootfile} bootm ${fileaddr}#conf-${fdtfile}${overlaystring} -------- This is much simpler than the hack branch I used to carry with per-board DT changes to enable panel support on a particular board (and last but not least, it hopefully can be merged in mainline !). The only difference between the two overlays is the LVDS output that the panel is connected to (LVDS0 on Salvator-X(S), and LVDS1 on Draak and Ebisu). On my xmas wish list is a mechanism to make this configurable at the time the overlay is applied, but I think I'll be a sad little boy on xmas day. As these are the first DT overlays for Renesas boards in the mainline kernel, comments are welcome. If the approach gets positive feedback, we could turn other external add-ons (panels, camera modules, ...) into overlays as well. Compared to v1, this version creates the endpoints for the lvds0 and lvds1 ports in the overlays, to take into account the changes from https://lore.kernel.org/all/20211229191838.27922-1-laurent.pinchart+renesas@ideasonboard.com/. Laurent Pinchart (3): arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support arm64: dts: renesas: Add panel overlay for Salvator-X(S) boards arm64: dts: renesas: Add panel overlay for Draak and Ebisu boards .../arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi | 39 ------------------- arch/arm64/boot/dts/renesas/Makefile | 3 ++ .../renesas/draak-ebisu-panel-aa104xd12.dts | 36 +++++++++++++++++ .../boot/dts/renesas/panel-aa104xd12.dtsi | 30 ++++++++++++++ .../dts/renesas/salvator-panel-aa104xd12.dts | 36 +++++++++++++++++ 5 files changed, 105 insertions(+), 39 deletions(-) delete mode 100644 arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi create mode 100644 arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dts create mode 100644 arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi create mode 100644 arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dts base-commit: 2b534e90a1e31c7fc9536b512b72274cc3575f4c -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 1/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support 2021-12-29 19:31 [PATCH v2 0/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support Laurent Pinchart @ 2021-12-29 19:31 ` Laurent Pinchart 2022-01-26 12:18 ` Geert Uytterhoeven 2022-02-21 14:38 ` Kieran Bingham 2021-12-29 19:31 ` [PATCH v2 2/3] arm64: dts: renesas: Add panel overlay for Salvator-X(S) boards Laurent Pinchart 2021-12-29 19:31 ` [PATCH v2 3/3] arm64: dts: renesas: Add panel overlay for Draak and Ebisu boards Laurent Pinchart 2 siblings, 2 replies; 17+ messages in thread From: Laurent Pinchart @ 2021-12-29 19:31 UTC (permalink / raw) To: linux-renesas-soc Cc: devicetree, Rob Herring, Kieran Bingham, Geert Uytterhoeven, Magnus Damm, Chris Paterson The Mitsubishi AA1024XD12 panel can be used for R-Car Gen2 and Gen3 boards as an optional external panel. It is described in the arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi file as a direct child of the DT root node. This allows including r8a77xx-aa104xd12-panel.dtsi in board device trees, with other minor modifications, to enable the panel. This is however not how external components should be modelled. Instead of modifying the board device tree to enable the panel, it should be compiled as a DT overlay, to be loaded by the boot loader. Prepare the r8a77xx-aa104xd12-panel.dtsi file for this usage by declaring a panel node only, without hardcoding its path. Overlay sources can then include r8a77xx-aa104xd12-panel.dtsi where appropriate. This change doesn't cause any regression as r8a77xx-aa104xd12-panel.dtsi is currently unused. As overlay support for this panel has only been tested with Gen3 hardware, and Gen2 support will require more development, move the file to arch/arm64/boot/dts/renesas/. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- .../arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi | 39 ------------------- .../boot/dts/renesas/panel-aa104xd12.dtsi | 30 ++++++++++++++ 2 files changed, 30 insertions(+), 39 deletions(-) delete mode 100644 arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi create mode 100644 arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi diff --git a/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi b/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi deleted file mode 100644 index 79fce67ebb1c..000000000000 --- a/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi +++ /dev/null @@ -1,39 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* - * Common file for the AA104XD12 panel connected to Renesas R-Car boards - * - * Copyright (C) 2014 Renesas Electronics Corp. - */ - -/ { - panel { - compatible = "mitsubishi,aa104xd12", "panel-lvds"; - - width-mm = <210>; - height-mm = <158>; - data-mapping = "jeida-18"; - - panel-timing { - /* 1024x768 @65Hz */ - clock-frequency = <65000000>; - hactive = <1024>; - vactive = <768>; - hsync-len = <136>; - hfront-porch = <20>; - hback-porch = <160>; - vfront-porch = <3>; - vback-porch = <29>; - vsync-len = <6>; - }; - - port { - panel_in: endpoint { - remote-endpoint = <&lvds_connector>; - }; - }; - }; -}; - -&lvds_connector { - remote-endpoint = <&panel_in>; -}; diff --git a/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi b/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi new file mode 100644 index 000000000000..6e9f447d8fe1 --- /dev/null +++ b/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi @@ -0,0 +1,30 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Common file for the AA104XD12 panel connected to Renesas R-Car Gen3 boards. + * + * Copyright (C) 2021 Renesas Electronics Corp. + */ + +panel { + compatible = "mitsubishi,aa104xd12", "panel-lvds"; + + width-mm = <210>; + height-mm = <158>; + data-mapping = "jeida-18"; + + panel-timing { + /* 1024x768 @65Hz */ + clock-frequency = <65000000>; + hactive = <1024>; + vactive = <768>; + hsync-len = <136>; + hfront-porch = <20>; + hback-porch = <160>; + vfront-porch = <3>; + vback-porch = <29>; + vsync-len = <6>; + }; + + port { + }; +}; -- Regards, Laurent Pinchart ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support 2021-12-29 19:31 ` [PATCH v2 1/3] " Laurent Pinchart @ 2022-01-26 12:18 ` Geert Uytterhoeven 2022-01-26 18:58 ` Laurent Pinchart 2022-02-21 14:38 ` Kieran Bingham 1 sibling, 1 reply; 17+ messages in thread From: Geert Uytterhoeven @ 2022-01-26 12:18 UTC (permalink / raw) To: Laurent Pinchart Cc: Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring, Kieran Bingham, Geert Uytterhoeven, Magnus Damm, Chris Paterson Hi Laurent, On Wed, Dec 29, 2021 at 8:31 PM Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > The Mitsubishi AA1024XD12 panel can be used for R-Car Gen2 and Gen3 > boards as an optional external panel. It is described in the > arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi file as a direct child of the > DT root node. This allows including r8a77xx-aa104xd12-panel.dtsi in > board device trees, with other minor modifications, to enable the panel. > > This is however not how external components should be modelled. Instead > of modifying the board device tree to enable the panel, it should be > compiled as a DT overlay, to be loaded by the boot loader. > > Prepare the r8a77xx-aa104xd12-panel.dtsi file for this usage by > declaring a panel node only, without hardcoding its path. Overlay > sources can then include r8a77xx-aa104xd12-panel.dtsi where appropriate. > > This change doesn't cause any regression as r8a77xx-aa104xd12-panel.dtsi > is currently unused. As overlay support for this panel has only been > tested with Gen3 hardware, and Gen2 support will require more > development, move the file to arch/arm64/boot/dts/renesas/. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Thanks for your patch! > --- a/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi > - * Copyright (C) 2014 Renesas Electronics Corp. > +++ b/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi > + * Copyright (C) 2021 Renesas Electronics Corp. Shouldn't you keep the year? Not much has changed. Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support 2022-01-26 12:18 ` Geert Uytterhoeven @ 2022-01-26 18:58 ` Laurent Pinchart 2022-01-26 19:15 ` Geert Uytterhoeven 0 siblings, 1 reply; 17+ messages in thread From: Laurent Pinchart @ 2022-01-26 18:58 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring, Kieran Bingham, Geert Uytterhoeven, Magnus Damm, Chris Paterson Hi Geert, On Wed, Jan 26, 2022 at 01:18:56PM +0100, Geert Uytterhoeven wrote: > On Wed, Dec 29, 2021 at 8:31 PM Laurent Pinchart wrote: > > The Mitsubishi AA1024XD12 panel can be used for R-Car Gen2 and Gen3 > > boards as an optional external panel. It is described in the > > arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi file as a direct child of the > > DT root node. This allows including r8a77xx-aa104xd12-panel.dtsi in > > board device trees, with other minor modifications, to enable the panel. > > > > This is however not how external components should be modelled. Instead > > of modifying the board device tree to enable the panel, it should be > > compiled as a DT overlay, to be loaded by the boot loader. > > > > Prepare the r8a77xx-aa104xd12-panel.dtsi file for this usage by > > declaring a panel node only, without hardcoding its path. Overlay > > sources can then include r8a77xx-aa104xd12-panel.dtsi where appropriate. > > > > This change doesn't cause any regression as r8a77xx-aa104xd12-panel.dtsi > > is currently unused. As overlay support for this panel has only been > > tested with Gen3 hardware, and Gen2 support will require more > > development, move the file to arch/arm64/boot/dts/renesas/. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Thanks for your patch! > > > --- a/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi > > > - * Copyright (C) 2014 Renesas Electronics Corp. > > > +++ b/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi > > > + * Copyright (C) 2021 Renesas Electronics Corp. > > Shouldn't you keep the year? Not much has changed. Indeed. > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> I see you've reviewed the whole series. Can you pick it up ? -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support 2022-01-26 18:58 ` Laurent Pinchart @ 2022-01-26 19:15 ` Geert Uytterhoeven 2022-01-26 23:57 ` Laurent Pinchart 0 siblings, 1 reply; 17+ messages in thread From: Geert Uytterhoeven @ 2022-01-26 19:15 UTC (permalink / raw) To: Laurent Pinchart Cc: Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring, Kieran Bingham, Geert Uytterhoeven, Magnus Damm, Chris Paterson Hi Laurent, On Wed, Jan 26, 2022 at 7:58 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Wed, Jan 26, 2022 at 01:18:56PM +0100, Geert Uytterhoeven wrote: > > On Wed, Dec 29, 2021 at 8:31 PM Laurent Pinchart wrote: > > > The Mitsubishi AA1024XD12 panel can be used for R-Car Gen2 and Gen3 > > > boards as an optional external panel. It is described in the > > > arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi file as a direct child of the > > > DT root node. This allows including r8a77xx-aa104xd12-panel.dtsi in > > > board device trees, with other minor modifications, to enable the panel. > > > > > > This is however not how external components should be modelled. Instead > > > of modifying the board device tree to enable the panel, it should be > > > compiled as a DT overlay, to be loaded by the boot loader. > > > > > > Prepare the r8a77xx-aa104xd12-panel.dtsi file for this usage by > > > declaring a panel node only, without hardcoding its path. Overlay > > > sources can then include r8a77xx-aa104xd12-panel.dtsi where appropriate. > > > > > > This change doesn't cause any regression as r8a77xx-aa104xd12-panel.dtsi > > > is currently unused. As overlay support for this panel has only been > > > tested with Gen3 hardware, and Gen2 support will require more > > > development, move the file to arch/arm64/boot/dts/renesas/. > > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > I see you've reviewed the whole series. Can you pick it up ? I believe it depends on the removal of the empty endpoints, for which we're waiting for feedback from Rob, IIRC? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support 2022-01-26 19:15 ` Geert Uytterhoeven @ 2022-01-26 23:57 ` Laurent Pinchart 2022-07-07 2:25 ` Laurent Pinchart 0 siblings, 1 reply; 17+ messages in thread From: Laurent Pinchart @ 2022-01-26 23:57 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring, Kieran Bingham, Geert Uytterhoeven, Magnus Damm, Chris Paterson Hi Geert, On Wed, Jan 26, 2022 at 08:15:26PM +0100, Geert Uytterhoeven wrote: > On Wed, Jan 26, 2022 at 7:58 PM Laurent Pinchart wrote: > > On Wed, Jan 26, 2022 at 01:18:56PM +0100, Geert Uytterhoeven wrote: > > > On Wed, Dec 29, 2021 at 8:31 PM Laurent Pinchart wrote: > > > > The Mitsubishi AA1024XD12 panel can be used for R-Car Gen2 and Gen3 > > > > boards as an optional external panel. It is described in the > > > > arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi file as a direct child of the > > > > DT root node. This allows including r8a77xx-aa104xd12-panel.dtsi in > > > > board device trees, with other minor modifications, to enable the panel. > > > > > > > > This is however not how external components should be modelled. Instead > > > > of modifying the board device tree to enable the panel, it should be > > > > compiled as a DT overlay, to be loaded by the boot loader. > > > > > > > > Prepare the r8a77xx-aa104xd12-panel.dtsi file for this usage by > > > > declaring a panel node only, without hardcoding its path. Overlay > > > > sources can then include r8a77xx-aa104xd12-panel.dtsi where appropriate. > > > > > > > > This change doesn't cause any regression as r8a77xx-aa104xd12-panel.dtsi > > > > is currently unused. As overlay support for this panel has only been > > > > tested with Gen3 hardware, and Gen2 support will require more > > > > development, move the file to arch/arm64/boot/dts/renesas/. > > > > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > > I see you've reviewed the whole series. Can you pick it up ? > > I believe it depends on the removal of the empty endpoints, for which > we're waiting for feedback from Rob, IIRC? You're right. Let's wait some more time then. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support 2022-01-26 23:57 ` Laurent Pinchart @ 2022-07-07 2:25 ` Laurent Pinchart 2022-07-07 7:30 ` Geert Uytterhoeven 0 siblings, 1 reply; 17+ messages in thread From: Laurent Pinchart @ 2022-07-07 2:25 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring, Kieran Bingham, Geert Uytterhoeven, Magnus Damm, Chris Paterson On Thu, Jan 27, 2022 at 01:57:05AM +0200, Laurent Pinchart wrote: > On Wed, Jan 26, 2022 at 08:15:26PM +0100, Geert Uytterhoeven wrote: > > On Wed, Jan 26, 2022 at 7:58 PM Laurent Pinchart wrote: > > > On Wed, Jan 26, 2022 at 01:18:56PM +0100, Geert Uytterhoeven wrote: > > > > On Wed, Dec 29, 2021 at 8:31 PM Laurent Pinchart wrote: > > > > > The Mitsubishi AA1024XD12 panel can be used for R-Car Gen2 and Gen3 > > > > > boards as an optional external panel. It is described in the > > > > > arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi file as a direct child of the > > > > > DT root node. This allows including r8a77xx-aa104xd12-panel.dtsi in > > > > > board device trees, with other minor modifications, to enable the panel. > > > > > > > > > > This is however not how external components should be modelled. Instead > > > > > of modifying the board device tree to enable the panel, it should be > > > > > compiled as a DT overlay, to be loaded by the boot loader. > > > > > > > > > > Prepare the r8a77xx-aa104xd12-panel.dtsi file for this usage by > > > > > declaring a panel node only, without hardcoding its path. Overlay > > > > > sources can then include r8a77xx-aa104xd12-panel.dtsi where appropriate. > > > > > > > > > > This change doesn't cause any regression as r8a77xx-aa104xd12-panel.dtsi > > > > > is currently unused. As overlay support for this panel has only been > > > > > tested with Gen3 hardware, and Gen2 support will require more > > > > > development, move the file to arch/arm64/boot/dts/renesas/. > > > > > > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > > > > I see you've reviewed the whole series. Can you pick it up ? > > > > I believe it depends on the removal of the empty endpoints, for which > > we're waiting for feedback from Rob, IIRC? > > You're right. Let's wait some more time then. How should we proceed with this ? -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support 2022-07-07 2:25 ` Laurent Pinchart @ 2022-07-07 7:30 ` Geert Uytterhoeven 2022-07-07 8:12 ` Laurent Pinchart 0 siblings, 1 reply; 17+ messages in thread From: Geert Uytterhoeven @ 2022-07-07 7:30 UTC (permalink / raw) To: Laurent Pinchart Cc: Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring, Kieran Bingham, Geert Uytterhoeven, Magnus Damm, Chris Paterson Hi Laurent, On Thu, Jul 7, 2022 at 4:25 AM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Thu, Jan 27, 2022 at 01:57:05AM +0200, Laurent Pinchart wrote: > > On Wed, Jan 26, 2022 at 08:15:26PM +0100, Geert Uytterhoeven wrote: > > > On Wed, Jan 26, 2022 at 7:58 PM Laurent Pinchart wrote: > > > > On Wed, Jan 26, 2022 at 01:18:56PM +0100, Geert Uytterhoeven wrote: > > > > > On Wed, Dec 29, 2021 at 8:31 PM Laurent Pinchart wrote: > > > > > > The Mitsubishi AA1024XD12 panel can be used for R-Car Gen2 and Gen3 > > > > > > boards as an optional external panel. It is described in the > > > > > > arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi file as a direct child of the > > > > > > DT root node. This allows including r8a77xx-aa104xd12-panel.dtsi in > > > > > > board device trees, with other minor modifications, to enable the panel. > > > > > > > > > > > > This is however not how external components should be modelled. Instead > > > > > > of modifying the board device tree to enable the panel, it should be > > > > > > compiled as a DT overlay, to be loaded by the boot loader. > > > > > > > > > > > > Prepare the r8a77xx-aa104xd12-panel.dtsi file for this usage by > > > > > > declaring a panel node only, without hardcoding its path. Overlay > > > > > > sources can then include r8a77xx-aa104xd12-panel.dtsi where appropriate. > > > > > > > > > > > > This change doesn't cause any regression as r8a77xx-aa104xd12-panel.dtsi > > > > > > is currently unused. As overlay support for this panel has only been > > > > > > tested with Gen3 hardware, and Gen2 support will require more > > > > > > development, move the file to arch/arm64/boot/dts/renesas/. > > > > > > > > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > > > > > > I see you've reviewed the whole series. Can you pick it up ? > > > > > > I believe it depends on the removal of the empty endpoints, for which > > > we're waiting for feedback from Rob, IIRC? > > > > You're right. Let's wait some more time then. > > How should we proceed with this ? That dependency is commit 747bbcd3aacd95fe ("arm64: dts: renesas: Remove empty rgb output endpoints") in v5.19-rc1, right? So I can take this for v5.20, or are any other changes needed? Please confirm. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support 2022-07-07 7:30 ` Geert Uytterhoeven @ 2022-07-07 8:12 ` Laurent Pinchart 0 siblings, 0 replies; 17+ messages in thread From: Laurent Pinchart @ 2022-07-07 8:12 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring, Kieran Bingham, Geert Uytterhoeven, Magnus Damm, Chris Paterson Hi Geert, On Thu, Jul 07, 2022 at 09:30:23AM +0200, Geert Uytterhoeven wrote: > On Thu, Jul 7, 2022 at 4:25 AM Laurent Pinchart wrote: > > On Thu, Jan 27, 2022 at 01:57:05AM +0200, Laurent Pinchart wrote: > > > On Wed, Jan 26, 2022 at 08:15:26PM +0100, Geert Uytterhoeven wrote: > > > > On Wed, Jan 26, 2022 at 7:58 PM Laurent Pinchart wrote: > > > > > On Wed, Jan 26, 2022 at 01:18:56PM +0100, Geert Uytterhoeven wrote: > > > > > > On Wed, Dec 29, 2021 at 8:31 PM Laurent Pinchart wrote: > > > > > > > The Mitsubishi AA1024XD12 panel can be used for R-Car Gen2 and Gen3 > > > > > > > boards as an optional external panel. It is described in the > > > > > > > arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi file as a direct child of the > > > > > > > DT root node. This allows including r8a77xx-aa104xd12-panel.dtsi in > > > > > > > board device trees, with other minor modifications, to enable the panel. > > > > > > > > > > > > > > This is however not how external components should be modelled. Instead > > > > > > > of modifying the board device tree to enable the panel, it should be > > > > > > > compiled as a DT overlay, to be loaded by the boot loader. > > > > > > > > > > > > > > Prepare the r8a77xx-aa104xd12-panel.dtsi file for this usage by > > > > > > > declaring a panel node only, without hardcoding its path. Overlay > > > > > > > sources can then include r8a77xx-aa104xd12-panel.dtsi where appropriate. > > > > > > > > > > > > > > This change doesn't cause any regression as r8a77xx-aa104xd12-panel.dtsi > > > > > > > is currently unused. As overlay support for this panel has only been > > > > > > > tested with Gen3 hardware, and Gen2 support will require more > > > > > > > development, move the file to arch/arm64/boot/dts/renesas/. > > > > > > > > > > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > > > > > > > > I see you've reviewed the whole series. Can you pick it up ? > > > > > > > > I believe it depends on the removal of the empty endpoints, for which > > > > we're waiting for feedback from Rob, IIRC? > > > > > > You're right. Let's wait some more time then. > > > > How should we proceed with this ? > > That dependency is commit 747bbcd3aacd95fe ("arm64: dts: renesas: > Remove empty rgb output endpoints") in v5.19-rc1, right? > So I can take this for v5.20, or are any other changes needed? > > Please confirm. To my knowledge everything is good and ready to go. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support 2021-12-29 19:31 ` [PATCH v2 1/3] " Laurent Pinchart 2022-01-26 12:18 ` Geert Uytterhoeven @ 2022-02-21 14:38 ` Kieran Bingham 2022-02-21 14:42 ` Laurent Pinchart 1 sibling, 1 reply; 17+ messages in thread From: Kieran Bingham @ 2022-02-21 14:38 UTC (permalink / raw) To: Laurent Pinchart, linux-renesas-soc Cc: devicetree, Rob Herring, Geert Uytterhoeven, Magnus Damm, Chris Paterson Quoting Laurent Pinchart (2021-12-29 19:31:33) > The Mitsubishi AA1024XD12 panel can be used for R-Car Gen2 and Gen3 > boards as an optional external panel. It is described in the > arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi file as a direct child of the > DT root node. This allows including r8a77xx-aa104xd12-panel.dtsi in > board device trees, with other minor modifications, to enable the panel. > > This is however not how external components should be modelled. Instead > of modifying the board device tree to enable the panel, it should be > compiled as a DT overlay, to be loaded by the boot loader. > > Prepare the r8a77xx-aa104xd12-panel.dtsi file for this usage by > declaring a panel node only, without hardcoding its path. Overlay > sources can then include r8a77xx-aa104xd12-panel.dtsi where appropriate. > > This change doesn't cause any regression as r8a77xx-aa104xd12-panel.dtsi > is currently unused. As overlay support for this panel has only been > tested with Gen3 hardware, and Gen2 support will require more > development, move the file to arch/arm64/boot/dts/renesas/. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > .../arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi | 39 ------------------- > .../boot/dts/renesas/panel-aa104xd12.dtsi | 30 ++++++++++++++ > 2 files changed, 30 insertions(+), 39 deletions(-) > delete mode 100644 arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi > create mode 100644 arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi > > diff --git a/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi b/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi > deleted file mode 100644 > index 79fce67ebb1c..000000000000 > --- a/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi > +++ /dev/null > @@ -1,39 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0 > -/* > - * Common file for the AA104XD12 panel connected to Renesas R-Car boards > - * > - * Copyright (C) 2014 Renesas Electronics Corp. > - */ > - > -/ { > - panel { > - compatible = "mitsubishi,aa104xd12", "panel-lvds"; > - > - width-mm = <210>; > - height-mm = <158>; > - data-mapping = "jeida-18"; > - > - panel-timing { > - /* 1024x768 @65Hz */ > - clock-frequency = <65000000>; > - hactive = <1024>; > - vactive = <768>; > - hsync-len = <136>; > - hfront-porch = <20>; > - hback-porch = <160>; > - vfront-porch = <3>; > - vback-porch = <29>; > - vsync-len = <6>; > - }; > - > - port { > - panel_in: endpoint { > - remote-endpoint = <&lvds_connector>; > - }; > - }; > - }; > -}; > - > -&lvds_connector { > - remote-endpoint = <&panel_in>; > -}; > diff --git a/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi b/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi > new file mode 100644 > index 000000000000..6e9f447d8fe1 > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi Is this a device directly on the renesas board itself? I still wonder if 'extra' overlays should be in a subfolder here, or ... even potentially some more common location - but this can do for now I guess. And I see I gave this on v1, but /after/ you posted v2 ;-) You can keep it though ... Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > @@ -0,0 +1,30 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Common file for the AA104XD12 panel connected to Renesas R-Car Gen3 boards. > + * > + * Copyright (C) 2021 Renesas Electronics Corp. > + */ > + > +panel { > + compatible = "mitsubishi,aa104xd12", "panel-lvds"; > + > + width-mm = <210>; > + height-mm = <158>; > + data-mapping = "jeida-18"; > + > + panel-timing { > + /* 1024x768 @65Hz */ > + clock-frequency = <65000000>; > + hactive = <1024>; > + vactive = <768>; > + hsync-len = <136>; > + hfront-porch = <20>; > + hback-porch = <160>; > + vfront-porch = <3>; > + vback-porch = <29>; > + vsync-len = <6>; > + }; > + > + port { > + }; > +}; > -- > Regards, > > Laurent Pinchart > ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support 2022-02-21 14:38 ` Kieran Bingham @ 2022-02-21 14:42 ` Laurent Pinchart 0 siblings, 0 replies; 17+ messages in thread From: Laurent Pinchart @ 2022-02-21 14:42 UTC (permalink / raw) To: Kieran Bingham Cc: linux-renesas-soc, devicetree, Rob Herring, Geert Uytterhoeven, Magnus Damm, Chris Paterson On Mon, Feb 21, 2022 at 02:38:24PM +0000, Kieran Bingham wrote: > Quoting Laurent Pinchart (2021-12-29 19:31:33) > > The Mitsubishi AA1024XD12 panel can be used for R-Car Gen2 and Gen3 > > boards as an optional external panel. It is described in the > > arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi file as a direct child of the > > DT root node. This allows including r8a77xx-aa104xd12-panel.dtsi in > > board device trees, with other minor modifications, to enable the panel. > > > > This is however not how external components should be modelled. Instead > > of modifying the board device tree to enable the panel, it should be > > compiled as a DT overlay, to be loaded by the boot loader. > > > > Prepare the r8a77xx-aa104xd12-panel.dtsi file for this usage by > > declaring a panel node only, without hardcoding its path. Overlay > > sources can then include r8a77xx-aa104xd12-panel.dtsi where appropriate. > > > > This change doesn't cause any regression as r8a77xx-aa104xd12-panel.dtsi > > is currently unused. As overlay support for this panel has only been > > tested with Gen3 hardware, and Gen2 support will require more > > development, move the file to arch/arm64/boot/dts/renesas/. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > --- > > .../arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi | 39 ------------------- > > .../boot/dts/renesas/panel-aa104xd12.dtsi | 30 ++++++++++++++ > > 2 files changed, 30 insertions(+), 39 deletions(-) > > delete mode 100644 arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi > > create mode 100644 arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi > > > > diff --git a/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi b/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi > > deleted file mode 100644 > > index 79fce67ebb1c..000000000000 > > --- a/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi > > +++ /dev/null > > @@ -1,39 +0,0 @@ > > -// SPDX-License-Identifier: GPL-2.0 > > -/* > > - * Common file for the AA104XD12 panel connected to Renesas R-Car boards > > - * > > - * Copyright (C) 2014 Renesas Electronics Corp. > > - */ > > - > > -/ { > > - panel { > > - compatible = "mitsubishi,aa104xd12", "panel-lvds"; > > - > > - width-mm = <210>; > > - height-mm = <158>; > > - data-mapping = "jeida-18"; > > - > > - panel-timing { > > - /* 1024x768 @65Hz */ > > - clock-frequency = <65000000>; > > - hactive = <1024>; > > - vactive = <768>; > > - hsync-len = <136>; > > - hfront-porch = <20>; > > - hback-porch = <160>; > > - vfront-porch = <3>; > > - vback-porch = <29>; > > - vsync-len = <6>; > > - }; > > - > > - port { > > - panel_in: endpoint { > > - remote-endpoint = <&lvds_connector>; > > - }; > > - }; > > - }; > > -}; > > - > > -&lvds_connector { > > - remote-endpoint = <&panel_in>; > > -}; > > diff --git a/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi b/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi > > new file mode 100644 > > index 000000000000..6e9f447d8fe1 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi > > Is this a device directly on the renesas board itself? I would have included it in the board DT if that had been the case :-) > I still wonder if > 'extra' overlays should be in a subfolder here, or ... even potentially > some more common location - but this can do for now I guess. They should, but they should then be parametric, it's a whole other story. > And I see I gave this on v1, but /after/ you posted v2 ;-) > > You can keep it though ... > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > @@ -0,0 +1,30 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Common file for the AA104XD12 panel connected to Renesas R-Car Gen3 boards. > > + * > > + * Copyright (C) 2021 Renesas Electronics Corp. > > + */ > > + > > +panel { > > + compatible = "mitsubishi,aa104xd12", "panel-lvds"; > > + > > + width-mm = <210>; > > + height-mm = <158>; > > + data-mapping = "jeida-18"; > > + > > + panel-timing { > > + /* 1024x768 @65Hz */ > > + clock-frequency = <65000000>; > > + hactive = <1024>; > > + vactive = <768>; > > + hsync-len = <136>; > > + hfront-porch = <20>; > > + hback-porch = <160>; > > + vfront-porch = <3>; > > + vback-porch = <29>; > > + vsync-len = <6>; > > + }; > > + > > + port { > > + }; > > +}; -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 2/3] arm64: dts: renesas: Add panel overlay for Salvator-X(S) boards 2021-12-29 19:31 [PATCH v2 0/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support Laurent Pinchart 2021-12-29 19:31 ` [PATCH v2 1/3] " Laurent Pinchart @ 2021-12-29 19:31 ` Laurent Pinchart 2022-01-26 12:19 ` Geert Uytterhoeven 2022-02-21 14:40 ` Kieran Bingham 2021-12-29 19:31 ` [PATCH v2 3/3] arm64: dts: renesas: Add panel overlay for Draak and Ebisu boards Laurent Pinchart 2 siblings, 2 replies; 17+ messages in thread From: Laurent Pinchart @ 2021-12-29 19:31 UTC (permalink / raw) To: linux-renesas-soc Cc: devicetree, Rob Herring, Kieran Bingham, Geert Uytterhoeven, Magnus Damm, Chris Paterson The Salvator-X and Salvator-XS boards support an optional LVDS panel. One compatible panel is the Mitsubishi AA104XD12. Add a corresponding DT overlay. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- Changes since v1: - Create endpoint in lvds0 port@1 --- arch/arm64/boot/dts/renesas/Makefile | 2 ++ .../dts/renesas/salvator-panel-aa104xd12.dts | 36 +++++++++++++++++++ 2 files changed, 38 insertions(+) create mode 100644 arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dts diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile index d1c5c21d8d14..982ca3e0e86f 100644 --- a/arch/arm64/boot/dts/renesas/Makefile +++ b/arch/arm64/boot/dts/renesas/Makefile @@ -74,3 +74,5 @@ dtb-$(CONFIG_ARCH_R8A77961) += r8a779m3-ulcb-kf.dtb dtb-$(CONFIG_ARCH_R8A77965) += r8a779m5-salvator-xs.dtb dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc.dtb + +dtb-$(CONFIG_ARCH_RCAR_GEN3) += salvator-panel-aa104xd12.dtbo diff --git a/arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dts b/arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dts new file mode 100644 index 000000000000..c83a30adc6ad --- /dev/null +++ b/arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dts @@ -0,0 +1,36 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Device Tree overlay for the AA104XD12 panel connected to LVDS0 on a + * Salvator-X or Salvator-XS board + * + * Copyright 2021 Ideas on Board Oy + */ + +/dts-v1/; +/plugin/; + +&{/} { +#include "panel-aa104xd12.dtsi" +}; + +&{/panel} { + backlight = <&backlight>; + + port { + panel_in: endpoint { + remote-endpoint = <&lvds0_out>; + }; + }; +}; + +&lvds0 { + status = "okay"; + + ports { + port@1 { + lvds0_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + }; +}; -- Regards, Laurent Pinchart ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/3] arm64: dts: renesas: Add panel overlay for Salvator-X(S) boards 2021-12-29 19:31 ` [PATCH v2 2/3] arm64: dts: renesas: Add panel overlay for Salvator-X(S) boards Laurent Pinchart @ 2022-01-26 12:19 ` Geert Uytterhoeven 2022-02-21 14:40 ` Kieran Bingham 1 sibling, 0 replies; 17+ messages in thread From: Geert Uytterhoeven @ 2022-01-26 12:19 UTC (permalink / raw) To: Laurent Pinchart Cc: Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring, Kieran Bingham, Magnus Damm, Chris Paterson On Wed, Dec 29, 2021 at 8:31 PM Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > The Salvator-X and Salvator-XS boards support an optional LVDS panel. > One compatible panel is the Mitsubishi AA104XD12. Add a corresponding DT > overlay. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/3] arm64: dts: renesas: Add panel overlay for Salvator-X(S) boards 2021-12-29 19:31 ` [PATCH v2 2/3] arm64: dts: renesas: Add panel overlay for Salvator-X(S) boards Laurent Pinchart 2022-01-26 12:19 ` Geert Uytterhoeven @ 2022-02-21 14:40 ` Kieran Bingham 1 sibling, 0 replies; 17+ messages in thread From: Kieran Bingham @ 2022-02-21 14:40 UTC (permalink / raw) To: Laurent Pinchart, linux-renesas-soc Cc: devicetree, Rob Herring, Geert Uytterhoeven, Magnus Damm, Chris Paterson Quoting Laurent Pinchart (2021-12-29 19:31:34) > The Salvator-X and Salvator-XS boards support an optional LVDS panel. > One compatible panel is the Mitsubishi AA104XD12. Add a corresponding DT > overlay. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > Changes since v1: > > - Create endpoint in lvds0 port@1 > --- > arch/arm64/boot/dts/renesas/Makefile | 2 ++ > .../dts/renesas/salvator-panel-aa104xd12.dts | 36 +++++++++++++++++++ > 2 files changed, 38 insertions(+) > create mode 100644 arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dts > > diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile > index d1c5c21d8d14..982ca3e0e86f 100644 > --- a/arch/arm64/boot/dts/renesas/Makefile > +++ b/arch/arm64/boot/dts/renesas/Makefile > @@ -74,3 +74,5 @@ dtb-$(CONFIG_ARCH_R8A77961) += r8a779m3-ulcb-kf.dtb > dtb-$(CONFIG_ARCH_R8A77965) += r8a779m5-salvator-xs.dtb > > dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc.dtb > + > +dtb-$(CONFIG_ARCH_RCAR_GEN3) += salvator-panel-aa104xd12.dtbo > diff --git a/arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dts b/arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dts > new file mode 100644 > index 000000000000..c83a30adc6ad > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/salvator-panel-aa104xd12.dts > @@ -0,0 +1,36 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Device Tree overlay for the AA104XD12 panel connected to LVDS0 on a > + * Salvator-X or Salvator-XS board > + * > + * Copyright 2021 Ideas on Board Oy > + */ > + > +/dts-v1/; > +/plugin/; > + > +&{/} { > +#include "panel-aa104xd12.dtsi" I guess parameters would help reduce the redundancy of having to define per-board overlays, but this fits what we have got so: Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > +}; > + > +&{/panel} { > + backlight = <&backlight>; > + > + port { > + panel_in: endpoint { > + remote-endpoint = <&lvds0_out>; > + }; > + }; > +}; > + > +&lvds0 { > + status = "okay"; > + > + ports { > + port@1 { > + lvds0_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > +}; > -- > Regards, > > Laurent Pinchart > ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 3/3] arm64: dts: renesas: Add panel overlay for Draak and Ebisu boards 2021-12-29 19:31 [PATCH v2 0/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support Laurent Pinchart 2021-12-29 19:31 ` [PATCH v2 1/3] " Laurent Pinchart 2021-12-29 19:31 ` [PATCH v2 2/3] arm64: dts: renesas: Add panel overlay for Salvator-X(S) boards Laurent Pinchart @ 2021-12-29 19:31 ` Laurent Pinchart 2022-01-26 12:20 ` Geert Uytterhoeven 2022-02-21 14:41 ` Kieran Bingham 2 siblings, 2 replies; 17+ messages in thread From: Laurent Pinchart @ 2021-12-29 19:31 UTC (permalink / raw) To: linux-renesas-soc Cc: devicetree, Rob Herring, Kieran Bingham, Geert Uytterhoeven, Magnus Damm, Chris Paterson The Draak and Ebisu boards support an optional LVDS panel. One compatible panel is the Mitsubishi AA104XD12. Add a corresponding DT overlay. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- Changes since v1: - Create endpoint in lvds1 port@1 --- arch/arm64/boot/dts/renesas/Makefile | 1 + .../renesas/draak-ebisu-panel-aa104xd12.dts | 36 +++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dts diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile index 982ca3e0e86f..5e831bd33828 100644 --- a/arch/arm64/boot/dts/renesas/Makefile +++ b/arch/arm64/boot/dts/renesas/Makefile @@ -76,3 +76,4 @@ dtb-$(CONFIG_ARCH_R8A77965) += r8a779m5-salvator-xs.dtb dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc.dtb dtb-$(CONFIG_ARCH_RCAR_GEN3) += salvator-panel-aa104xd12.dtbo +dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-ebisu-panel-aa104xd12.dtbo diff --git a/arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dts b/arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dts new file mode 100644 index 000000000000..258f8668ca36 --- /dev/null +++ b/arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dts @@ -0,0 +1,36 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Device Tree overlay for the AA104XD12 panel connected to LVDS1 on a Draak or + * Ebisu board + * + * Copyright 2021 Ideas on Board Oy + */ + +/dts-v1/; +/plugin/; + +&{/} { +#include "panel-aa104xd12.dtsi" +}; + +&{/panel} { + backlight = <&backlight>; + + port { + panel_in: endpoint { + remote-endpoint = <&lvds1_out>; + }; + }; +}; + +&lvds1 { + status = "okay"; + + ports { + port@1 { + lvds1_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + }; +}; -- Regards, Laurent Pinchart ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: renesas: Add panel overlay for Draak and Ebisu boards 2021-12-29 19:31 ` [PATCH v2 3/3] arm64: dts: renesas: Add panel overlay for Draak and Ebisu boards Laurent Pinchart @ 2022-01-26 12:20 ` Geert Uytterhoeven 2022-02-21 14:41 ` Kieran Bingham 1 sibling, 0 replies; 17+ messages in thread From: Geert Uytterhoeven @ 2022-01-26 12:20 UTC (permalink / raw) To: Laurent Pinchart Cc: Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring, Kieran Bingham, Geert Uytterhoeven, Magnus Damm, Chris Paterson On Wed, Dec 29, 2021 at 8:31 PM Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > The Draak and Ebisu boards support an optional LVDS panel. One > compatible panel is the Mitsubishi AA104XD12. Add a corresponding DT > overlay. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: renesas: Add panel overlay for Draak and Ebisu boards 2021-12-29 19:31 ` [PATCH v2 3/3] arm64: dts: renesas: Add panel overlay for Draak and Ebisu boards Laurent Pinchart 2022-01-26 12:20 ` Geert Uytterhoeven @ 2022-02-21 14:41 ` Kieran Bingham 1 sibling, 0 replies; 17+ messages in thread From: Kieran Bingham @ 2022-02-21 14:41 UTC (permalink / raw) To: Laurent Pinchart, linux-renesas-soc Cc: devicetree, Rob Herring, Geert Uytterhoeven, Magnus Damm, Chris Paterson Quoting Laurent Pinchart (2021-12-29 19:31:35) > The Draak and Ebisu boards support an optional LVDS panel. One > compatible panel is the Mitsubishi AA104XD12. Add a corresponding DT > overlay. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > Changes since v1: > > - Create endpoint in lvds1 port@1 > --- > arch/arm64/boot/dts/renesas/Makefile | 1 + > .../renesas/draak-ebisu-panel-aa104xd12.dts | 36 +++++++++++++++++++ > 2 files changed, 37 insertions(+) > create mode 100644 arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dts > > diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile > index 982ca3e0e86f..5e831bd33828 100644 > --- a/arch/arm64/boot/dts/renesas/Makefile > +++ b/arch/arm64/boot/dts/renesas/Makefile > @@ -76,3 +76,4 @@ dtb-$(CONFIG_ARCH_R8A77965) += r8a779m5-salvator-xs.dtb > dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc.dtb > > dtb-$(CONFIG_ARCH_RCAR_GEN3) += salvator-panel-aa104xd12.dtbo > +dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-ebisu-panel-aa104xd12.dtbo > diff --git a/arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dts b/arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dts > new file mode 100644 > index 000000000000..258f8668ca36 > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dts > @@ -0,0 +1,36 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Device Tree overlay for the AA104XD12 panel connected to LVDS1 on a Draak or > + * Ebisu board > + * > + * Copyright 2021 Ideas on Board Oy > + */ > + > +/dts-v1/; > +/plugin/; > + > +&{/} { > +#include "panel-aa104xd12.dtsi" > +}; > + > +&{/panel} { > + backlight = <&backlight>; > + > + port { > + panel_in: endpoint { > + remote-endpoint = <&lvds1_out>; > + }; > + }; > +}; > + > +&lvds1 { > + status = "okay"; > + > + ports { > + port@1 { > + lvds1_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > +}; > -- > Regards, > > Laurent Pinchart > ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2022-07-07 8:13 UTC | newest] Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-12-29 19:31 [PATCH v2 0/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support Laurent Pinchart 2021-12-29 19:31 ` [PATCH v2 1/3] " Laurent Pinchart 2022-01-26 12:18 ` Geert Uytterhoeven 2022-01-26 18:58 ` Laurent Pinchart 2022-01-26 19:15 ` Geert Uytterhoeven 2022-01-26 23:57 ` Laurent Pinchart 2022-07-07 2:25 ` Laurent Pinchart 2022-07-07 7:30 ` Geert Uytterhoeven 2022-07-07 8:12 ` Laurent Pinchart 2022-02-21 14:38 ` Kieran Bingham 2022-02-21 14:42 ` Laurent Pinchart 2021-12-29 19:31 ` [PATCH v2 2/3] arm64: dts: renesas: Add panel overlay for Salvator-X(S) boards Laurent Pinchart 2022-01-26 12:19 ` Geert Uytterhoeven 2022-02-21 14:40 ` Kieran Bingham 2021-12-29 19:31 ` [PATCH v2 3/3] arm64: dts: renesas: Add panel overlay for Draak and Ebisu boards Laurent Pinchart 2022-01-26 12:20 ` Geert Uytterhoeven 2022-02-21 14:41 ` Kieran Bingham
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.