From: Ingo Molnar <mingo@kernel.org> To: Siddh Raman Pant <code@siddh.me> Cc: x86@kernel.org, Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>, linux-kernel <linux-kernel@vger.kernel.org>, linux-kernel-mentees <linux-kernel-mentees@lists.linuxfoundation.org> Subject: Re: [PATCH] x86/numa: Use cpumask_available instead of hardcoded NULL check Date: Tue, 2 Aug 2022 13:07:44 +0200 [thread overview] Message-ID: <YukFgFTaq4Aw+uht@gmail.com> (raw) In-Reply-To: <20220731160913.632092-1-code@siddh.me> * Siddh Raman Pant <code@siddh.me> wrote: > GCC warning log: > =========================================================================== > > arch/x86/mm/numa.c: In function ‘cpumask_of_node’: > arch/x86/mm/numa.c:916:39: warning: the comparison will always evaluate as ‘false’ for the address of ‘node_to_cpumask_map’ will never be NULL [-Waddress] > 916 | if (node_to_cpumask_map[node] == NULL) { > | ^~ Your fix makes sense I suppose, but I'm wondering how testing didn't trigger this warning. Off-stack isn't a rare config option: kepler:~/tip> make allmodconfig # # No change to .config # kepler:~/tip> grep CPUMASK_OFFSTACK .config CONFIG_CPUMASK_OFFSTACK=y kepler:~/tip> What am I missing? > Fixes: c032ef60d1aa ("cpumask: convert node_to_cpumask_map[] to cpumask_var_t") > Fixes: de2d9445f162 ("x86: Unify node_to_cpumask_map handling between 32 and 64bit") These are ancient commits from 2009 & 2011. Thanks, Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org> To: Siddh Raman Pant <code@siddh.me> Cc: Dave Hansen <dave.hansen@linux.intel.com>, Peter Zijlstra <peterz@infradead.org>, x86@kernel.org, linux-kernel <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>, linux-kernel-mentees <linux-kernel-mentees@lists.linuxfoundation.org> Subject: Re: [PATCH] x86/numa: Use cpumask_available instead of hardcoded NULL check Date: Tue, 2 Aug 2022 13:07:44 +0200 [thread overview] Message-ID: <YukFgFTaq4Aw+uht@gmail.com> (raw) In-Reply-To: <20220731160913.632092-1-code@siddh.me> * Siddh Raman Pant <code@siddh.me> wrote: > GCC warning log: > =========================================================================== > > arch/x86/mm/numa.c: In function ‘cpumask_of_node’: > arch/x86/mm/numa.c:916:39: warning: the comparison will always evaluate as ‘false’ for the address of ‘node_to_cpumask_map’ will never be NULL [-Waddress] > 916 | if (node_to_cpumask_map[node] == NULL) { > | ^~ Your fix makes sense I suppose, but I'm wondering how testing didn't trigger this warning. Off-stack isn't a rare config option: kepler:~/tip> make allmodconfig # # No change to .config # kepler:~/tip> grep CPUMASK_OFFSTACK .config CONFIG_CPUMASK_OFFSTACK=y kepler:~/tip> What am I missing? > Fixes: c032ef60d1aa ("cpumask: convert node_to_cpumask_map[] to cpumask_var_t") > Fixes: de2d9445f162 ("x86: Unify node_to_cpumask_map handling between 32 and 64bit") These are ancient commits from 2009 & 2011. Thanks, Ingo _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2022-08-02 11:07 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-31 16:09 [PATCH] x86/numa: Use cpumask_available instead of hardcoded NULL check Siddh Raman Pant via Linux-kernel-mentees 2022-07-31 16:09 ` Siddh Raman Pant 2022-08-02 11:07 ` Ingo Molnar [this message] 2022-08-02 11:07 ` Ingo Molnar 2022-08-02 16:29 ` Siddh Raman Pant via Linux-kernel-mentees 2022-08-02 16:29 ` Siddh Raman Pant 2022-08-03 8:48 ` Ingo Molnar 2022-08-03 8:48 ` Ingo Molnar 2022-08-03 8:58 ` Siddh Raman Pant via Linux-kernel-mentees 2022-08-03 8:58 ` Siddh Raman Pant 2022-08-03 9:08 ` Ingo Molnar 2022-08-03 9:08 ` Ingo Molnar 2022-08-03 9:21 ` Siddh Raman Pant 2022-08-03 9:21 ` Siddh Raman Pant via Linux-kernel-mentees 2022-08-03 9:42 ` Ingo Molnar 2022-08-03 9:42 ` Ingo Molnar 2022-08-03 9:46 ` Siddh Raman Pant via Linux-kernel-mentees 2022-08-03 9:46 ` Siddh Raman Pant 2022-08-03 15:41 ` [tip: x86/urgent] " tip-bot2 for Siddh Raman Pant
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YukFgFTaq4Aw+uht@gmail.com \ --to=mingo@kernel.org \ --cc=bp@alien8.de \ --cc=code@siddh.me \ --cc=dave.hansen@linux.intel.com \ --cc=hpa@zytor.com \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.