From: Nathan Chancellor <nathan@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Sudip Mukherjee (Codethink)" <sudipm.mukherjee@gmail.com>,
clang-built-linux <llvm@lists.linux.dev>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: mainline build failure for x86_64 allmodconfig with clang
Date: Thu, 4 Aug 2022 15:43:48 -0700 [thread overview]
Message-ID: <YuxLpHndYb0ZEWQI@dev-arch.thelio-3990X> (raw)
In-Reply-To: <CAHk-=whpa_FJjvzWdWdSzecTbVtndbQqg35=_o+ohM3X1_xKTA@mail.gmail.com>
On Thu, Aug 04, 2022 at 02:59:01PM -0700, Linus Torvalds wrote:
> On Thu, Aug 4, 2022 at 1:43 PM Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > I do note that commit 1b54a0121dba ("drm/amd/display: Reduce stack size
> > in the mode support function") did have a workaround for GCC. It appears
> > clang will still inline mode_support_configuration(). If I mark it as
> > 'noinline', the warning disappears in that file.
>
> That sounds like probably the best option for now. Gcc does not inline
> that function (at least for allmodconfig builds in my testing), so if
> that makes clang match what gcc does, it seems a reasonable thing to
> do.
Sounds good. That solution only takes care of the warning in
display_mode_vba_32.c. I will try and come up with something similar for
the other two files tomorrow, unless the AMD folks beat me to it, since
they will know the driver better than I will ;)
Cheers,
Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@linux.ie>,
clang-built-linux <llvm@lists.linux.dev>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Christian König" <christian.koenig@amd.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Sudip Mukherjee (Codethink)" <sudipm.mukherjee@gmail.com>
Subject: Re: mainline build failure for x86_64 allmodconfig with clang
Date: Thu, 4 Aug 2022 15:43:48 -0700 [thread overview]
Message-ID: <YuxLpHndYb0ZEWQI@dev-arch.thelio-3990X> (raw)
In-Reply-To: <CAHk-=whpa_FJjvzWdWdSzecTbVtndbQqg35=_o+ohM3X1_xKTA@mail.gmail.com>
On Thu, Aug 04, 2022 at 02:59:01PM -0700, Linus Torvalds wrote:
> On Thu, Aug 4, 2022 at 1:43 PM Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > I do note that commit 1b54a0121dba ("drm/amd/display: Reduce stack size
> > in the mode support function") did have a workaround for GCC. It appears
> > clang will still inline mode_support_configuration(). If I mark it as
> > 'noinline', the warning disappears in that file.
>
> That sounds like probably the best option for now. Gcc does not inline
> that function (at least for allmodconfig builds in my testing), so if
> that makes clang match what gcc does, it seems a reasonable thing to
> do.
Sounds good. That solution only takes care of the warning in
display_mode_vba_32.c. I will try and come up with something similar for
the other two files tomorrow, unless the AMD folks beat me to it, since
they will know the driver better than I will ;)
Cheers,
Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@linux.ie>,
clang-built-linux <llvm@lists.linux.dev>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Christian König" <christian.koenig@amd.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Sudip Mukherjee (Codethink)" <sudipm.mukherjee@gmail.com>
Subject: Re: mainline build failure for x86_64 allmodconfig with clang
Date: Thu, 4 Aug 2022 15:43:48 -0700 [thread overview]
Message-ID: <YuxLpHndYb0ZEWQI@dev-arch.thelio-3990X> (raw)
In-Reply-To: <CAHk-=whpa_FJjvzWdWdSzecTbVtndbQqg35=_o+ohM3X1_xKTA@mail.gmail.com>
On Thu, Aug 04, 2022 at 02:59:01PM -0700, Linus Torvalds wrote:
> On Thu, Aug 4, 2022 at 1:43 PM Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > I do note that commit 1b54a0121dba ("drm/amd/display: Reduce stack size
> > in the mode support function") did have a workaround for GCC. It appears
> > clang will still inline mode_support_configuration(). If I mark it as
> > 'noinline', the warning disappears in that file.
>
> That sounds like probably the best option for now. Gcc does not inline
> that function (at least for allmodconfig builds in my testing), so if
> that makes clang match what gcc does, it seems a reasonable thing to
> do.
Sounds good. That solution only takes care of the warning in
display_mode_vba_32.c. I will try and come up with something similar for
the other two files tomorrow, unless the AMD folks beat me to it, since
they will know the driver better than I will ;)
Cheers,
Nathan
next prev parent reply other threads:[~2022-08-04 22:43 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 18:36 mainline build failure for x86_64 allmodconfig with clang Sudip Mukherjee (Codethink)
2022-08-04 18:36 ` Sudip Mukherjee (Codethink)
2022-08-04 18:36 ` Sudip Mukherjee (Codethink)
2022-08-04 18:52 ` Linus Torvalds
2022-08-04 18:52 ` Linus Torvalds
2022-08-04 18:52 ` Linus Torvalds
2022-08-04 19:24 ` Arnd Bergmann
2022-08-04 19:24 ` Arnd Bergmann
2022-08-04 19:24 ` Arnd Bergmann
2022-08-04 20:43 ` Nathan Chancellor
2022-08-04 20:43 ` Nathan Chancellor
2022-08-04 20:43 ` Nathan Chancellor
2022-08-04 21:59 ` Linus Torvalds
2022-08-04 21:59 ` Linus Torvalds
2022-08-04 21:59 ` Linus Torvalds
2022-08-04 22:43 ` Nathan Chancellor [this message]
2022-08-04 22:43 ` Nathan Chancellor
2022-08-04 22:43 ` Nathan Chancellor
2022-08-05 9:46 ` David Laight
2022-08-05 9:46 ` David Laight
2022-08-05 9:46 ` David Laight
2022-08-05 15:32 ` Harry Wentland
2022-08-05 15:32 ` Harry Wentland
2022-08-05 16:16 ` Arnd Bergmann
2022-08-05 16:16 ` Arnd Bergmann
2022-08-05 18:02 ` Nathan Chancellor
2022-08-05 18:02 ` Nathan Chancellor
2022-08-05 18:02 ` Nathan Chancellor
2022-08-05 19:32 ` Arnd Bergmann
2022-08-05 19:32 ` Arnd Bergmann
2022-08-05 19:32 ` Arnd Bergmann
2022-08-07 17:36 ` David Laight
2022-08-07 17:36 ` David Laight
2022-08-07 17:36 ` David Laight
2022-08-07 17:55 ` Linus Torvalds
2022-08-07 17:55 ` Linus Torvalds
2022-08-07 17:55 ` Linus Torvalds
2022-08-18 15:59 ` Nathan Chancellor
2022-08-18 15:59 ` Nathan Chancellor
2022-08-25 22:34 ` Nathan Chancellor
2022-08-25 22:34 ` Nathan Chancellor
2022-08-26 14:31 ` Alex Deucher
2022-08-26 14:31 ` Alex Deucher
2022-08-26 14:31 ` Alex Deucher
2022-08-30 20:38 ` Nathan Chancellor
2022-08-30 20:38 ` Nathan Chancellor
2022-08-30 20:38 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuxLpHndYb0ZEWQI@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=arnd@kernel.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.