All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Arnd Bergmann' <arnd@kernel.org>, Nathan Chancellor <nathan@kernel.org>
Cc: "Harry Wentland" <harry.wentland@amd.com>,
	"Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
	clang-built-linux <llvm@lists.linux.dev>,
	"David Airlie" <airlied@linux.ie>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Christian König" <christian.koenig@amd.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Sudip Mukherjee (Codethink)" <sudipm.mukherjee@gmail.com>
Subject: RE: mainline build failure for x86_64 allmodconfig with clang
Date: Sun, 7 Aug 2022 17:36:48 +0000	[thread overview]
Message-ID: <cb3ea155c4e149eca30ca870e3f2546d@AcuMS.aculab.com> (raw)
In-Reply-To: <CAK8P3a3PAxkctN6AXOsoTBTFgwHhk7_OSYwJ4Rgk7Dbs+bc0Qw@mail.gmail.com>

From: Arnd Bergmann
> Sent: 05 August 2022 20:32
...
> One thing to try would be to condense a function call like
> 
>                 dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport(
> 
...
>                         .... /* more arguments */);
> 
> into calling conventions that take a pointer to 'mode_lib->vba' and another
> one to 'v', so these are no longer passed on the stack individually.

Or, if it is only called once (I can't find the source)
force it to be inlined.

Or just shoot the software engineer who thinks 100 arguments
is sane. :-)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM>
To: 'Arnd Bergmann' <arnd@kernel.org>, Nathan Chancellor <nathan@kernel.org>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	clang-built-linux <llvm@lists.linux.dev>,
	"Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Sudip Mukherjee (Codethink)" <sudipm.mukherjee@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: RE: mainline build failure for x86_64 allmodconfig with clang
Date: Sun, 7 Aug 2022 17:36:48 +0000	[thread overview]
Message-ID: <cb3ea155c4e149eca30ca870e3f2546d@AcuMS.aculab.com> (raw)
In-Reply-To: <CAK8P3a3PAxkctN6AXOsoTBTFgwHhk7_OSYwJ4Rgk7Dbs+bc0Qw@mail.gmail.com>

From: Arnd Bergmann
> Sent: 05 August 2022 20:32
...
> One thing to try would be to condense a function call like
> 
>                 dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport(
> 
...
>                         .... /* more arguments */);
> 
> into calling conventions that take a pointer to 'mode_lib->vba' and another
> one to 'v', so these are no longer passed on the stack individually.

Or, if it is only called once (I can't find the source)
force it to be inlined.

Or just shoot the software engineer who thinks 100 arguments
is sane. :-)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM>
To: 'Arnd Bergmann' <arnd@kernel.org>, Nathan Chancellor <nathan@kernel.org>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	clang-built-linux <llvm@lists.linux.dev>,
	"Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Sudip Mukherjee (Codethink)" <sudipm.mukherjee@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: RE: mainline build failure for x86_64 allmodconfig with clang
Date: Sun, 7 Aug 2022 17:36:48 +0000	[thread overview]
Message-ID: <cb3ea155c4e149eca30ca870e3f2546d@AcuMS.aculab.com> (raw)
In-Reply-To: <CAK8P3a3PAxkctN6AXOsoTBTFgwHhk7_OSYwJ4Rgk7Dbs+bc0Qw@mail.gmail.com>

From: Arnd Bergmann
> Sent: 05 August 2022 20:32
...
> One thing to try would be to condense a function call like
> 
>                 dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport(
> 
...
>                         .... /* more arguments */);
> 
> into calling conventions that take a pointer to 'mode_lib->vba' and another
> one to 'v', so these are no longer passed on the stack individually.

Or, if it is only called once (I can't find the source)
force it to be inlined.

Or just shoot the software engineer who thinks 100 arguments
is sane. :-)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

  reply	other threads:[~2022-08-07 17:36 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 18:36 mainline build failure for x86_64 allmodconfig with clang Sudip Mukherjee (Codethink)
2022-08-04 18:36 ` Sudip Mukherjee (Codethink)
2022-08-04 18:36 ` Sudip Mukherjee (Codethink)
2022-08-04 18:52 ` Linus Torvalds
2022-08-04 18:52   ` Linus Torvalds
2022-08-04 18:52   ` Linus Torvalds
2022-08-04 19:24   ` Arnd Bergmann
2022-08-04 19:24     ` Arnd Bergmann
2022-08-04 19:24     ` Arnd Bergmann
2022-08-04 20:43     ` Nathan Chancellor
2022-08-04 20:43       ` Nathan Chancellor
2022-08-04 20:43       ` Nathan Chancellor
2022-08-04 21:59       ` Linus Torvalds
2022-08-04 21:59         ` Linus Torvalds
2022-08-04 21:59         ` Linus Torvalds
2022-08-04 22:43         ` Nathan Chancellor
2022-08-04 22:43           ` Nathan Chancellor
2022-08-04 22:43           ` Nathan Chancellor
2022-08-05  9:46       ` David Laight
2022-08-05  9:46         ` David Laight
2022-08-05  9:46         ` David Laight
2022-08-05 15:32       ` Harry Wentland
2022-08-05 15:32         ` Harry Wentland
2022-08-05 16:16         ` Arnd Bergmann
2022-08-05 16:16           ` Arnd Bergmann
2022-08-05 18:02           ` Nathan Chancellor
2022-08-05 18:02             ` Nathan Chancellor
2022-08-05 18:02             ` Nathan Chancellor
2022-08-05 19:32             ` Arnd Bergmann
2022-08-05 19:32               ` Arnd Bergmann
2022-08-05 19:32               ` Arnd Bergmann
2022-08-07 17:36               ` David Laight [this message]
2022-08-07 17:36                 ` David Laight
2022-08-07 17:36                 ` David Laight
2022-08-07 17:55                 ` Linus Torvalds
2022-08-07 17:55                   ` Linus Torvalds
2022-08-07 17:55                   ` Linus Torvalds
2022-08-18 15:59               ` Nathan Chancellor
2022-08-18 15:59                 ` Nathan Chancellor
2022-08-25 22:34                 ` Nathan Chancellor
2022-08-25 22:34                   ` Nathan Chancellor
2022-08-26 14:31                   ` Alex Deucher
2022-08-26 14:31                     ` Alex Deucher
2022-08-26 14:31                     ` Alex Deucher
2022-08-30 20:38                     ` Nathan Chancellor
2022-08-30 20:38                       ` Nathan Chancellor
2022-08-30 20:38                       ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb3ea155c4e149eca30ca870e3f2546d@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=arnd@kernel.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.