All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off
@ 2024-03-06  3:13 gareth.yu
  2024-03-06  8:32 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (17 more replies)
  0 siblings, 18 replies; 25+ messages in thread
From: gareth.yu @ 2024-03-06  3:13 UTC (permalink / raw)
  To: intel-gfx; +Cc: Gareth Yu

From: Gareth Yu <gareth.yu@intel.com>

Turn on the panel from zero brightness of the last state, the panel was set
a maximum PWM in the flow. Once the panel initialization is completed, the
backlight is restored to zero brightness. There is a flckering generated.

Set the brightness to the minimum value when the brightness is less or equal
to the minimum value to fix this flickering

Cc : Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Cc : Matt Roper <matthew.d.roper@intel.com>
Cc : Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Gareth Yu <gareth.yu@intel.com>
---
 drivers/gpu/drm/i915/display/intel_backlight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c
index 3f3cd944a1c5..855d6ead905c 100644
--- a/drivers/gpu/drm/i915/display/intel_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_backlight.c
@@ -762,7 +762,7 @@ static void __intel_backlight_enable(const struct intel_crtc_state *crtc_state,
 	WARN_ON(panel->backlight.max == 0);
 
 	if (panel->backlight.level <= panel->backlight.min) {
-		panel->backlight.level = panel->backlight.max;
+		panel->backlight.level = panel->backlight.min;
 		if (panel->backlight.device)
 			panel->backlight.device->props.brightness =
 				scale_hw_to_user(connector,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2024-03-26 13:11 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-06  3:13 [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off gareth.yu
2024-03-06  8:32 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-03-06  8:48 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-06 10:19 ` [PATCH] " Jani Nikula
2024-03-15 11:02   ` Ville Syrjälä
2024-03-18  2:20     ` Yu, Gareth
2024-03-18  7:58     ` Dolan Liu
2024-03-18 13:45       ` Jani Nikula
2024-03-19  2:04         ` Yu, Gareth
2024-03-12  3:17 ` gareth.yu
2024-03-12  4:14 ` ✗ Fi.CI.BAT: failure for drm/i915/display: Fixed a screen flickering when turning on display from off (rev2) Patchwork
2024-03-14  4:20 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed a screen flickering when turning on display from off (rev3) Patchwork
2024-03-14 14:47 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-15 10:01 ` [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off gareth.yu
2024-03-15 12:34 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed a screen flickering when turning on display from off (rev4) Patchwork
2024-03-16 14:19 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-18  2:15 ` [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off gareth.yu
2024-03-18  2:50 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed a screen flickering when turning on display from off (rev5) Patchwork
2024-03-18  4:37 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-20 16:27 ` ✓ Fi.CI.IGT: success " Patchwork
2024-03-20 16:56 ` Patchwork
2024-03-21  4:53 ` [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off gareth.yu
2024-03-26 13:11   ` Jani Nikula
2024-03-21  5:30 ` ✓ Fi.CI.BAT: success for drm/i915/display: Fixed a screen flickering when turning on display from off (rev6) Patchwork
2024-03-22  1:24 ` ✗ Fi.CI.IGT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.