From: Daniel Golle <daniel@makrotopia.org> To: arinc.unal@arinc9.com Cc: "DENG Qingfang" <dqfext@gmail.com>, "Sean Wang" <sean.wang@mediatek.com>, "Andrew Lunn" <andrew@lunn.ch>, "Florian Fainelli" <f.fainelli@gmail.com>, "Vladimir Oltean" <olteanv@gmail.com>, "David S. Miller" <davem@davemloft.net>, "Eric Dumazet" <edumazet@google.com>, "Jakub Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "René van Dorst" <opensource@vdorst.com>, "Russell King" <linux@armlinux.org.uk>, "SkyLake Huang" <SkyLake.Huang@mediatek.com>, "Heiner Kallweit" <hkallweit1@gmail.com>, "Bartel Eerdekens" <bartel.eerdekens@constell8.be>, mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Date: Tue, 19 Mar 2024 18:25:22 +0000 [thread overview] Message-ID: <ZfnYkuzuvwLepIfC@makrotopia.org> (raw) In-Reply-To: <=?utf-8?q?=3C20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v?=> On Mon, Mar 18, 2024 at 10:46:22AM +0300, Arınç ÜNAL via B4 Relay wrote: > Hi. > > This patch series fixes EEE support for MT7531 and the switch on the MT7988 > SoC. EEE did not work on MT7531 on most boards before this, it is unclear > what's the status on MT7988 SoC switch as I don't have the hardware. EEE seems to already work just fine on the MT7988 built-in switch, at least on the BPI-R4. I don't think the SoC has bootstrap pins related to EEE like stand-alone MT753x may have. root@bpi-r4:~# ethtool --show-eee lan1 EEE settings for lan1: EEE status: disabled Tx LPI: 30 (us) Supported EEE link modes: 100baseT/Full 1000baseT/Full Advertised EEE link modes: Not reported Link partner advertised EEE link modes: 100baseT/Full 1000baseT/Full root@bpi-r4:~# ethtool --set-eee lan1 eee on root@bpi-r4:~# ethtool --show-eee lan1 EEE settings for lan1: EEE status: enabled - inactive Tx LPI: 30 (us) Supported EEE link modes: 100baseT/Full 1000baseT/Full Advertised EEE link modes: 100baseT/Full 1000baseT/Full Link partner advertised EEE link modes: Not reported root@bpi-r4:~# ethtool --show-eee lan1 EEE settings for lan1: EEE status: enabled - active Tx LPI: 30 (us) Supported EEE link modes: 100baseT/Full 1000baseT/Full Advertised EEE link modes: 100baseT/Full 1000baseT/Full Link partner advertised EEE link modes: 100baseT/Full 1000baseT/Full So don't fix if it ain't broken maybe...? > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > Arınç ÜNAL (3): > net: dsa: mt7530: fix enabling EEE on MT7531 switch on all boards > net: dsa: mt7530: fix disabling EEE on failure on MT7531 and MT7988 > net: phy: mediatek-ge: do not disable EEE advertisement > > drivers/net/dsa/mt7530.c | 7 +++++++ > drivers/net/dsa/mt7530.h | 7 ++++++- > drivers/net/phy/mediatek-ge.c | 3 --- > 3 files changed, 13 insertions(+), 4 deletions(-) > --- > base-commit: ea80e3ed09ab2c2b75724faf5484721753e92c31 > change-id: 20240317-for-net-mt7530-fix-eee-for-mt7531-mt7988-a5c5453cc0e8 > > Best regards, > -- > Arınç ÜNAL <arinc.unal@arinc9.com> > >
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org> To: arinc.unal@arinc9.com Cc: "DENG Qingfang" <dqfext@gmail.com>, "Sean Wang" <sean.wang@mediatek.com>, "Andrew Lunn" <andrew@lunn.ch>, "Florian Fainelli" <f.fainelli@gmail.com>, "Vladimir Oltean" <olteanv@gmail.com>, "David S. Miller" <davem@davemloft.net>, "Eric Dumazet" <edumazet@google.com>, "Jakub Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "René van Dorst" <opensource@vdorst.com>, "Russell King" <linux@armlinux.org.uk>, "SkyLake Huang" <SkyLake.Huang@mediatek.com>, "Heiner Kallweit" <hkallweit1@gmail.com>, "Bartel Eerdekens" <bartel.eerdekens@constell8.be>, mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Date: Tue, 19 Mar 2024 18:25:22 +0000 [thread overview] Message-ID: <ZfnYkuzuvwLepIfC@makrotopia.org> (raw) In-Reply-To: <=?utf-8?q?=3C20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v?=> On Mon, Mar 18, 2024 at 10:46:22AM +0300, Arınç ÜNAL via B4 Relay wrote: > Hi. > > This patch series fixes EEE support for MT7531 and the switch on the MT7988 > SoC. EEE did not work on MT7531 on most boards before this, it is unclear > what's the status on MT7988 SoC switch as I don't have the hardware. EEE seems to already work just fine on the MT7988 built-in switch, at least on the BPI-R4. I don't think the SoC has bootstrap pins related to EEE like stand-alone MT753x may have. root@bpi-r4:~# ethtool --show-eee lan1 EEE settings for lan1: EEE status: disabled Tx LPI: 30 (us) Supported EEE link modes: 100baseT/Full 1000baseT/Full Advertised EEE link modes: Not reported Link partner advertised EEE link modes: 100baseT/Full 1000baseT/Full root@bpi-r4:~# ethtool --set-eee lan1 eee on root@bpi-r4:~# ethtool --show-eee lan1 EEE settings for lan1: EEE status: enabled - inactive Tx LPI: 30 (us) Supported EEE link modes: 100baseT/Full 1000baseT/Full Advertised EEE link modes: 100baseT/Full 1000baseT/Full Link partner advertised EEE link modes: Not reported root@bpi-r4:~# ethtool --show-eee lan1 EEE settings for lan1: EEE status: enabled - active Tx LPI: 30 (us) Supported EEE link modes: 100baseT/Full 1000baseT/Full Advertised EEE link modes: 100baseT/Full 1000baseT/Full Link partner advertised EEE link modes: 100baseT/Full 1000baseT/Full So don't fix if it ain't broken maybe...? > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > Arınç ÜNAL (3): > net: dsa: mt7530: fix enabling EEE on MT7531 switch on all boards > net: dsa: mt7530: fix disabling EEE on failure on MT7531 and MT7988 > net: phy: mediatek-ge: do not disable EEE advertisement > > drivers/net/dsa/mt7530.c | 7 +++++++ > drivers/net/dsa/mt7530.h | 7 ++++++- > drivers/net/phy/mediatek-ge.c | 3 --- > 3 files changed, 13 insertions(+), 4 deletions(-) > --- > base-commit: ea80e3ed09ab2c2b75724faf5484721753e92c31 > change-id: 20240317-for-net-mt7530-fix-eee-for-mt7531-mt7988-a5c5453cc0e8 > > Best regards, > -- > Arınç ÜNAL <arinc.unal@arinc9.com> > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2024-03-19 18:25 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <=?utf-8?q?=3C20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v?=> 2024-03-19 18:25 ` Daniel Golle [this message] 2024-03-19 18:25 ` [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Daniel Golle 2024-03-19 18:46 ` Arınç ÜNAL 2024-03-19 19:38 ` Andrew Lunn 2024-03-19 19:38 ` Andrew Lunn 2024-03-19 20:04 ` Arınç ÜNAL 2024-03-19 20:26 ` Daniel Golle 2024-03-19 20:26 ` Daniel Golle 2024-03-19 21:16 ` Arınç ÜNAL 2024-03-19 21:31 ` Florian Fainelli 2024-03-19 21:31 ` Florian Fainelli 2024-03-21 16:09 ` Arınç ÜNAL 2024-03-21 16:31 ` Florian Fainelli 2024-03-21 16:31 ` Florian Fainelli 2024-03-24 9:47 ` Arınç ÜNAL 2024-03-24 11:39 ` Russell King (Oracle) 2024-03-24 11:39 ` Russell King (Oracle) 2024-03-24 11:45 ` Arınç ÜNAL [not found] <65f7f17d.050a0220.3c75a.cde3SMTPIN_ADDED_BROKEN@mx.google.com> 2024-03-18 12:57 ` Florian Fainelli 2024-03-18 12:57 ` Florian Fainelli 2024-03-18 14:03 ` Arınç ÜNAL 2024-03-18 18:01 ` Konstantin Ryabitsev 2024-03-18 18:01 ` Konstantin Ryabitsev 2024-03-19 16:03 ` Konstantin Ryabitsev 2024-03-19 16:03 ` Konstantin Ryabitsev 2024-03-19 18:31 ` Arınç ÜNAL 2024-03-18 7:46 Arınç ÜNAL via B4 Relay 2024-03-18 7:46 ` Arınç ÜNAL via B4 Relay -- strict thread matches above, loose matches on Subject: below -- 2024-03-18 7:46 Arınç ÜNAL 2024-03-20 8:10 ` Arınç ÜNAL 2024-03-20 11:08 ` Daniel Golle 2024-03-20 11:08 ` Daniel Golle 2024-03-20 15:03 ` Arınç ÜNAL
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZfnYkuzuvwLepIfC@makrotopia.org \ --to=daniel@makrotopia.org \ --cc=SkyLake.Huang@mediatek.com \ --cc=andrew@lunn.ch \ --cc=angelogioacchino.delregno@collabora.com \ --cc=arinc.unal@arinc9.com \ --cc=bartel.eerdekens@constell8.be \ --cc=davem@davemloft.net \ --cc=dqfext@gmail.com \ --cc=edumazet@google.com \ --cc=erkin.bozoglu@xeront.com \ --cc=f.fainelli@gmail.com \ --cc=hkallweit1@gmail.com \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux@armlinux.org.uk \ --cc=matthias.bgg@gmail.com \ --cc=mithat.guner@xeront.com \ --cc=netdev@vger.kernel.org \ --cc=olteanv@gmail.com \ --cc=opensource@vdorst.com \ --cc=pabeni@redhat.com \ --cc=sean.wang@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.