From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Mark Rutland <mark.rutland@arm.com>, Andrei Vagin <avagin@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Dmitry Safonov <dima@arista.com>
Subject: Re: [PATCH v2 3/6] arm64/vdso: Add time napespace page
Date: Wed, 15 Apr 2020 11:16:00 +0100 [thread overview]
Message-ID: <a0179a69-fc1b-9e81-f3f2-72f6c639f40e@arm.com> (raw)
In-Reply-To: <20200415100539.GA27339@C02TD0UTHF1T.local>
Hi Mark,
On 4/15/20 11:05 AM, Mark Rutland wrote:
> It's a shame we're not using OPTIMIZER_HIDE_VAR() for that, as it can
> generate slightly better code and is easier to read than bare asm.
We are not because I was not aware when I wrote this code that such a macro
existed :)
But you are right it clearly makes the code more readable. To make up for it, I
am happy to make the effort to introduce it for both the cases and replace the
assembler once this patch series gets merged.
--
Regards,
Vincenzo
WARNING: multiple messages have this Message-ID (diff)
From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Mark Rutland <mark.rutland@arm.com>, Andrei Vagin <avagin@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
Dmitry Safonov <dima@arista.com>
Subject: Re: [PATCH v2 3/6] arm64/vdso: Add time napespace page
Date: Wed, 15 Apr 2020 11:16:00 +0100 [thread overview]
Message-ID: <a0179a69-fc1b-9e81-f3f2-72f6c639f40e@arm.com> (raw)
In-Reply-To: <20200415100539.GA27339@C02TD0UTHF1T.local>
Hi Mark,
On 4/15/20 11:05 AM, Mark Rutland wrote:
> It's a shame we're not using OPTIMIZER_HIDE_VAR() for that, as it can
> generate slightly better code and is easier to read than bare asm.
We are not because I was not aware when I wrote this code that such a macro
existed :)
But you are right it clearly makes the code more readable. To make up for it, I
am happy to make the effort to introduce it for both the cases and replace the
assembler once this patch series gets merged.
--
Regards,
Vincenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-15 10:47 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 7:37 [PATCH v2 0/6] arm64: add the time namespace support Andrei Vagin
2020-02-25 7:37 ` Andrei Vagin
2020-02-25 7:37 ` [PATCH v2 1/6] arm64/vdso: use the fault callback to map vvar pages Andrei Vagin
2020-02-25 7:37 ` Andrei Vagin
2020-04-09 12:01 ` Vincenzo Frascino
2020-04-09 12:01 ` Vincenzo Frascino
2020-02-25 7:37 ` [PATCH v2 2/6] arm64/vdso: Zap vvar pages when switching to a time namespace Andrei Vagin
2020-02-25 7:37 ` Andrei Vagin
2020-04-09 12:01 ` Vincenzo Frascino
2020-04-09 12:01 ` Vincenzo Frascino
2020-02-25 7:37 ` [PATCH v2 3/6] arm64/vdso: Add time napespace page Andrei Vagin
2020-02-25 7:37 ` Andrei Vagin
2020-04-09 12:03 ` Vincenzo Frascino
2020-04-09 12:03 ` Vincenzo Frascino
2020-04-14 17:20 ` Mark Rutland
2020-04-14 17:20 ` Mark Rutland
2020-04-15 2:34 ` Andrei Vagin
2020-04-15 2:34 ` Andrei Vagin
2020-04-15 10:05 ` Mark Rutland
2020-04-15 10:05 ` Mark Rutland
2020-04-15 10:16 ` Vincenzo Frascino [this message]
2020-04-15 10:16 ` Vincenzo Frascino
2020-04-15 12:27 ` Mark Rutland
2020-04-15 12:27 ` Mark Rutland
2020-02-25 7:37 ` [PATCH v2 4/6] arm64/vdso: Handle faults on timens page Andrei Vagin
2020-02-25 7:37 ` Andrei Vagin
2020-04-09 12:04 ` Vincenzo Frascino
2020-04-09 12:04 ` Vincenzo Frascino
2020-02-25 7:37 ` [PATCH v2 5/6] arm64/vdso: Restrict splitting VVAR VMA Andrei Vagin
2020-02-25 7:37 ` Andrei Vagin
2020-04-09 12:05 ` Vincenzo Frascino
2020-04-09 12:05 ` Vincenzo Frascino
2020-02-25 7:37 ` [PATCH v2 6/6] arm64: enable time namespace support Andrei Vagin
2020-02-25 7:37 ` Andrei Vagin
2020-04-09 12:06 ` Vincenzo Frascino
2020-04-09 12:06 ` Vincenzo Frascino
2020-04-01 6:50 ` [PATCH v2 0/6] arm64: add the " Andrei Vagin
2020-04-01 6:50 ` Andrei Vagin
2020-04-01 9:02 ` Vincenzo Frascino
2020-04-01 9:02 ` Vincenzo Frascino
2020-04-09 13:24 ` Vincenzo Frascino
2020-04-09 13:24 ` Vincenzo Frascino
2020-04-11 7:33 ` Andrei Vagin
2020-04-11 7:33 ` Andrei Vagin
2020-04-14 9:02 ` Vincenzo Frascino
2020-04-14 9:02 ` Vincenzo Frascino
2020-04-15 16:14 ` Andrei Vagin
2020-04-15 16:14 ` Andrei Vagin
2020-04-15 16:35 ` Vincenzo Frascino
2020-04-15 16:35 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0179a69-fc1b-9e81-f3f2-72f6c639f40e@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=avagin@gmail.com \
--cc=dima@arista.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.