From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yongqiang Niu <yongqiang.niu@mediatek.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Jassi Brar <jassisinghbrar@gmail.com>,
Fabien Parent <fparent@baylibre.com>,
Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v5, 3/4] soc: mediatek: mmsys: add component RDMA4
Date: Wed, 9 Jun 2021 09:43:55 +0200 [thread overview]
Message-ID: <a1824cdc-7e2f-a38f-d019-e1d8f92ead2b@gmail.com> (raw)
In-Reply-To: <1618236288-1617-4-git-send-email-yongqiang.niu@mediatek.com>
On 12/04/2021 16:04, Yongqiang Niu wrote:
> This patch add component RDMA4
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> ---
> include/linux/soc/mediatek/mtk-mmsys.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h
> index 7718cd6..4bba275 100644
> --- a/include/linux/soc/mediatek/mtk-mmsys.h
> +++ b/include/linux/soc/mediatek/mtk-mmsys.h
> @@ -38,6 +38,7 @@ enum mtk_ddp_comp_id {
> DDP_COMPONENT_RDMA0,
> DDP_COMPONENT_RDMA1,
> DDP_COMPONENT_RDMA2,
> + DDP_COMPONENT_RDMA4,
Pach 1-3 looks good, but could be squashed in one patch. Please try to come up
with a more descriptive commit message. Rule of thumb is to explain why we need
a patch not what the patch does.
Regards,
Matthias
> DDP_COMPONENT_UFOE,
> DDP_COMPONENT_WDMA0,
> DDP_COMPONENT_WDMA1,
>
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yongqiang Niu <yongqiang.niu@mediatek.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Jassi Brar <jassisinghbrar@gmail.com>,
Fabien Parent <fparent@baylibre.com>,
Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v5, 3/4] soc: mediatek: mmsys: add component RDMA4
Date: Wed, 9 Jun 2021 09:43:55 +0200 [thread overview]
Message-ID: <a1824cdc-7e2f-a38f-d019-e1d8f92ead2b@gmail.com> (raw)
In-Reply-To: <1618236288-1617-4-git-send-email-yongqiang.niu@mediatek.com>
On 12/04/2021 16:04, Yongqiang Niu wrote:
> This patch add component RDMA4
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> ---
> include/linux/soc/mediatek/mtk-mmsys.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h
> index 7718cd6..4bba275 100644
> --- a/include/linux/soc/mediatek/mtk-mmsys.h
> +++ b/include/linux/soc/mediatek/mtk-mmsys.h
> @@ -38,6 +38,7 @@ enum mtk_ddp_comp_id {
> DDP_COMPONENT_RDMA0,
> DDP_COMPONENT_RDMA1,
> DDP_COMPONENT_RDMA2,
> + DDP_COMPONENT_RDMA4,
Pach 1-3 looks good, but could be squashed in one patch. Please try to come up
with a more descriptive commit message. Rule of thumb is to explain why we need
a patch not what the patch does.
Regards,
Matthias
> DDP_COMPONENT_UFOE,
> DDP_COMPONENT_WDMA0,
> DDP_COMPONENT_WDMA1,
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yongqiang Niu <yongqiang.niu@mediatek.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Jassi Brar <jassisinghbrar@gmail.com>,
Fabien Parent <fparent@baylibre.com>,
Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v5, 3/4] soc: mediatek: mmsys: add component RDMA4
Date: Wed, 9 Jun 2021 09:43:55 +0200 [thread overview]
Message-ID: <a1824cdc-7e2f-a38f-d019-e1d8f92ead2b@gmail.com> (raw)
In-Reply-To: <1618236288-1617-4-git-send-email-yongqiang.niu@mediatek.com>
On 12/04/2021 16:04, Yongqiang Niu wrote:
> This patch add component RDMA4
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> ---
> include/linux/soc/mediatek/mtk-mmsys.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h
> index 7718cd6..4bba275 100644
> --- a/include/linux/soc/mediatek/mtk-mmsys.h
> +++ b/include/linux/soc/mediatek/mtk-mmsys.h
> @@ -38,6 +38,7 @@ enum mtk_ddp_comp_id {
> DDP_COMPONENT_RDMA0,
> DDP_COMPONENT_RDMA1,
> DDP_COMPONENT_RDMA2,
> + DDP_COMPONENT_RDMA4,
Pach 1-3 looks good, but could be squashed in one patch. Please try to come up
with a more descriptive commit message. Rule of thumb is to explain why we need
a patch not what the patch does.
Regards,
Matthias
> DDP_COMPONENT_UFOE,
> DDP_COMPONENT_WDMA0,
> DDP_COMPONENT_WDMA1,
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yongqiang Niu <yongqiang.niu@mediatek.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: devicetree@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
David Airlie <airlied@linux.ie>,
Jassi Brar <jassisinghbrar@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>,
Fabien Parent <fparent@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5, 3/4] soc: mediatek: mmsys: add component RDMA4
Date: Wed, 9 Jun 2021 09:43:55 +0200 [thread overview]
Message-ID: <a1824cdc-7e2f-a38f-d019-e1d8f92ead2b@gmail.com> (raw)
In-Reply-To: <1618236288-1617-4-git-send-email-yongqiang.niu@mediatek.com>
On 12/04/2021 16:04, Yongqiang Niu wrote:
> This patch add component RDMA4
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> ---
> include/linux/soc/mediatek/mtk-mmsys.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h
> index 7718cd6..4bba275 100644
> --- a/include/linux/soc/mediatek/mtk-mmsys.h
> +++ b/include/linux/soc/mediatek/mtk-mmsys.h
> @@ -38,6 +38,7 @@ enum mtk_ddp_comp_id {
> DDP_COMPONENT_RDMA0,
> DDP_COMPONENT_RDMA1,
> DDP_COMPONENT_RDMA2,
> + DDP_COMPONENT_RDMA4,
Pach 1-3 looks good, but could be squashed in one patch. Please try to come up
with a more descriptive commit message. Rule of thumb is to explain why we need
a patch not what the patch does.
Regards,
Matthias
> DDP_COMPONENT_UFOE,
> DDP_COMPONENT_WDMA0,
> DDP_COMPONENT_WDMA1,
>
next prev parent reply other threads:[~2021-06-09 7:44 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 14:04 [PATCH v5, 0/4] soc: mediatek: mmsys: add mt8192 mmsys support Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-04-12 14:04 ` [PATCH v5, 1/4] soc: mediatek: mmsys: add component OVL_2L2 Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-04-16 7:50 ` Enric Balletbo Serra
2021-04-16 7:50 ` Enric Balletbo Serra
2021-04-16 7:50 ` Enric Balletbo Serra
2021-04-16 7:50 ` Enric Balletbo Serra
2021-04-12 14:04 ` [PATCH v5, 2/4] soc: mediatek: mmsys: add component POSTMASK Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-04-16 7:51 ` Enric Balletbo Serra
2021-04-16 7:51 ` Enric Balletbo Serra
2021-04-16 7:51 ` Enric Balletbo Serra
2021-04-16 7:51 ` Enric Balletbo Serra
2021-04-12 14:04 ` [PATCH v5, 3/4] soc: mediatek: mmsys: add component RDMA4 Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-06-09 7:43 ` Matthias Brugger [this message]
2021-06-09 7:43 ` Matthias Brugger
2021-06-09 7:43 ` Matthias Brugger
2021-06-09 7:43 ` Matthias Brugger
2021-04-12 14:04 ` [PATCH v5, 4/4] soc: mediatek: mmsys: Add mt8192 mmsys routing table Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-04-12 14:04 ` Yongqiang Niu
2021-06-08 22:59 ` Chun-Jie Chen
2021-06-08 22:59 ` Chun-Jie Chen
2021-06-08 22:59 ` Chun-Jie Chen
2021-06-08 22:59 ` Chun-Jie Chen
2021-06-09 7:42 ` Matthias Brugger
2021-06-09 7:42 ` Matthias Brugger
2021-06-09 7:42 ` Matthias Brugger
2021-06-09 7:42 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1824cdc-7e2f-a38f-d019-e1d8f92ead2b@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dennis-yc.hsieh@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fparent@baylibre.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.