From: Si-Wei Liu <si-wei.liu@oracle.com> To: Jason Wang <jasowang@redhat.com>, mst@redhat.com Cc: elic@nvidia.com, parav@nvidia.com, wuzongyong@linux.alibaba.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, eperezma@redhat.com, lingshan.zhu@intel.com, gdawar@xilinx.com, lulu@redhat.com, xieyongji@bytedance.com Subject: Re: [PATCH V2 2/3] vdpa_sim_net: support feature provisioning Date: Fri, 23 Sep 2022 13:01:32 -0700 [thread overview] Message-ID: <a1e98754-114e-b401-e927-5f2b71c3c641@oracle.com> (raw) In-Reply-To: <20220922024305.1718-3-jasowang@redhat.com> On 9/21/2022 7:43 PM, Jason Wang wrote: > This patch implements features provisioning for vdpa_sim_net. > > 1) validating the provisioned features to be a subset of the parent > features. > 2) clearing the features that is not wanted by the userspace > > For example: > > # vdpa mgmtdev show > vdpasim_net: > supported_classes net > max_supported_vqs 3 > dev_features MTU MAC CTRL_VQ CTRL_MAC_ADDR ANY_LAYOUT VERSION_1 ACCESS_PLATFORM Sighs, not to blame any one and it's perhaps too late, but this "dev_features" attr in "mgmtdev show" command output should have been called "supported_features" in the first place. > > 1) provision vDPA device with all features that are supported by the > net simulator > > # vdpa dev add name dev1 mgmtdev vdpasim_net > # vdpa dev config show > dev1: mac 00:00:00:00:00:00 link up link_announce false mtu 1500 > negotiated_features MTU MAC CTRL_VQ CTRL_MAC_ADDR VERSION_1 ACCESS_PLATFORM Maybe not in this patch, but for completeness for the whole series, could we also add device_features to the output? When simply look at the "vdpa dev config show" output, I cannot really tell the actual device_features that was used in vdpa creation. For e.g. there is a missing feature ANY_LAYOUT from negotiated_features compared with supported_features in mgmtdev, but the orchestration software couldn't tell if the vdpa device on destination host should be created with or without the ANY_LAYOUT feature. Thanks, -Siwei > > 2) provision vDPA device with a subset of the features > > # vdpa dev add name dev1 mgmtdev vdpasim_net device_features 0x300020000 > # vdpa dev config show > dev1: mac 00:00:00:00:00:00 link up link_announce false mtu 1500 > negotiated_features CTRL_VQ VERSION_1 ACCESS_PLATFORM > > Reviewed-by: Eli Cohen <elic@nvidia.com> > Signed-off-by: Jason Wang <jasowang@redhat.com> > --- > drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > index 886449e88502..a9ba02be378b 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > @@ -254,6 +254,14 @@ static int vdpasim_net_dev_add(struct vdpa_mgmt_dev *mdev, const char *name, > dev_attr.work_fn = vdpasim_net_work; > dev_attr.buffer_size = PAGE_SIZE; > > + if (config->mask & BIT_ULL(VDPA_ATTR_DEV_FEATURES)) { > + if (config->device_features & > + ~dev_attr.supported_features) > + return -EINVAL; > + dev_attr.supported_features &= > + config->device_features; > + } > + > simdev = vdpasim_create(&dev_attr); > if (IS_ERR(simdev)) > return PTR_ERR(simdev); > @@ -294,7 +302,8 @@ static struct vdpa_mgmt_dev mgmt_dev = { > .id_table = id_table, > .ops = &vdpasim_net_mgmtdev_ops, > .config_attr_mask = (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR | > - 1 << VDPA_ATTR_DEV_NET_CFG_MTU), > + 1 << VDPA_ATTR_DEV_NET_CFG_MTU | > + 1 << VDPA_ATTR_DEV_FEATURES), > .max_supported_vqs = VDPASIM_NET_VQ_NUM, > .supported_features = VDPASIM_NET_FEATURES, > };
WARNING: multiple messages have this Message-ID (diff)
From: Si-Wei Liu <si-wei.liu@oracle.com> To: Jason Wang <jasowang@redhat.com>, mst@redhat.com Cc: lulu@redhat.com, xieyongji@bytedance.com, linux-kernel@vger.kernel.org, gdawar@xilinx.com, virtualization@lists.linux-foundation.org, eperezma@redhat.com, wuzongyong@linux.alibaba.com, elic@nvidia.com, lingshan.zhu@intel.com Subject: Re: [PATCH V2 2/3] vdpa_sim_net: support feature provisioning Date: Fri, 23 Sep 2022 13:01:32 -0700 [thread overview] Message-ID: <a1e98754-114e-b401-e927-5f2b71c3c641@oracle.com> (raw) In-Reply-To: <20220922024305.1718-3-jasowang@redhat.com> On 9/21/2022 7:43 PM, Jason Wang wrote: > This patch implements features provisioning for vdpa_sim_net. > > 1) validating the provisioned features to be a subset of the parent > features. > 2) clearing the features that is not wanted by the userspace > > For example: > > # vdpa mgmtdev show > vdpasim_net: > supported_classes net > max_supported_vqs 3 > dev_features MTU MAC CTRL_VQ CTRL_MAC_ADDR ANY_LAYOUT VERSION_1 ACCESS_PLATFORM Sighs, not to blame any one and it's perhaps too late, but this "dev_features" attr in "mgmtdev show" command output should have been called "supported_features" in the first place. > > 1) provision vDPA device with all features that are supported by the > net simulator > > # vdpa dev add name dev1 mgmtdev vdpasim_net > # vdpa dev config show > dev1: mac 00:00:00:00:00:00 link up link_announce false mtu 1500 > negotiated_features MTU MAC CTRL_VQ CTRL_MAC_ADDR VERSION_1 ACCESS_PLATFORM Maybe not in this patch, but for completeness for the whole series, could we also add device_features to the output? When simply look at the "vdpa dev config show" output, I cannot really tell the actual device_features that was used in vdpa creation. For e.g. there is a missing feature ANY_LAYOUT from negotiated_features compared with supported_features in mgmtdev, but the orchestration software couldn't tell if the vdpa device on destination host should be created with or without the ANY_LAYOUT feature. Thanks, -Siwei > > 2) provision vDPA device with a subset of the features > > # vdpa dev add name dev1 mgmtdev vdpasim_net device_features 0x300020000 > # vdpa dev config show > dev1: mac 00:00:00:00:00:00 link up link_announce false mtu 1500 > negotiated_features CTRL_VQ VERSION_1 ACCESS_PLATFORM > > Reviewed-by: Eli Cohen <elic@nvidia.com> > Signed-off-by: Jason Wang <jasowang@redhat.com> > --- > drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > index 886449e88502..a9ba02be378b 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > @@ -254,6 +254,14 @@ static int vdpasim_net_dev_add(struct vdpa_mgmt_dev *mdev, const char *name, > dev_attr.work_fn = vdpasim_net_work; > dev_attr.buffer_size = PAGE_SIZE; > > + if (config->mask & BIT_ULL(VDPA_ATTR_DEV_FEATURES)) { > + if (config->device_features & > + ~dev_attr.supported_features) > + return -EINVAL; > + dev_attr.supported_features &= > + config->device_features; > + } > + > simdev = vdpasim_create(&dev_attr); > if (IS_ERR(simdev)) > return PTR_ERR(simdev); > @@ -294,7 +302,8 @@ static struct vdpa_mgmt_dev mgmt_dev = { > .id_table = id_table, > .ops = &vdpasim_net_mgmtdev_ops, > .config_attr_mask = (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR | > - 1 << VDPA_ATTR_DEV_NET_CFG_MTU), > + 1 << VDPA_ATTR_DEV_NET_CFG_MTU | > + 1 << VDPA_ATTR_DEV_FEATURES), > .max_supported_vqs = VDPASIM_NET_VQ_NUM, > .supported_features = VDPASIM_NET_FEATURES, > }; _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-09-23 20:01 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-22 2:43 [PATCH V2 0/3] vdpa: device feature provisioning Jason Wang 2022-09-22 2:43 ` Jason Wang 2022-09-22 2:43 ` [PATCH V2 1/3] " Jason Wang 2022-09-22 2:43 ` Jason Wang 2022-09-22 2:43 ` [PATCH V2 2/3] vdpa_sim_net: support " Jason Wang 2022-09-22 2:43 ` Jason Wang 2022-09-22 5:13 ` Eli Cohen 2022-09-22 7:29 ` Michael S. Tsirkin 2022-09-22 7:29 ` Michael S. Tsirkin 2022-09-22 7:47 ` Eli Cohen 2022-09-22 7:53 ` Michael S. Tsirkin 2022-09-22 7:53 ` Michael S. Tsirkin 2022-09-22 8:01 ` Eli Cohen 2022-09-22 9:11 ` Michael S. Tsirkin 2022-09-22 9:11 ` Michael S. Tsirkin 2022-09-23 4:17 ` Jason Wang 2022-09-23 4:17 ` Jason Wang 2022-09-23 4:20 ` Jason Wang 2022-09-23 4:20 ` Jason Wang 2022-09-22 9:22 ` Stefano Garzarella 2022-09-22 9:22 ` Stefano Garzarella 2022-09-23 3:33 ` Jason Wang 2022-09-23 3:33 ` Jason Wang 2022-09-23 20:01 ` Si-Wei Liu [this message] 2022-09-23 20:01 ` Si-Wei Liu 2022-09-26 7:11 ` Jason Wang 2022-09-26 7:11 ` Jason Wang 2022-09-26 7:11 ` Jason Wang 2022-09-26 7:11 ` Jason Wang 2022-09-27 1:01 ` Si-Wei Liu 2022-09-27 3:59 ` Jason Wang 2022-09-27 3:59 ` Jason Wang 2022-09-27 4:07 ` Jason Wang 2022-09-27 4:07 ` Jason Wang 2022-09-27 10:00 ` Si-Wei Liu 2022-09-29 4:10 ` Jason Wang 2022-09-29 4:10 ` Jason Wang 2022-10-10 17:44 ` Si-Wei Liu 2022-10-10 17:44 ` Si-Wei Liu 2022-09-27 9:41 ` Si-Wei Liu 2022-09-29 4:55 ` Jason Wang 2022-09-29 4:55 ` Jason Wang 2022-10-07 0:35 ` Si-Wei Liu 2022-10-07 0:35 ` Si-Wei Liu 2022-10-13 7:10 ` Jason Wang 2022-10-13 7:10 ` Jason Wang 2022-10-17 18:43 ` Si-Wei Liu 2022-10-18 7:45 ` Jason Wang 2022-10-18 7:45 ` Jason Wang 2022-09-22 2:43 ` [PATCH V2 3/3] vp_vdpa: " Jason Wang 2022-09-22 2:43 ` Jason Wang 2022-09-23 20:11 ` Si-Wei Liu 2022-09-23 20:11 ` Si-Wei Liu 2022-09-26 7:14 ` Jason Wang 2022-09-26 7:14 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a1e98754-114e-b401-e927-5f2b71c3c641@oracle.com \ --to=si-wei.liu@oracle.com \ --cc=elic@nvidia.com \ --cc=eperezma@redhat.com \ --cc=gdawar@xilinx.com \ --cc=jasowang@redhat.com \ --cc=lingshan.zhu@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lulu@redhat.com \ --cc=mst@redhat.com \ --cc=parav@nvidia.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=wuzongyong@linux.alibaba.com \ --cc=xieyongji@bytedance.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.