From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org Cc: Takashi Sakamoto <o-takashi@sakamocchi.jp>, Mark Brown <broonie@kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org, Felipe Balbi <balbi@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org Subject: Re: [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk Date: Fri, 2 Jun 2017 12:12:03 +0300 [thread overview] Message-ID: <a6702e31-ba47-e240-8af2-62de74d89c89@cogentembedded.com> (raw) In-Reply-To: <20170601205850.24993-2-tiwai@suse.de> Hello! On 6/1/2017 11:58 PM, Takashi Iwai wrote: > The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk > for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec The standard way of citing a commit is: commit 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo"), just like in the Fixes: tag. > quirk for a MSI mobo. But it turned out that this isn't applied > properly due to the MSI-vendor quirk before this entry. I overlooked > such two MSI entries just because they were put in the wrong position, > although we have a list ordered by PCI SSID numbers. > > This patch fixes it by rearranging the unordered entries. > > Fixes: 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo") > Reported-by: Rudolf Schmidt <info@rudolfschmidt.com> > Signed-off-by: Takashi Iwai <tiwai@suse.de> [...] MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> To: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org Cc: Takashi Sakamoto <o-takashi-sodqOivclbsO3cATojSK5Q@public.gmane.org>, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Hans Verkuil <hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk Date: Fri, 2 Jun 2017 12:12:03 +0300 [thread overview] Message-ID: <a6702e31-ba47-e240-8af2-62de74d89c89@cogentembedded.com> (raw) In-Reply-To: <20170601205850.24993-2-tiwai-l3A5Bk7waGM@public.gmane.org> Hello! On 6/1/2017 11:58 PM, Takashi Iwai wrote: > The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk > for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec The standard way of citing a commit is: commit 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo"), just like in the Fixes: tag. > quirk for a MSI mobo. But it turned out that this isn't applied > properly due to the MSI-vendor quirk before this entry. I overlooked > such two MSI entries just because they were put in the wrong position, > although we have a list ordered by PCI SSID numbers. > > This patch fixes it by rearranging the unordered entries. > > Fixes: 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo") > Reported-by: Rudolf Schmidt <info-3q2wXJgvQBgtTFl30EOYJwC/G2K4zDHf@public.gmane.org> > Signed-off-by: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org> [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-02 9:12 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-01 20:58 [PATCH v2 00/27] Revised full patchset for PCM in-kernel copy support Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-01 20:58 ` [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-02 5:36 ` [alsa-devel] " Takashi Iwai 2017-06-02 9:12 ` Sergei Shtylyov [this message] 2017-06-02 9:12 ` Sergei Shtylyov 2017-06-01 20:58 ` [PATCH v2 02/27] ALSA: pcm: Introduce copy_user, copy_kernel and fill_silence ops Takashi Iwai 2017-06-02 17:14 ` Mark Brown 2017-06-02 17:14 ` Mark Brown 2017-06-01 20:58 ` [PATCH v2 03/27] ALSA: dummy: Convert to new PCM copy ops Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 04/27] ALSA: es1938: Convert to the " Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 05/27] ALSA: nm256: Convert to " Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 06/27] ALSA: korg1212: Convert to the new PCM ops Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 07/27] ALSA: rme32: Convert to the new PCM copy ops Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 08/27] ALSA: rme96: Convert to the new PCM ops Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 09/27] ALSA: rme9652: " Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 10/27] ALSA: hdsp: " Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 11/27] ALSA: gus: " Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 12/27] ALSA: sb: " Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 13/27] ALSA: sh: " Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 14/27] ASoC: blackfin: " Takashi Iwai 2017-06-02 17:14 ` Mark Brown 2017-06-01 20:58 ` [PATCH v2 15/27] [media] solo6x10: " Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-01 21:30 ` Hans Verkuil 2017-06-01 20:58 ` [PATCH v2 16/27] ALSA: pcm: Drop the old copy and silence ops Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 17/27] ALSA: pcm: Check PCM state by a common helper function Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 18/27] ALSA: pcm: Shuffle codes Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 19/27] ALSA: pcm: Call directly the common read/write helpers Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 20/27] ALSA: pcm: More unification of PCM transfer codes Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 21/27] ALSA: pcm: Unify read/write loop Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 22/27] ALSA: pcm: Simplify snd_pcm_playback_silence() Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 23/27] ALSA: pcm: Direct in-kernel read/write support Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 24/27] usb: gadget: u_uac1: Kill set_fs() usage Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-01 23:48 ` Greg Kroah-Hartman 2017-06-01 23:48 ` Greg Kroah-Hartman 2017-06-01 20:58 ` [PATCH v2 25/27] ALSA: pcm: Kill set_fs() in PCM OSS layer Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 26/27] ALSA: pcm: Build OSS writev/readv helpers conditionally Takashi Iwai 2017-06-01 20:58 ` [PATCH v2 27/27] ALSA: doc: Update copy_user, copy_kernel and fill_silence PCM ops Takashi Iwai 2017-06-01 20:58 ` Takashi Iwai 2017-06-02 7:13 ` [PATCH v2 00/27] Revised full patchset for PCM in-kernel copy support Takashi Sakamoto 2017-06-02 7:13 ` Takashi Sakamoto -- strict thread matches above, loose matches on Subject: below -- 2017-06-01 7:47 [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a6702e31-ba47-e240-8af2-62de74d89c89@cogentembedded.com \ --to=sergei.shtylyov@cogentembedded.com \ --cc=alsa-devel@alsa-project.org \ --cc=balbi@kernel.org \ --cc=broonie@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=hverkuil@xs4all.nl \ --cc=linux-media@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=o-takashi@sakamocchi.jp \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.