* [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable
@ 2017-08-15 14:30 Peter Maydell
2017-08-15 16:16 ` Thomas Huth
0 siblings, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2017-08-15 14:30 UTC (permalink / raw)
To: qemu-devel; +Cc: patches, KONRAD Frederic, edgar.iglesias, Thomas Huth
The mmio-interface device is not something we want to allow
users to create on the command line:
* it is intended as an implementation detail of the memory
subsystem, which gets created and deleted by that
subsystem on demand; it makes no sense to create it
by hand on the command line
* it uses a pointer property 'host_ptr' which can't be
set on the command line
Mark the device as not user_creatable to avoid confusion.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/misc/mmio_interface.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/misc/mmio_interface.c b/hw/misc/mmio_interface.c
index da154e5..894e980 100644
--- a/hw/misc/mmio_interface.c
+++ b/hw/misc/mmio_interface.c
@@ -111,6 +111,11 @@ static void mmio_interface_class_init(ObjectClass *oc, void *data)
dc->realize = mmio_interface_realize;
dc->unrealize = mmio_interface_unrealize;
dc->props = mmio_interface_properties;
+ /* Reason: pointer property "host_ptr", and this device
+ * is an implementation detail of the memory subsystem,
+ * not intended to be created directly by the user.
+ */
+ dc->user_creatable = false;
}
static const TypeInfo mmio_interface_info = {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable
2017-08-15 14:30 [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable Peter Maydell
@ 2017-08-15 16:16 ` Thomas Huth
2017-08-15 17:16 ` Peter Maydell
2017-08-15 22:58 ` Edgar E. Iglesias
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Huth @ 2017-08-15 16:16 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: patches, KONRAD Frederic, edgar.iglesias
On 15.08.2017 16:30, Peter Maydell wrote:
> The mmio-interface device is not something we want to allow
> users to create on the command line:
> * it is intended as an implementation detail of the memory
> subsystem, which gets created and deleted by that
> subsystem on demand; it makes no sense to create it
> by hand on the command line
> * it uses a pointer property 'host_ptr' which can't be
> set on the command line
>
> Mark the device as not user_creatable to avoid confusion.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/misc/mmio_interface.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/misc/mmio_interface.c b/hw/misc/mmio_interface.c
> index da154e5..894e980 100644
> --- a/hw/misc/mmio_interface.c
> +++ b/hw/misc/mmio_interface.c
> @@ -111,6 +111,11 @@ static void mmio_interface_class_init(ObjectClass *oc, void *data)
> dc->realize = mmio_interface_realize;
> dc->unrealize = mmio_interface_unrealize;
> dc->props = mmio_interface_properties;
> + /* Reason: pointer property "host_ptr", and this device
> + * is an implementation detail of the memory subsystem,
> + * not intended to be created directly by the user.
> + */
> + dc->user_creatable = false;
> }
>
> static const TypeInfo mmio_interface_info = {
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable
2017-08-15 16:16 ` Thomas Huth
@ 2017-08-15 17:16 ` Peter Maydell
2017-08-15 22:58 ` Edgar E. Iglesias
1 sibling, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2017-08-15 17:16 UTC (permalink / raw)
To: Thomas Huth; +Cc: QEMU Developers, patches, KONRAD Frederic, Edgar E. Iglesias
On 15 August 2017 at 17:16, Thomas Huth <thuth@redhat.com> wrote:
> On 15.08.2017 16:30, Peter Maydell wrote:
>> The mmio-interface device is not something we want to allow
>> users to create on the command line:
>> * it is intended as an implementation detail of the memory
>> subsystem, which gets created and deleted by that
>> subsystem on demand; it makes no sense to create it
>> by hand on the command line
>> * it uses a pointer property 'host_ptr' which can't be
>> set on the command line
>>
>> Mark the device as not user_creatable to avoid confusion.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> hw/misc/mmio_interface.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/hw/misc/mmio_interface.c b/hw/misc/mmio_interface.c
>> index da154e5..894e980 100644
>> --- a/hw/misc/mmio_interface.c
>> +++ b/hw/misc/mmio_interface.c
>> @@ -111,6 +111,11 @@ static void mmio_interface_class_init(ObjectClass *oc, void *data)
>> dc->realize = mmio_interface_realize;
>> dc->unrealize = mmio_interface_unrealize;
>> dc->props = mmio_interface_properties;
>> + /* Reason: pointer property "host_ptr", and this device
>> + * is an implementation detail of the memory subsystem,
>> + * not intended to be created directly by the user.
>> + */
>> + dc->user_creatable = false;
>> }
>>
>> static const TypeInfo mmio_interface_info = {
>>
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Applied to master, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable
2017-08-15 16:16 ` Thomas Huth
2017-08-15 17:16 ` Peter Maydell
@ 2017-08-15 22:58 ` Edgar E. Iglesias
1 sibling, 0 replies; 4+ messages in thread
From: Edgar E. Iglesias @ 2017-08-15 22:58 UTC (permalink / raw)
To: Thomas Huth; +Cc: Peter Maydell, qemu-devel, patches, KONRAD Frederic
On Tue, Aug 15, 2017 at 06:16:22PM +0200, Thomas Huth wrote:
> On 15.08.2017 16:30, Peter Maydell wrote:
> > The mmio-interface device is not something we want to allow
> > users to create on the command line:
> > * it is intended as an implementation detail of the memory
> > subsystem, which gets created and deleted by that
> > subsystem on demand; it makes no sense to create it
> > by hand on the command line
> > * it uses a pointer property 'host_ptr' which can't be
> > set on the command line
> >
> > Mark the device as not user_creatable to avoid confusion.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > hw/misc/mmio_interface.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/hw/misc/mmio_interface.c b/hw/misc/mmio_interface.c
> > index da154e5..894e980 100644
> > --- a/hw/misc/mmio_interface.c
> > +++ b/hw/misc/mmio_interface.c
> > @@ -111,6 +111,11 @@ static void mmio_interface_class_init(ObjectClass *oc, void *data)
> > dc->realize = mmio_interface_realize;
> > dc->unrealize = mmio_interface_unrealize;
> > dc->props = mmio_interface_properties;
> > + /* Reason: pointer property "host_ptr", and this device
> > + * is an implementation detail of the memory subsystem,
> > + * not intended to be created directly by the user.
> > + */
> > + dc->user_creatable = false;
> > }
> >
> > static const TypeInfo mmio_interface_info = {
> >
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-15 22:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-15 14:30 [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable Peter Maydell
2017-08-15 16:16 ` Thomas Huth
2017-08-15 17:16 ` Peter Maydell
2017-08-15 22:58 ` Edgar E. Iglesias
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.