From: Nicolas Dufresne <nicolas@ndufresne.ca> To: Ming Qian <ming.qian@nxp.com>, "mchehab@kernel.org" <mchehab@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de> Cc: "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>, Aisheng Dong <aisheng.dong@nxp.com>, "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [EXT] Re: [PATCH v12 00/13] amphion video decoder/encoder driver Date: Thu, 02 Dec 2021 23:09:59 -0500 [thread overview] Message-ID: <a77c2fca8bd1e95e1948d3fa98fe106c228221c7.camel@ndufresne.ca> (raw) In-Reply-To: <DB8PR04MB6346B64E4129D81BA0CF0A1CE7639@DB8PR04MB6346.eurprd04.prod.outlook.com> Le vendredi 26 novembre 2021 à 06:31 +0000, Ming Qian a écrit : > > -----Original Message----- > > From: Nicolas Dufresne [mailto:nicolas@ndufresne.ca] > > Sent: Thursday, November 25, 2021 11:36 PM > > To: Ming Qian <ming.qian@nxp.com>; mchehab@kernel.org; > > shawnguo@kernel.org; robh+dt@kernel.org; s.hauer@pengutronix.de > > Cc: hverkuil-cisco@xs4all.nl; kernel@pengutronix.de; festevam@gmail.com; > > dl-linux-imx <linux-imx@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>; > > linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org > > Subject: Re: [EXT] Re: [PATCH v12 00/13] amphion video decoder/encoder > > driver > > > > Caution: EXT Email > > > > Le jeudi 25 novembre 2021 à 05:25 +0000, Ming Qian a écrit : > > > For test [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0) > > > VPSSPSPPS_A_MainConcept_1, The vpu report an unsupported message to > > driver, so driver report pollerr to gstreamer. > > > But this stream can be decoded using the amphion vpu when I test it > > > using our unit test, I checked the difference, there are many vps, sps > > > and pps at the beginning, gstreamer will skip the first vpu and two > > > pps, totally skip 56 bytes. It leds to vpu can't decode And our unit test > > > won't > > skip anthing, so the vpu can decode the stream. > > > > This specific test triggers a bug in GStreamer HEVC parser, I'm aware of > > this > > one, and it is on my todo to fix (just not as trivial as it looks like, the > > VCL nal > > detection code was implemented wrong and that ended up leaking into the > > rest of the design). This specific test will of course be marked and skipped > > for CI > > test that uses GStreamer. > > > > regards, > > Nicolas > > Hi Nicolas, > > For the h264 decoder test, If I test with our unit test tool, the result > is 124/135 tests successfully, > But only 75/135 tests successfully when test using gstreamer. > There are 49 tests with different results, and all of the 49 test streams > are interlaced stream. > The amphion vpu will output the interlaced frame directly, it won't merge the > interlaced two parts into one progressive frame. > And the gstreamer tiled unpack function(unpack_NV12_TILED) won't handle > the interlaced case, so the output frame is abnormal, and led to test fail. > I think it should be a hardware limitation of the amphion vpu. And maybe If this is the case, it needs to be signaled as ALTERNATE (if you have 1 v4l2 buffer per field) or SEQ if they are stored in the same v4l2_buffer but on top of each other instead of interleaved. Some bit about this might not we all wired properly, I have only tested alternate field for capture devices (Xilinx ZinqMP). Please check the signalling of interlace field in your driver, I'll check the state of GStreamer in this regard. > the gstreamer videoconvert can handle it. > The interlaced list is as below: > [JVT-AVC_V1] cabac_mot_fld0_full > [JVT-AVC_V1] cabac_mot_mbaff0_full > [JVT-AVC_V1] cabac_mot_picaff0_full > [JVT-AVC_V1] CABREF3_Sand_D > [JVT-AVC_V1] CAFI1_SVA_C > [JVT-AVC_V1] CAMA1_Sony_C > [JVT-AVC_V1] CAMA1_TOSHIBA_B > [JVT-AVC_V1] CAMA3_Sand_E > [JVT-AVC_V1] CAMACI3_Sony_C > [JVT-AVC_V1] CAMANL1_TOSHIBA_B > [JVT-AVC_V1] CAMANL2_TOSHIBA_B > [JVT-AVC_V1] CAMANL3_Sand_E > [JVT-AVC_V1] CAMASL3_Sony_B > [JVT-AVC_V1] CAMP_MOT_MBAFF_L30 > [JVT-AVC_V1] CAMP_MOT_MBAFF_L31 > [JVT-AVC_V1] CANLMA2_Sony_C > [JVT-AVC_V1] CANLMA3_Sony_C > [JVT-AVC_V1] CAPA1_TOSHIBA_B > [JVT-AVC_V1] CAPAMA3_Sand_F > [JVT-AVC_V1] cavlc_mot_fld0_full_B > [JVT-AVC_V1] cavlc_mot_mbaff0_full_B > [JVT-AVC_V1] cavlc_mot_picaff0_full_B > [JVT-AVC_V1] CVCANLMA2_Sony_C > [JVT-AVC_V1] CVFI1_Sony_D > [JVT-AVC_V1] CVFI1_SVA_C > [JVT-AVC_V1] CVFI2_Sony_H > [JVT-AVC_V1] CVFI2_SVA_C > [JVT-AVC_V1] CVMA1_Sony_D > [JVT-AVC_V1] CVMA1_TOSHIBA_B > [JVT-AVC_V1] CVMANL1_TOSHIBA_B > [JVT-AVC_V1] CVMANL2_TOSHIBA_B > [JVT-AVC_V1] CVMAPAQP3_Sony_E > [JVT-AVC_V1] CVMAQP2_Sony_G > [JVT-AVC_V1] CVMAQP3_Sony_D > [JVT-AVC_V1] CVMP_MOT_FLD_L30_B > [JVT-AVC_V1] CVMP_MOT_FRM_L31_B > [JVT-AVC_V1] CVNLFI1_Sony_C > [JVT-AVC_V1] CVNLFI2_Sony_H > [JVT-AVC_V1] CVPA1_TOSHIBA_B > [JVT-AVC_V1] FI1_Sony_E > [JVT-AVC_V1] MR6_BT_B > [JVT-AVC_V1] MR7_BT_B > [JVT-AVC_V1] MR8_BT_B > [JVT-AVC_V1] MR9_BT_B > [JVT-AVC_V1] Sharp_MP_Field_1_B > [JVT-AVC_V1] Sharp_MP_Field_2_B > [JVT-AVC_V1] Sharp_MP_Field_3_B > [JVT-AVC_V1] Sharp_MP_PAFF_1r2 > [JVT-AVC_V1] Sharp_MP_PAFF_2r >
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Dufresne <nicolas@ndufresne.ca> To: Ming Qian <ming.qian@nxp.com>, "mchehab@kernel.org" <mchehab@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de> Cc: "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>, Aisheng Dong <aisheng.dong@nxp.com>, "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [EXT] Re: [PATCH v12 00/13] amphion video decoder/encoder driver Date: Thu, 02 Dec 2021 23:09:59 -0500 [thread overview] Message-ID: <a77c2fca8bd1e95e1948d3fa98fe106c228221c7.camel@ndufresne.ca> (raw) In-Reply-To: <DB8PR04MB6346B64E4129D81BA0CF0A1CE7639@DB8PR04MB6346.eurprd04.prod.outlook.com> Le vendredi 26 novembre 2021 à 06:31 +0000, Ming Qian a écrit : > > -----Original Message----- > > From: Nicolas Dufresne [mailto:nicolas@ndufresne.ca] > > Sent: Thursday, November 25, 2021 11:36 PM > > To: Ming Qian <ming.qian@nxp.com>; mchehab@kernel.org; > > shawnguo@kernel.org; robh+dt@kernel.org; s.hauer@pengutronix.de > > Cc: hverkuil-cisco@xs4all.nl; kernel@pengutronix.de; festevam@gmail.com; > > dl-linux-imx <linux-imx@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>; > > linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org > > Subject: Re: [EXT] Re: [PATCH v12 00/13] amphion video decoder/encoder > > driver > > > > Caution: EXT Email > > > > Le jeudi 25 novembre 2021 à 05:25 +0000, Ming Qian a écrit : > > > For test [JCT-VC-HEVC_V1] (GStreamer-H.265-V4L2-Gst1.0) > > > VPSSPSPPS_A_MainConcept_1, The vpu report an unsupported message to > > driver, so driver report pollerr to gstreamer. > > > But this stream can be decoded using the amphion vpu when I test it > > > using our unit test, I checked the difference, there are many vps, sps > > > and pps at the beginning, gstreamer will skip the first vpu and two > > > pps, totally skip 56 bytes. It leds to vpu can't decode And our unit test > > > won't > > skip anthing, so the vpu can decode the stream. > > > > This specific test triggers a bug in GStreamer HEVC parser, I'm aware of > > this > > one, and it is on my todo to fix (just not as trivial as it looks like, the > > VCL nal > > detection code was implemented wrong and that ended up leaking into the > > rest of the design). This specific test will of course be marked and skipped > > for CI > > test that uses GStreamer. > > > > regards, > > Nicolas > > Hi Nicolas, > > For the h264 decoder test, If I test with our unit test tool, the result > is 124/135 tests successfully, > But only 75/135 tests successfully when test using gstreamer. > There are 49 tests with different results, and all of the 49 test streams > are interlaced stream. > The amphion vpu will output the interlaced frame directly, it won't merge the > interlaced two parts into one progressive frame. > And the gstreamer tiled unpack function(unpack_NV12_TILED) won't handle > the interlaced case, so the output frame is abnormal, and led to test fail. > I think it should be a hardware limitation of the amphion vpu. And maybe If this is the case, it needs to be signaled as ALTERNATE (if you have 1 v4l2 buffer per field) or SEQ if they are stored in the same v4l2_buffer but on top of each other instead of interleaved. Some bit about this might not we all wired properly, I have only tested alternate field for capture devices (Xilinx ZinqMP). Please check the signalling of interlace field in your driver, I'll check the state of GStreamer in this regard. > the gstreamer videoconvert can handle it. > The interlaced list is as below: > [JVT-AVC_V1] cabac_mot_fld0_full > [JVT-AVC_V1] cabac_mot_mbaff0_full > [JVT-AVC_V1] cabac_mot_picaff0_full > [JVT-AVC_V1] CABREF3_Sand_D > [JVT-AVC_V1] CAFI1_SVA_C > [JVT-AVC_V1] CAMA1_Sony_C > [JVT-AVC_V1] CAMA1_TOSHIBA_B > [JVT-AVC_V1] CAMA3_Sand_E > [JVT-AVC_V1] CAMACI3_Sony_C > [JVT-AVC_V1] CAMANL1_TOSHIBA_B > [JVT-AVC_V1] CAMANL2_TOSHIBA_B > [JVT-AVC_V1] CAMANL3_Sand_E > [JVT-AVC_V1] CAMASL3_Sony_B > [JVT-AVC_V1] CAMP_MOT_MBAFF_L30 > [JVT-AVC_V1] CAMP_MOT_MBAFF_L31 > [JVT-AVC_V1] CANLMA2_Sony_C > [JVT-AVC_V1] CANLMA3_Sony_C > [JVT-AVC_V1] CAPA1_TOSHIBA_B > [JVT-AVC_V1] CAPAMA3_Sand_F > [JVT-AVC_V1] cavlc_mot_fld0_full_B > [JVT-AVC_V1] cavlc_mot_mbaff0_full_B > [JVT-AVC_V1] cavlc_mot_picaff0_full_B > [JVT-AVC_V1] CVCANLMA2_Sony_C > [JVT-AVC_V1] CVFI1_Sony_D > [JVT-AVC_V1] CVFI1_SVA_C > [JVT-AVC_V1] CVFI2_Sony_H > [JVT-AVC_V1] CVFI2_SVA_C > [JVT-AVC_V1] CVMA1_Sony_D > [JVT-AVC_V1] CVMA1_TOSHIBA_B > [JVT-AVC_V1] CVMANL1_TOSHIBA_B > [JVT-AVC_V1] CVMANL2_TOSHIBA_B > [JVT-AVC_V1] CVMAPAQP3_Sony_E > [JVT-AVC_V1] CVMAQP2_Sony_G > [JVT-AVC_V1] CVMAQP3_Sony_D > [JVT-AVC_V1] CVMP_MOT_FLD_L30_B > [JVT-AVC_V1] CVMP_MOT_FRM_L31_B > [JVT-AVC_V1] CVNLFI1_Sony_C > [JVT-AVC_V1] CVNLFI2_Sony_H > [JVT-AVC_V1] CVPA1_TOSHIBA_B > [JVT-AVC_V1] FI1_Sony_E > [JVT-AVC_V1] MR6_BT_B > [JVT-AVC_V1] MR7_BT_B > [JVT-AVC_V1] MR8_BT_B > [JVT-AVC_V1] MR9_BT_B > [JVT-AVC_V1] Sharp_MP_Field_1_B > [JVT-AVC_V1] Sharp_MP_Field_2_B > [JVT-AVC_V1] Sharp_MP_Field_3_B > [JVT-AVC_V1] Sharp_MP_PAFF_1r2 > [JVT-AVC_V1] Sharp_MP_PAFF_2r > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-03 4:10 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-09 9:08 [PATCH v12 00/13] amphion video decoder/encoder driver Ming Qian 2021-11-09 9:08 ` Ming Qian 2021-11-09 9:09 ` [PATCH v12 01/13] dt-bindings: media: amphion: add amphion video codec bindings Ming Qian 2021-11-09 9:09 ` Ming Qian 2021-11-09 9:09 ` [PATCH v12 02/13] media:Add nv12mt_8l128 and nv12mt_10be_8l128 video format Ming Qian 2021-11-09 9:09 ` Ming Qian 2021-11-09 9:09 ` [PATCH v12 03/13] media: amphion: add amphion vpu device driver Ming Qian 2021-11-09 9:09 ` Ming Qian 2021-11-09 9:09 ` [PATCH v12 04/13] media: amphion: add vpu core driver Ming Qian 2021-11-09 9:09 ` Ming Qian 2021-11-09 9:09 ` [PATCH v12 05/13] media: amphion: implement vpu core communication based on mailbox Ming Qian 2021-11-09 9:09 ` Ming Qian 2021-11-09 9:09 ` [PATCH v12 06/13] media: amphion: add vpu v4l2 m2m support Ming Qian 2021-11-09 9:09 ` Ming Qian 2021-11-09 9:09 ` [PATCH v12 07/13] media: amphion: add v4l2 m2m vpu encoder stateful driver Ming Qian 2021-11-09 9:09 ` Ming Qian 2021-11-09 9:09 ` [PATCH v12 08/13] media: amphion: add v4l2 m2m vpu decoder " Ming Qian 2021-11-09 9:09 ` Ming Qian 2021-11-09 9:09 ` [PATCH v12 09/13] media: amphion: implement windsor encoder rpc interface Ming Qian 2021-11-09 9:09 ` Ming Qian 2021-11-09 9:09 ` [PATCH v12 10/13] media: amphion: implement malone decoder " Ming Qian 2021-11-09 9:09 ` Ming Qian 2021-11-09 9:09 ` [PATCH v12 11/13] ARM64: dts: freescale: imx8q: add imx vpu codec entries Ming Qian 2021-11-09 9:09 ` Ming Qian 2021-11-09 9:09 ` [PATCH v12 12/13] firmware: imx: scu-pd: imx8q: add vpu mu resources Ming Qian 2021-11-09 9:09 ` Ming Qian 2021-11-09 9:09 ` [PATCH v12 13/13] MAINTAINERS: add AMPHION VPU CODEC V4L2 driver entry Ming Qian 2021-11-09 9:09 ` Ming Qian 2021-11-09 15:46 ` [PATCH v12 00/13] amphion video decoder/encoder driver Nicolas Dufresne 2021-11-09 15:46 ` Nicolas Dufresne 2021-11-23 19:22 ` Nicolas Dufresne 2021-11-23 19:22 ` Nicolas Dufresne 2021-11-24 9:00 ` [EXT] " Ming Qian 2021-11-24 9:00 ` Ming Qian 2021-11-24 14:57 ` Nicolas Dufresne 2021-11-24 14:57 ` Nicolas Dufresne 2021-11-25 5:25 ` Ming Qian 2021-11-25 5:25 ` Ming Qian 2021-11-25 15:36 ` Nicolas Dufresne 2021-11-25 15:36 ` Nicolas Dufresne 2021-11-26 6:31 ` Ming Qian 2021-11-26 6:31 ` Ming Qian 2021-12-03 4:09 ` Nicolas Dufresne [this message] 2021-12-03 4:09 ` Nicolas Dufresne 2021-12-03 5:20 ` Ming Qian 2021-12-03 5:20 ` Ming Qian
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a77c2fca8bd1e95e1948d3fa98fe106c228221c7.camel@ndufresne.ca \ --to=nicolas@ndufresne.ca \ --cc=aisheng.dong@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=ming.qian@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.