From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: Sebastian Fricke <sebastian.fricke@collabora.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, NXP Linux Team <linux-imx@nxp.com>, Conor Dooley <conor+dt@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Jackson Lee <jackson.lee@chipsnmedia.com>, Hans Verkuil <hverkuil@xs4all.nl>, Sascha Hauer <s.hauer@pengutronix.de>, Rob Herring <robh+dt@kernel.org>, Pengutronix Kernel Team <kernel@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, Nas Chung <nas.chung@chipsnmedia.com>, Fabio Estevam <festevam@gmail.com> Cc: linux-media@vger.kernel.org, Tomasz Figa <tfiga@chromium.org>, linux-kernel@vger.kernel.org, Nicolas Dufresne <nicolas.dufresne@collabora.com>, kernel@collabora.com, Robert Beckett <bob.beckett@collabora.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Darren Etheridge <detheridge@ti.com> Subject: Re: [PATCH v13 4/8] media: chips-media: wave5: Add vpuapi layer Date: Sun, 22 Oct 2023 18:27:52 +0200 [thread overview] Message-ID: <a836dc4d-99e3-494d-b374-594f53287bae@wanadoo.fr> (raw) In-Reply-To: <20230929-wave5_v13_media_master-v13-4-5ac60ccbf2ce@collabora.com> Le 12/10/2023 à 13:01, Sebastian Fricke a écrit : > From: Nas Chung <nas.chung@chipsnmedia.com> > > Add the vpuapi layer of the wave5 codec driver. > This layer is used to configure the hardware according > to the parameters. > > Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com> > Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com> > --- ... > +int wave5_vpu_dec_clr_disp_flag(struct vpu_instance *inst, int index) > +{ > + struct dec_info *p_dec_info = &inst->codec_info->dec_info; > + int ret = 0; Nit: No need to init. > + struct vpu_device *vpu_dev = inst->dev; > + > + if (index >= p_dec_info->num_of_display_fbs) > + return -EINVAL; > + > + ret = mutex_lock_interruptible(&vpu_dev->hw_lock); > + if (ret) > + return ret; > + ret = wave5_dec_clr_disp_flag(inst, index); > + mutex_unlock(&vpu_dev->hw_lock); > + > + return ret; > +} ... > +int wave5_vpu_dec_give_command(struct vpu_instance *inst, enum codec_command cmd, void *parameter) > +{ > + struct dec_info *p_dec_info = &inst->codec_info->dec_info; > + int ret = 0; > + > + switch (cmd) { > + case DEC_GET_QUEUE_STATUS: { > + struct queue_status_info *queue_info = parameter; > + > + queue_info->instance_queue_count = p_dec_info->instance_queue_count; > + queue_info->report_queue_count = p_dec_info->report_queue_count; > + break; > + } > + case DEC_RESET_FRAMEBUF_INFO: { > + int i; > + > + for (i = 0; i < MAX_REG_FRAME; i++) { > + ret = wave5_vpu_dec_reset_framebuffer(inst, i); > + if (ret) > + break; > + } > + > + for (i = 0; i < MAX_REG_FRAME; i++) { > + ret = reset_auxiliary_buffers(inst, i); > + if (ret) > + break; > + } > + > + wave5_vdi_free_dma_memory(inst->dev, &p_dec_info->vb_task); > + break; > + } > + case DEC_GET_SEQ_INFO: { > + struct dec_initial_info *seq_info = parameter; > + > + *seq_info = p_dec_info->initial_info; > + break; > + } > + > + default: > + return -EINVAL; > + } > + > + return 0; return ret; ? CJ > +} ...
WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: Sebastian Fricke <sebastian.fricke@collabora.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, NXP Linux Team <linux-imx@nxp.com>, Conor Dooley <conor+dt@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Jackson Lee <jackson.lee@chipsnmedia.com>, Hans Verkuil <hverkuil@xs4all.nl>, Sascha Hauer <s.hauer@pengutronix.de>, Rob Herring <robh+dt@kernel.org>, Pengutronix Kernel Team <kernel@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, Nas Chung <nas.chung@chipsnmedia.com>, Fabio Estevam <festevam@gmail.com> Cc: linux-media@vger.kernel.org, Tomasz Figa <tfiga@chromium.org>, linux-kernel@vger.kernel.org, Nicolas Dufresne <nicolas.dufresne@collabora.com>, kernel@collabora.com, Robert Beckett <bob.beckett@collabora.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Darren Etheridge <detheridge@ti.com> Subject: Re: [PATCH v13 4/8] media: chips-media: wave5: Add vpuapi layer Date: Sun, 22 Oct 2023 18:27:52 +0200 [thread overview] Message-ID: <a836dc4d-99e3-494d-b374-594f53287bae@wanadoo.fr> (raw) In-Reply-To: <20230929-wave5_v13_media_master-v13-4-5ac60ccbf2ce@collabora.com> Le 12/10/2023 à 13:01, Sebastian Fricke a écrit : > From: Nas Chung <nas.chung@chipsnmedia.com> > > Add the vpuapi layer of the wave5 codec driver. > This layer is used to configure the hardware according > to the parameters. > > Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com> > Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > Signed-off-by: Robert Beckett <bob.beckett@collabora.com> > Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com> > --- ... > +int wave5_vpu_dec_clr_disp_flag(struct vpu_instance *inst, int index) > +{ > + struct dec_info *p_dec_info = &inst->codec_info->dec_info; > + int ret = 0; Nit: No need to init. > + struct vpu_device *vpu_dev = inst->dev; > + > + if (index >= p_dec_info->num_of_display_fbs) > + return -EINVAL; > + > + ret = mutex_lock_interruptible(&vpu_dev->hw_lock); > + if (ret) > + return ret; > + ret = wave5_dec_clr_disp_flag(inst, index); > + mutex_unlock(&vpu_dev->hw_lock); > + > + return ret; > +} ... > +int wave5_vpu_dec_give_command(struct vpu_instance *inst, enum codec_command cmd, void *parameter) > +{ > + struct dec_info *p_dec_info = &inst->codec_info->dec_info; > + int ret = 0; > + > + switch (cmd) { > + case DEC_GET_QUEUE_STATUS: { > + struct queue_status_info *queue_info = parameter; > + > + queue_info->instance_queue_count = p_dec_info->instance_queue_count; > + queue_info->report_queue_count = p_dec_info->report_queue_count; > + break; > + } > + case DEC_RESET_FRAMEBUF_INFO: { > + int i; > + > + for (i = 0; i < MAX_REG_FRAME; i++) { > + ret = wave5_vpu_dec_reset_framebuffer(inst, i); > + if (ret) > + break; > + } > + > + for (i = 0; i < MAX_REG_FRAME; i++) { > + ret = reset_auxiliary_buffers(inst, i); > + if (ret) > + break; > + } > + > + wave5_vdi_free_dma_memory(inst->dev, &p_dec_info->vb_task); > + break; > + } > + case DEC_GET_SEQ_INFO: { > + struct dec_initial_info *seq_info = parameter; > + > + *seq_info = p_dec_info->initial_info; > + break; > + } > + > + default: > + return -EINVAL; > + } > + > + return 0; return ret; ? CJ > +} ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-22 16:28 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-12 11:00 [PATCH v13 0/8] Wave5 codec driver Sebastian Fricke 2023-10-12 11:00 ` Sebastian Fricke 2023-10-12 11:00 ` [PATCH v13 1/8] media: v4l2: Add ignore_cap_streaming flag Sebastian Fricke 2023-10-12 11:00 ` Sebastian Fricke 2023-10-12 11:01 ` [PATCH v13 2/8] media: v4l2: Allow M2M job queuing w/o streaming CAP queue Sebastian Fricke 2023-10-12 11:01 ` Sebastian Fricke 2023-10-12 11:01 ` [PATCH v13 3/8] media: platform: chips-media: Move Coda to separate folder Sebastian Fricke 2023-10-12 11:01 ` Sebastian Fricke 2023-10-12 11:01 ` [PATCH v13 4/8] media: chips-media: wave5: Add vpuapi layer Sebastian Fricke 2023-10-22 16:27 ` Christophe JAILLET [this message] 2023-10-22 16:27 ` Christophe JAILLET 2023-10-12 11:01 ` [PATCH v13 5/8] media: chips-media: wave5: Add the v4l2 layer Sebastian Fricke 2023-10-16 11:57 ` Hans Verkuil 2023-10-16 11:57 ` Hans Verkuil 2023-10-16 13:35 ` Sebastian Fricke 2023-10-16 13:35 ` Sebastian Fricke 2023-10-16 13:39 ` Hans Verkuil 2023-10-16 13:39 ` Hans Verkuil 2023-10-17 22:13 ` Ivan Bornyakov 2023-10-17 22:13 ` Ivan Bornyakov 2023-11-02 17:07 ` Deborah Brouwer 2023-11-02 17:07 ` Deborah Brouwer 2023-11-03 10:42 ` Ivan Bornyakov 2023-11-03 10:42 ` Ivan Bornyakov 2023-10-12 11:01 ` [PATCH v13 6/8] media: dt-bindings: wave5: add Chips&Media 521c codec IP support Sebastian Fricke 2023-10-12 11:01 ` Sebastian Fricke 2023-10-12 13:24 ` Krzysztof Kozlowski 2023-10-12 13:24 ` Krzysztof Kozlowski 2023-10-16 13:47 ` Rob Herring 2023-10-16 13:47 ` Rob Herring 2023-10-21 12:05 ` Sebastian Fricke 2023-10-21 12:05 ` Sebastian Fricke 2023-10-22 16:01 ` Krzysztof Kozlowski 2023-10-22 16:01 ` Krzysztof Kozlowski 2023-10-24 5:17 ` Sebastian Fricke 2023-10-24 5:17 ` Sebastian Fricke 2023-10-24 7:24 ` Krzysztof Kozlowski 2023-10-24 7:24 ` Krzysztof Kozlowski 2023-10-25 6:17 ` Sebastian Fricke 2023-10-25 6:17 ` Sebastian Fricke 2023-10-25 7:04 ` Krzysztof Kozlowski 2023-10-25 7:04 ` Krzysztof Kozlowski 2023-10-17 13:39 ` Devarsh Thakkar 2023-10-17 13:39 ` Devarsh Thakkar 2023-10-21 11:53 ` Sebastian Fricke 2023-10-21 11:53 ` Sebastian Fricke 2023-10-22 16:12 ` Krzysztof Kozlowski 2023-10-22 16:12 ` Krzysztof Kozlowski 2023-10-26 16:33 ` Sebastian Fricke 2023-10-26 16:33 ` Sebastian Fricke 2023-10-27 7:07 ` Krzysztof Kozlowski 2023-10-27 7:07 ` Krzysztof Kozlowski 2023-10-12 11:01 ` [PATCH v13 7/8] media: chips-media: wave5: Add wave5 driver to maintainers file Sebastian Fricke 2023-10-12 11:01 ` Sebastian Fricke 2023-10-12 11:01 ` [PATCH v13 8/8] arm64: dts: ti: k3-j721s2-main: add wave5 video encoder/decoder node Sebastian Fricke 2023-10-12 11:01 ` Sebastian Fricke
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a836dc4d-99e3-494d-b374-594f53287bae@wanadoo.fr \ --to=christophe.jaillet@wanadoo.fr \ --cc=bob.beckett@collabora.com \ --cc=conor+dt@kernel.org \ --cc=detheridge@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=hverkuil@xs4all.nl \ --cc=jackson.lee@chipsnmedia.com \ --cc=kernel@collabora.com \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=nas.chung@chipsnmedia.com \ --cc=nicolas.dufresne@collabora.com \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=sebastian.fricke@collabora.com \ --cc=shawnguo@kernel.org \ --cc=tfiga@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.