From: Andrew Davis <afd@ti.com> To: Francesco Dolcini <francesco@dolcini.it>, Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com> Cc: Francesco Dolcini <francesco.dolcini@toradex.com>, Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v1 1/5] dt-bindings: arm: ti: add toradex,verdin-am62 et al. Date: Wed, 24 May 2023 12:48:34 -0500 [thread overview] Message-ID: <a87d493a-0f16-0096-0a01-5bbeddf4cfee@ti.com> (raw) In-Reply-To: <20230524143631.42471-2-francesco@dolcini.it> On 5/24/23 9:36 AM, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Add toradex,verdin-am62 for Toradex Verdin AM62 SoM, its > nonwifi and wifi variants and the carrier boards (Dahlia, > Verdin Development Board and Yavia) they may be mated in. > > Link: https://developer.toradex.com/hardware/verdin-som-family/modules/verdin-am62/ > Link: https://www.toradex.com/computer-on-modules/verdin-arm-family/ti-am62 > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > .../devicetree/bindings/arm/ti/k3.yaml | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml > index e1183f90bb06..e3aee191d403 100644 > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml > @@ -33,6 +33,26 @@ properties: > - ti,am62-lp-sk > - const: ti,am625 > > + - description: K3 AM62x SoC Toradex Verdin Modules and Carrier Boards > + items: > + - enum: > + - toradex,verdin-am62-nonwifi-dahlia # Verdin AM62 Module on Dahlia > + - toradex,verdin-am62-nonwifi-dev # Verdin AM62 Module on Verdin Development Board > + - toradex,verdin-am62-nonwifi-yavia # Verdin AM62 Module on Yavia > + - const: toradex,verdin-am62-nonwifi # Verdin AM62 Module without Wi-Fi / BT Does this add anything? Not sure we need to split compatibles based on this, things like wifi vs nowifi can be described in DT, same for different memory size models, etc.. In fact I'm not sure we get much value at all out of top level whole-SoC compatible strings. Maybe we did when there was matching in kernel to do device specific fixups, but that isn't really used much in ARM64. Andrew > + - const: toradex,verdin-am62 # Verdin AM62 Module > + - const: ti,am625 > + > + - description: K3 AM62x SoC Toradex Verdin Modules and Carrier Boards with Wi-Fi / BT > + items: > + - enum: > + - toradex,verdin-am62-wifi-dahlia # Verdin AM62 Wi-Fi / BT Module on Dahlia > + - toradex,verdin-am62-wifi-dev # Verdin AM62 Wi-Fi / BT M. on Verdin Development B. > + - toradex,verdin-am62-wifi-yavia # Verdin AM62 Wi-Fi / BT Module on Yavia > + - const: toradex,verdin-am62-wifi # Verdin AM62 Wi-Fi / BT Module > + - const: toradex,verdin-am62 # Verdin AM62 Module > + - const: ti,am625 > + > - description: K3 AM642 SoC > items: > - enum:
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Davis <afd@ti.com> To: Francesco Dolcini <francesco@dolcini.it>, Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com> Cc: Francesco Dolcini <francesco.dolcini@toradex.com>, Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v1 1/5] dt-bindings: arm: ti: add toradex,verdin-am62 et al. Date: Wed, 24 May 2023 12:48:34 -0500 [thread overview] Message-ID: <a87d493a-0f16-0096-0a01-5bbeddf4cfee@ti.com> (raw) In-Reply-To: <20230524143631.42471-2-francesco@dolcini.it> On 5/24/23 9:36 AM, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Add toradex,verdin-am62 for Toradex Verdin AM62 SoM, its > nonwifi and wifi variants and the carrier boards (Dahlia, > Verdin Development Board and Yavia) they may be mated in. > > Link: https://developer.toradex.com/hardware/verdin-som-family/modules/verdin-am62/ > Link: https://www.toradex.com/computer-on-modules/verdin-arm-family/ti-am62 > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > .../devicetree/bindings/arm/ti/k3.yaml | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml > index e1183f90bb06..e3aee191d403 100644 > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml > @@ -33,6 +33,26 @@ properties: > - ti,am62-lp-sk > - const: ti,am625 > > + - description: K3 AM62x SoC Toradex Verdin Modules and Carrier Boards > + items: > + - enum: > + - toradex,verdin-am62-nonwifi-dahlia # Verdin AM62 Module on Dahlia > + - toradex,verdin-am62-nonwifi-dev # Verdin AM62 Module on Verdin Development Board > + - toradex,verdin-am62-nonwifi-yavia # Verdin AM62 Module on Yavia > + - const: toradex,verdin-am62-nonwifi # Verdin AM62 Module without Wi-Fi / BT Does this add anything? Not sure we need to split compatibles based on this, things like wifi vs nowifi can be described in DT, same for different memory size models, etc.. In fact I'm not sure we get much value at all out of top level whole-SoC compatible strings. Maybe we did when there was matching in kernel to do device specific fixups, but that isn't really used much in ARM64. Andrew > + - const: toradex,verdin-am62 # Verdin AM62 Module > + - const: ti,am625 > + > + - description: K3 AM62x SoC Toradex Verdin Modules and Carrier Boards with Wi-Fi / BT > + items: > + - enum: > + - toradex,verdin-am62-wifi-dahlia # Verdin AM62 Wi-Fi / BT Module on Dahlia > + - toradex,verdin-am62-wifi-dev # Verdin AM62 Wi-Fi / BT M. on Verdin Development B. > + - toradex,verdin-am62-wifi-yavia # Verdin AM62 Wi-Fi / BT Module on Yavia > + - const: toradex,verdin-am62-wifi # Verdin AM62 Wi-Fi / BT Module > + - const: toradex,verdin-am62 # Verdin AM62 Module > + - const: ti,am625 > + > - description: K3 AM642 SoC > items: > - enum: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-24 17:49 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-24 14:36 [PATCH v1 0/5] Add Toradex Verdin AM62 Francesco Dolcini 2023-05-24 14:36 ` Francesco Dolcini 2023-05-24 14:36 ` [PATCH v1 1/5] dt-bindings: arm: ti: add toradex,verdin-am62 et al Francesco Dolcini 2023-05-24 14:36 ` Francesco Dolcini 2023-05-24 17:48 ` Andrew Davis [this message] 2023-05-24 17:48 ` Andrew Davis 2023-05-24 19:10 ` Nishanth Menon 2023-05-24 19:10 ` Nishanth Menon 2023-05-24 19:20 ` Francesco Dolcini 2023-05-24 19:20 ` Francesco Dolcini 2023-05-31 8:29 ` Krzysztof Kozlowski 2023-05-31 8:29 ` Krzysztof Kozlowski 2023-05-24 19:15 ` Conor Dooley 2023-05-24 19:15 ` Conor Dooley 2023-05-30 12:12 ` Nishanth Menon 2023-05-30 12:12 ` Nishanth Menon 2023-05-30 16:58 ` Francesco Dolcini 2023-05-30 16:58 ` Francesco Dolcini 2023-05-24 14:36 ` [PATCH v1 2/5] arm64: defconfig: enable drivers for Verdin AM62 Francesco Dolcini 2023-05-24 14:36 ` Francesco Dolcini 2023-05-24 14:36 ` [PATCH v1 3/5] arm64: dts: ti: add verdin am62 Francesco Dolcini 2023-05-24 14:36 ` Francesco Dolcini 2023-05-30 10:18 ` Francesco Dolcini 2023-05-30 10:18 ` Francesco Dolcini 2023-05-30 12:10 ` Nishanth Menon 2023-05-30 12:10 ` Nishanth Menon 2023-05-30 13:31 ` Raghavendra, Vignesh 2023-05-30 13:31 ` Raghavendra, Vignesh 2023-05-30 16:36 ` Francesco Dolcini 2023-05-30 16:36 ` Francesco Dolcini 2023-05-30 16:53 ` Nishanth Menon 2023-05-30 16:53 ` Nishanth Menon 2023-05-30 17:17 ` Francesco Dolcini 2023-05-30 17:17 ` Francesco Dolcini 2023-05-24 14:36 ` [PATCH v1 4/5] arm64: dts: ti: add verdin am62 dahlia Francesco Dolcini 2023-05-24 14:36 ` Francesco Dolcini 2023-05-24 14:36 ` [PATCH v1 5/5] arm64: dts: ti: add verdin am62 yavia Francesco Dolcini 2023-05-24 14:36 ` Francesco Dolcini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a87d493a-0f16-0096-0a01-5bbeddf4cfee@ti.com \ --to=afd@ti.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=francesco.dolcini@toradex.com \ --cc=francesco@dolcini.it \ --cc=kristo@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nm@ti.com \ --cc=robh+dt@kernel.org \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.