Re: [PATCH 0/4] Enable gigadevice and add new part #s

From: Michal Simek <michal.simek@amd.com>
To: Vlim <vlim@gigadevice.com>, Michal Simek <monstr@monstr.eu>,
	"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Cc: "vigneshr@ti.com" <vigneshr@ti.com>,
	"jagan@amarulasolutions.com" <jagan@amarulasolutions.com>,
	"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
	"vikhyat.goyal@amd.com" <vikhyat.goyal@amd.com>,
	"ashok.reddy.soma@amd.com" <ashok.reddy.soma@amd.com>
Subject: Re: [PATCH 0/4] Enable gigadevice and add new part #s
Date: Mon, 9 Jan 2023 08:59:52 +0100	[thread overview]
Message-ID: <a9e297f5-a255-2374-709e-4e5b5772f6fc@amd.com> (raw)
In-Reply-To: <TY0PR06MB565866A27E1F881FB702620CBBFB9@TY0PR06MB5658.apcprd06.prod.outlook.com>



On 1/6/23 20:53, Vlim wrote:
> Hi, Michal,
> 
> 
> 
> On 1/5/23 20:47, Vlim wrote:
>>> Regarding the location of the entry, I believe you want me to add the entry in
>>> the alphabetical order?
>>
>> Not really. I want to you follow Kconfig layout which is what make savedefconfig
>> && cp defconfig configs/<defconfig> is for.
>>
>> Can you be more specific on this requirement?
>> I believe this is pertaining to the defconfig files.
>> Where is the correct line to insert the following entry?
>> CONFIG_SPI_FLASH_GIGADEVICE=y
> 
> Again. Just enable that option and run for example
> make xilinx_zynqmp_virt_defconfig
> 
> echo CONFIG_SPI_FLASH_GIGADEVICE=y >> .config
> make savedefconfig
> cp defconfig configs/xilinx_zynqmp_virt_defconfig
> git commit -a -s
> 
> And that's it. Your symbol will be added to proper location.
> 
> I did the make command, but it says nothing to be done.
> Do I need to install an additional software package in order to perform this 
> function?
> 
> victor@victor-17Z990-R-AAC9U1:~/Desktop/u-boot-xlnx/configs$ make 
> zynq_cse_qspi_defconfig
> make: Nothing to be done for 'zynq_cse_qspi_defconfig'.
> victor@victor-17Z990-R-AAC9U1:~/Desktop/u-boot-xlnx/configs$

Please check that you use upstream tree without any your patches in.
Here is how it should look like.

[shm]$ git clone https://gitlab.denx.de/u-boot/u-boot.git
Cloning into 'u-boot'...
warning: redirecting to https://source.denx.de/u-boot/u-boot.git/
remote: Enumerating objects: 956, done.
remote: Counting objects: 100% (798/798), done.
remote: Compressing objects: 100% (245/245), done.
remote: Total 566 (delta 449), reused 423 (delta 313), pack-reused 0
Receiving objects: 100% (566/566), 131.65 KiB | 1.13 MiB/s, done.
Resolving deltas: 100% (449/449), completed with 146 local objects.
[shm]$ cd u-boot/
[u-boot](master)$ ls
api    cmd        disk     env       Kbuild    MAINTAINERS  README
arch   common     doc      examples  Kconfig   Makefile     scripts
board  config.mk  drivers  fs        lib       net          test
boot   configs    dts      include   Licenses  post         tools
[u-boot](master)$ arm64
[u-boot](master)$ make xilinx_zynqmp_virt_defconfig
   HOSTCC  scripts/basic/fixdep
   HOSTCC  scripts/kconfig/conf.o
   YACC    scripts/kconfig/zconf.tab.c
   LEX     scripts/kconfig/zconf.lex.c
   HOSTCC  scripts/kconfig/zconf.tab.o
   HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
[u-boot](master)$ echo CONFIG_SPI_FLASH_GIGADEVICE=y >> .config
[u-boot](master)$ make savedefconfig
scripts/kconfig/conf  --savedefconfig=defconfig Kconfig
.config:2307:warning: override: reassigning to symbol SPI_FLASH_GIGADEVICE
[u-boot](master)$ cp defconfig configs/xilinx_zynqmp_virt_defconfig
[u-boot](master)$ git diff

diff --git a/configs/xilinx_zynqmp_virt_defconfig 
b/configs/xilinx_zynqmp_virt_defconfig
index 4732c39bdbe1..b722850d6a5a 100644
--- a/configs/xilinx_zynqmp_virt_defconfig
+++ b/configs/xilinx_zynqmp_virt_defconfig
@@ -158,6 +158,7 @@ CONFIG_NAND_ARASAN=y
  CONFIG_SYS_NAND_ONFI_DETECTION=y
  CONFIG_SYS_NAND_MAX_CHIPS=2
  CONFIG_SPI_FLASH_BAR=y
+CONFIG_SPI_FLASH_GIGADEVICE=y
  CONFIG_SPI_FLASH_ISSI=y
  CONFIG_SPI_FLASH_MACRONIX=y
  CONFIG_SPI_FLASH_SPANSION=y


Thanks,
Michal
