From: Jason Wang <jasowang@redhat.com> To: Jakub Kicinski <kuba@kernel.org> Cc: mst@redhat.com, davem@davemloft.net, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ivan@prestigetransportation.com, xiangxia.m.yue@gmail.com, willemb@google.com, edumazet@google.com Subject: Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO Date: Thu, 12 Aug 2021 11:23:04 +0800 [thread overview] Message-ID: <aa3e2aca-05a9-aed7-59ec-eb4bd32d8f76@redhat.com> (raw) In-Reply-To: <20210811151754.030a22a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> 在 2021/8/12 上午6:17, Jakub Kicinski 写道: > On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote: >> Try to fix this by using NETIF_F_GRO_HW instead so we're not >> guaranteed to be re-segmented as original. > This sentence may need rephrasing. Right, actually, I meant: Try to fix this by using NETIF_F_GRO_HW instead. But we're not sure the packet could be re-segmented to the exact original packet stream. Since it's really depends on the bakcend implementation. > >> Or we may want a new netdev >> feature like RX_GSO since the guest offloads for virtio-net is >> actually to receive GSO packet. >> >> Or we can try not advertise LRO is control guest offloads is not >> enabled. This solves the warning but will still slow down the traffic. > IMO gro-hw fits pretty well, patch looks good. If the re-segmentation is not a issue. I will post a formal patch. Thanks >
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Jakub Kicinski <kuba@kernel.org> Cc: willemb@google.com, mst@redhat.com, netdev@vger.kernel.org, ivan@prestigetransportation.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, edumazet@google.com, davem@davemloft.net Subject: Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO Date: Thu, 12 Aug 2021 11:23:04 +0800 [thread overview] Message-ID: <aa3e2aca-05a9-aed7-59ec-eb4bd32d8f76@redhat.com> (raw) In-Reply-To: <20210811151754.030a22a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> 在 2021/8/12 上午6:17, Jakub Kicinski 写道: > On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote: >> Try to fix this by using NETIF_F_GRO_HW instead so we're not >> guaranteed to be re-segmented as original. > This sentence may need rephrasing. Right, actually, I meant: Try to fix this by using NETIF_F_GRO_HW instead. But we're not sure the packet could be re-segmented to the exact original packet stream. Since it's really depends on the bakcend implementation. > >> Or we may want a new netdev >> feature like RX_GSO since the guest offloads for virtio-net is >> actually to receive GSO packet. >> >> Or we can try not advertise LRO is control guest offloads is not >> enabled. This solves the warning but will still slow down the traffic. > IMO gro-hw fits pretty well, patch looks good. If the re-segmentation is not a issue. I will post a formal patch. Thanks > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-08-12 3:23 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-11 8:16 [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO Jason Wang 2021-08-11 8:16 ` Jason Wang 2021-08-11 22:17 ` Jakub Kicinski 2021-08-12 3:23 ` Jason Wang [this message] 2021-08-12 3:23 ` Jason Wang 2021-08-12 4:50 ` Michael S. Tsirkin 2021-08-12 4:50 ` Michael S. Tsirkin 2021-08-12 6:18 ` Jason Wang 2021-08-12 6:18 ` Jason Wang 2021-08-12 1:20 ` ivan 2021-08-12 4:59 ` Michael S. Tsirkin 2021-08-12 4:59 ` Michael S. Tsirkin 2021-08-12 6:28 ` ivan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=aa3e2aca-05a9-aed7-59ec-eb4bd32d8f76@redhat.com \ --to=jasowang@redhat.com \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=ivan@prestigetransportation.com \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=virtualization@lists.linux-foundation.org \ --cc=willemb@google.com \ --cc=xiangxia.m.yue@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.