All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Zhu via Linux-kernel-mentees <linux-kernel-mentees@lists.linuxfoundation.org>
To: Khalid Masum <khalid.masum.92@gmail.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Cc: "Wan Jiabing" <wanjiabing@vivo.com>,
	"David Airlie" <airlied@linux.ie>,
	"Pan Xinhui" <Xinhui.Pan@amd.com>,
	"Sonny Jiang" <sonny.jiang@amd.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Ruijing Dong" <ruijing.dong@amd.com>,
	"James Zhu" <James.Zhu@amd.com>, "Leo Liu" <leo.liu@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop
Date: Mon, 15 Aug 2022 10:07:05 -0400	[thread overview]
Message-ID: <aaad4922-48a8-e360-4176-d8ed30b123df@amd.com> (raw)
In-Reply-To: <20220815070056.10816-1-khalid.masum.92@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1022 bytes --]

ThispatchisReviewed-by:JamesZhu<James.Zhu@amd.com>

On 2022-08-15 3:00 a.m., Khalid Masum wrote:
> The value assigned from vcn_v4_0_stop_dbg_mode to r is overwritten
> before it can be used. Remove this assignment.
>
> Addresses-Coverity: 1504988 ("Unused value")
> Fixes: 8da1170a16e4 ("drm/amdgpu: add VCN4 ip block support")
> Signed-off-by: Khalid Masum<khalid.masum.92@gmail.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> index ca14c3ef742e..80b8a2c66b36 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> @@ -1154,7 +1154,7 @@ static int vcn_v4_0_stop(struct amdgpu_device *adev)
>   		fw_shared->sq.queue_mode |= FW_QUEUE_DPG_HOLD_OFF;
>   
>   		if (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG) {
> -			r = vcn_v4_0_stop_dpg_mode(adev, i);
> +			vcn_v4_0_stop_dpg_mode(adev, i);
>   			continue;
>   		}
>   

[-- Attachment #1.2: Type: text/html, Size: 1933 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: James Zhu <jamesz@amd.com>
To: Khalid Masum <khalid.masum.92@gmail.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Cc: "Wan Jiabing" <wanjiabing@vivo.com>,
	"David Airlie" <airlied@linux.ie>,
	"Pan Xinhui" <Xinhui.Pan@amd.com>,
	"Sonny Jiang" <sonny.jiang@amd.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Ruijing Dong" <ruijing.dong@amd.com>,
	"James Zhu" <James.Zhu@amd.com>, "Leo Liu" <leo.liu@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop
Date: Mon, 15 Aug 2022 10:07:05 -0400	[thread overview]
Message-ID: <aaad4922-48a8-e360-4176-d8ed30b123df@amd.com> (raw)
In-Reply-To: <20220815070056.10816-1-khalid.masum.92@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]

ThispatchisReviewed-by:JamesZhu<James.Zhu@amd.com>

On 2022-08-15 3:00 a.m., Khalid Masum wrote:
> The value assigned from vcn_v4_0_stop_dbg_mode to r is overwritten
> before it can be used. Remove this assignment.
>
> Addresses-Coverity: 1504988 ("Unused value")
> Fixes: 8da1170a16e4 ("drm/amdgpu: add VCN4 ip block support")
> Signed-off-by: Khalid Masum<khalid.masum.92@gmail.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> index ca14c3ef742e..80b8a2c66b36 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> @@ -1154,7 +1154,7 @@ static int vcn_v4_0_stop(struct amdgpu_device *adev)
>   		fw_shared->sq.queue_mode |= FW_QUEUE_DPG_HOLD_OFF;
>   
>   		if (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG) {
> -			r = vcn_v4_0_stop_dpg_mode(adev, i);
> +			vcn_v4_0_stop_dpg_mode(adev, i);
>   			continue;
>   		}
>   

[-- Attachment #2: Type: text/html, Size: 1933 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: James Zhu <jamesz@amd.com>
To: Khalid Masum <khalid.masum.92@gmail.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Cc: "Wan Jiabing" <wanjiabing@vivo.com>,
	"David Airlie" <airlied@linux.ie>,
	"Pan Xinhui" <Xinhui.Pan@amd.com>,
	"Sonny Jiang" <sonny.jiang@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Ruijing Dong" <ruijing.dong@amd.com>,
	"James Zhu" <James.Zhu@amd.com>, "Leo Liu" <leo.liu@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop
Date: Mon, 15 Aug 2022 10:07:05 -0400	[thread overview]
Message-ID: <aaad4922-48a8-e360-4176-d8ed30b123df@amd.com> (raw)
In-Reply-To: <20220815070056.10816-1-khalid.masum.92@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]

ThispatchisReviewed-by:JamesZhu<James.Zhu@amd.com>

On 2022-08-15 3:00 a.m., Khalid Masum wrote:
> The value assigned from vcn_v4_0_stop_dbg_mode to r is overwritten
> before it can be used. Remove this assignment.
>
> Addresses-Coverity: 1504988 ("Unused value")
> Fixes: 8da1170a16e4 ("drm/amdgpu: add VCN4 ip block support")
> Signed-off-by: Khalid Masum<khalid.masum.92@gmail.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> index ca14c3ef742e..80b8a2c66b36 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> @@ -1154,7 +1154,7 @@ static int vcn_v4_0_stop(struct amdgpu_device *adev)
>   		fw_shared->sq.queue_mode |= FW_QUEUE_DPG_HOLD_OFF;
>   
>   		if (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG) {
> -			r = vcn_v4_0_stop_dpg_mode(adev, i);
> +			vcn_v4_0_stop_dpg_mode(adev, i);
>   			continue;
>   		}
>   

[-- Attachment #2: Type: text/html, Size: 1933 bytes --]

  reply	other threads:[~2022-08-15 14:07 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15  7:00 [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop Khalid Masum
2022-08-15  7:00 ` Khalid Masum
2022-08-15  7:00 ` Khalid Masum
2022-08-15  7:00 ` Khalid Masum
2022-08-15 14:07 ` James Zhu via Linux-kernel-mentees [this message]
2022-08-15 14:07   ` James Zhu
2022-08-15 14:07   ` James Zhu
2022-08-15 14:15 ` Dong, Ruijing
2022-08-15 14:15   ` Dong, Ruijing
2022-08-15 14:15   ` Dong, Ruijing
2022-08-15 14:15   ` Dong, Ruijing via Linux-kernel-mentees
2022-08-15 15:11   ` Khalid Masum
2022-08-15 15:11     ` Khalid Masum
2022-08-15 15:11     ` Khalid Masum
2022-08-15 15:11     ` Khalid Masum
2022-08-15 15:17     ` Dong, Ruijing
2022-08-15 15:17       ` Dong, Ruijing
2022-08-15 15:17       ` Dong, Ruijing
2022-08-15 15:17       ` Dong, Ruijing via Linux-kernel-mentees
2022-08-15 15:53       ` Khalid Masum
2022-08-15 15:53         ` Khalid Masum
2022-08-15 15:53         ` Khalid Masum
2022-08-15 15:53         ` Khalid Masum
2022-08-15 16:00         ` Dong, Ruijing
2022-08-15 16:00           ` Dong, Ruijing
2022-08-15 16:00           ` Dong, Ruijing
2022-08-15 16:00           ` Dong, Ruijing via Linux-kernel-mentees
2022-08-15 18:32           ` Khalid Masum
2022-08-15 18:32             ` Khalid Masum
2022-08-15 18:32             ` Khalid Masum
2022-08-15 18:32             ` Khalid Masum
2022-08-15 16:12     ` Greg KH
2022-08-15 16:12       ` Greg KH
2022-08-15 16:12       ` Greg KH
2022-08-15 16:12       ` Greg KH
2022-08-15 17:01       ` Khalid Masum
2022-08-15 17:01         ` Khalid Masum
2022-08-15 17:01         ` Khalid Masum
2022-08-15 17:01         ` Khalid Masum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaad4922-48a8-e360-4176-d8ed30b123df@amd.com \
    --to=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=James.Zhu@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jamesz@amd.com \
    --cc=khalid.masum.92@gmail.com \
    --cc=leo.liu@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ruijing.dong@amd.com \
    --cc=sonny.jiang@amd.com \
    --cc=wanjiabing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.