All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khalid Masum <khalid.masum.92@gmail.com>
To: "Dong, Ruijing" <Ruijing.Dong@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kernel-mentees@lists.linuxfoundation.org" 
	<linux-kernel-mentees@lists.linuxfoundation.org>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	"Zhu, James" <James.Zhu@amd.com>,
	"Jiang, Sonny" <Sonny.Jiang@amd.com>,
	Wan Jiabing <wanjiabing@vivo.com>, "Liu, Leo" <Leo.Liu@amd.com>
Subject: Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop
Date: Mon, 15 Aug 2022 21:53:54 +0600	[thread overview]
Message-ID: <f8734af1-6e31-75c9-9556-9519709284f1@gmail.com> (raw)
In-Reply-To: <SJ1PR12MB6194C83D51101ACD97B55F0295689@SJ1PR12MB6194.namprd12.prod.outlook.com>

On 8/15/22 21:17, Dong, Ruijing wrote:
> [AMD Official Use Only - General]
> 
> If the condition was met and it came to execute vcn_4_0_stop_dpg_mode, then it would never have a chance to go for /*wait for vcn idle*/, isn't it?

Hypothetically, some other thread might set adev->pg_flags NULL and in 
that case it will get the chance to go for /* wait for vcn idle */.


> I still didn't see obvious purpose of this change.
> 
>                  if (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG) {
>       ==>              r = vcn_v4_0_stop_dpg_mode(adev, i);

Regardless of that, this assignment to r is unnecessary. Because this 
value of r is never used. This patch simply removes this unnecessary
assignment.

>                           continue;
>                   }
> 
>                   /* wait for vcn idle */
>                   r = SOC15_WAIT_ON_RREG(VCN, i, regUVD_STATUS, UVD_STATUS__IDLE, 0x7);
> 
> Thanks
> Ruijing
> 

Thanks,
   -- Khalid Masum

WARNING: multiple messages have this Message-ID (diff)
From: Khalid Masum <khalid.masum.92@gmail.com>
To: "Dong, Ruijing" <Ruijing.Dong@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kernel-mentees@lists.linuxfoundation.org"
	<linux-kernel-mentees@lists.linuxfoundation.org>
Cc: Wan Jiabing <wanjiabing@vivo.com>,
	David Airlie <airlied@linux.ie>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"Jiang, Sonny" <Sonny.Jiang@amd.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Zhu, James" <James.Zhu@amd.com>, "Liu, Leo" <Leo.Liu@amd.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop
Date: Mon, 15 Aug 2022 21:53:54 +0600	[thread overview]
Message-ID: <f8734af1-6e31-75c9-9556-9519709284f1@gmail.com> (raw)
In-Reply-To: <SJ1PR12MB6194C83D51101ACD97B55F0295689@SJ1PR12MB6194.namprd12.prod.outlook.com>

On 8/15/22 21:17, Dong, Ruijing wrote:
> [AMD Official Use Only - General]
> 
> If the condition was met and it came to execute vcn_4_0_stop_dpg_mode, then it would never have a chance to go for /*wait for vcn idle*/, isn't it?

Hypothetically, some other thread might set adev->pg_flags NULL and in 
that case it will get the chance to go for /* wait for vcn idle */.


> I still didn't see obvious purpose of this change.
> 
>                  if (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG) {
>       ==>              r = vcn_v4_0_stop_dpg_mode(adev, i);

Regardless of that, this assignment to r is unnecessary. Because this 
value of r is never used. This patch simply removes this unnecessary
assignment.

>                           continue;
>                   }
> 
>                   /* wait for vcn idle */
>                   r = SOC15_WAIT_ON_RREG(VCN, i, regUVD_STATUS, UVD_STATUS__IDLE, 0x7);
> 
> Thanks
> Ruijing
> 

Thanks,
   -- Khalid Masum
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: Khalid Masum <khalid.masum.92@gmail.com>
To: "Dong, Ruijing" <Ruijing.Dong@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kernel-mentees@lists.linuxfoundation.org"
	<linux-kernel-mentees@lists.linuxfoundation.org>
Cc: Wan Jiabing <wanjiabing@vivo.com>,
	David Airlie <airlied@linux.ie>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"Jiang, Sonny" <Sonny.Jiang@amd.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Zhu, James" <James.Zhu@amd.com>, "Liu, Leo" <Leo.Liu@amd.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop
Date: Mon, 15 Aug 2022 21:53:54 +0600	[thread overview]
Message-ID: <f8734af1-6e31-75c9-9556-9519709284f1@gmail.com> (raw)
In-Reply-To: <SJ1PR12MB6194C83D51101ACD97B55F0295689@SJ1PR12MB6194.namprd12.prod.outlook.com>

On 8/15/22 21:17, Dong, Ruijing wrote:
> [AMD Official Use Only - General]
> 
> If the condition was met and it came to execute vcn_4_0_stop_dpg_mode, then it would never have a chance to go for /*wait for vcn idle*/, isn't it?

Hypothetically, some other thread might set adev->pg_flags NULL and in 
that case it will get the chance to go for /* wait for vcn idle */.


> I still didn't see obvious purpose of this change.
> 
>                  if (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG) {
>       ==>              r = vcn_v4_0_stop_dpg_mode(adev, i);

Regardless of that, this assignment to r is unnecessary. Because this 
value of r is never used. This patch simply removes this unnecessary
assignment.

>                           continue;
>                   }
> 
>                   /* wait for vcn idle */
>                   r = SOC15_WAIT_ON_RREG(VCN, i, regUVD_STATUS, UVD_STATUS__IDLE, 0x7);
> 
> Thanks
> Ruijing
> 

Thanks,
   -- Khalid Masum

WARNING: multiple messages have this Message-ID (diff)
From: Khalid Masum <khalid.masum.92@gmail.com>
To: "Dong, Ruijing" <Ruijing.Dong@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kernel-mentees@lists.linuxfoundation.org"
	<linux-kernel-mentees@lists.linuxfoundation.org>
Cc: Wan Jiabing <wanjiabing@vivo.com>,
	David Airlie <airlied@linux.ie>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"Jiang, Sonny" <Sonny.Jiang@amd.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Zhu, James" <James.Zhu@amd.com>, "Liu, Leo" <Leo.Liu@amd.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop
Date: Mon, 15 Aug 2022 21:53:54 +0600	[thread overview]
Message-ID: <f8734af1-6e31-75c9-9556-9519709284f1@gmail.com> (raw)
In-Reply-To: <SJ1PR12MB6194C83D51101ACD97B55F0295689@SJ1PR12MB6194.namprd12.prod.outlook.com>

On 8/15/22 21:17, Dong, Ruijing wrote:
> [AMD Official Use Only - General]
> 
> If the condition was met and it came to execute vcn_4_0_stop_dpg_mode, then it would never have a chance to go for /*wait for vcn idle*/, isn't it?

Hypothetically, some other thread might set adev->pg_flags NULL and in 
that case it will get the chance to go for /* wait for vcn idle */.


> I still didn't see obvious purpose of this change.
> 
>                  if (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG) {
>       ==>              r = vcn_v4_0_stop_dpg_mode(adev, i);

Regardless of that, this assignment to r is unnecessary. Because this 
value of r is never used. This patch simply removes this unnecessary
assignment.

>                           continue;
>                   }
> 
>                   /* wait for vcn idle */
>                   r = SOC15_WAIT_ON_RREG(VCN, i, regUVD_STATUS, UVD_STATUS__IDLE, 0x7);
> 
> Thanks
> Ruijing
> 

Thanks,
   -- Khalid Masum

  reply	other threads:[~2022-08-15 15:54 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15  7:00 [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop Khalid Masum
2022-08-15  7:00 ` Khalid Masum
2022-08-15  7:00 ` Khalid Masum
2022-08-15  7:00 ` Khalid Masum
2022-08-15 14:07 ` James Zhu via Linux-kernel-mentees
2022-08-15 14:07   ` James Zhu
2022-08-15 14:07   ` James Zhu
2022-08-15 14:15 ` Dong, Ruijing
2022-08-15 14:15   ` Dong, Ruijing
2022-08-15 14:15   ` Dong, Ruijing
2022-08-15 14:15   ` Dong, Ruijing via Linux-kernel-mentees
2022-08-15 15:11   ` Khalid Masum
2022-08-15 15:11     ` Khalid Masum
2022-08-15 15:11     ` Khalid Masum
2022-08-15 15:11     ` Khalid Masum
2022-08-15 15:17     ` Dong, Ruijing
2022-08-15 15:17       ` Dong, Ruijing
2022-08-15 15:17       ` Dong, Ruijing
2022-08-15 15:17       ` Dong, Ruijing via Linux-kernel-mentees
2022-08-15 15:53       ` Khalid Masum [this message]
2022-08-15 15:53         ` Khalid Masum
2022-08-15 15:53         ` Khalid Masum
2022-08-15 15:53         ` Khalid Masum
2022-08-15 16:00         ` Dong, Ruijing
2022-08-15 16:00           ` Dong, Ruijing
2022-08-15 16:00           ` Dong, Ruijing
2022-08-15 16:00           ` Dong, Ruijing via Linux-kernel-mentees
2022-08-15 18:32           ` Khalid Masum
2022-08-15 18:32             ` Khalid Masum
2022-08-15 18:32             ` Khalid Masum
2022-08-15 18:32             ` Khalid Masum
2022-08-15 16:12     ` Greg KH
2022-08-15 16:12       ` Greg KH
2022-08-15 16:12       ` Greg KH
2022-08-15 16:12       ` Greg KH
2022-08-15 17:01       ` Khalid Masum
2022-08-15 17:01         ` Khalid Masum
2022-08-15 17:01         ` Khalid Masum
2022-08-15 17:01         ` Khalid Masum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8734af1-6e31-75c9-9556-9519709284f1@gmail.com \
    --to=khalid.masum.92@gmail.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=James.Zhu@amd.com \
    --cc=Leo.Liu@amd.com \
    --cc=Ruijing.Dong@amd.com \
    --cc=Sonny.Jiang@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wanjiabing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.