* [PATCH] ALSA: usb-audio: add the profile name of Dell desktop
@ 2021-11-11 9:19 shumingf
2021-11-11 9:23 ` Takashi Iwai
2021-11-11 9:34 ` Jaroslav Kysela
0 siblings, 2 replies; 9+ messages in thread
From: shumingf @ 2021-11-11 9:19 UTC (permalink / raw)
To: broonie, tiwai, lgirdwood
Cc: oder_chiou, jack.yu, alsa-devel, lars, derek.fang, Shuming Fan,
Yijun.Shen, flove
From: Shuming Fan <shumingf@realtek.com>
Add the profile name to let userspace pick correct UCM profile
Signed-off-by: Shuming Fan <shumingf@realtek.com>
---
sound/usb/card.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/usb/card.c b/sound/usb/card.c
index 1764b9302d46..9c67ecbe710e 100644
--- a/sound/usb/card.c
+++ b/sound/usb/card.c
@@ -398,6 +398,10 @@ static const struct usb_audio_device_name usb_audio_names[] = {
PROFILE_NAME(0x0bda, 0x4014, "Dell", "WD15 Dock", "Dell-WD15-Dock"),
/* Dell WD19 Dock */
PROFILE_NAME(0x0bda, 0x402e, "Dell", "WD19 Dock", "Dell-WD15-Dock"),
+ /* Dell Desktop - Front */
+ PROFILE_NAME(0x0bda, 0x4c54, "Dell", "Desktop", "Dell-Desktop-Front"),
+ /* Dell Desktop - Rear */
+ PROFILE_NAME(0x0bda, 0x4c55, "Dell", "Desktop", "Dell-Desktop-Rear"),
DEVICE_NAME(0x0ccd, 0x0028, "TerraTec", "Aureon5.1MkII"),
--
2.33.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: usb-audio: add the profile name of Dell desktop
2021-11-11 9:19 [PATCH] ALSA: usb-audio: add the profile name of Dell desktop shumingf
@ 2021-11-11 9:23 ` Takashi Iwai
2021-11-11 9:34 ` Jaroslav Kysela
1 sibling, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2021-11-11 9:23 UTC (permalink / raw)
To: shumingf
Cc: oder_chiou, jack.yu, alsa-devel, lars, lgirdwood, broonie,
derek.fang, Yijun.Shen, flove
On Thu, 11 Nov 2021 10:19:14 +0100,
<shumingf@realtek.com> wrote:
>
> From: Shuming Fan <shumingf@realtek.com>
>
> Add the profile name to let userspace pick correct UCM profile
Was the corresponding change for alsa-ucm-conf submitted to upstream?
> Signed-off-by: Shuming Fan <shumingf@realtek.com>
> ---
> sound/usb/card.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/usb/card.c b/sound/usb/card.c
> index 1764b9302d46..9c67ecbe710e 100644
> --- a/sound/usb/card.c
> +++ b/sound/usb/card.c
> @@ -398,6 +398,10 @@ static const struct usb_audio_device_name usb_audio_names[] = {
> PROFILE_NAME(0x0bda, 0x4014, "Dell", "WD15 Dock", "Dell-WD15-Dock"),
> /* Dell WD19 Dock */
> PROFILE_NAME(0x0bda, 0x402e, "Dell", "WD19 Dock", "Dell-WD15-Dock"),
> + /* Dell Desktop - Front */
> + PROFILE_NAME(0x0bda, 0x4c54, "Dell", "Desktop", "Dell-Desktop-Front"),
> + /* Dell Desktop - Rear */
> + PROFILE_NAME(0x0bda, 0x4c55, "Dell", "Desktop", "Dell-Desktop-Rear"),
IMO, the profile name sounds too generic. It's better to have with
some model name at least so that it can be identified more uniquely.
thanks,
Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: usb-audio: add the profile name of Dell desktop
2021-11-11 9:19 [PATCH] ALSA: usb-audio: add the profile name of Dell desktop shumingf
2021-11-11 9:23 ` Takashi Iwai
@ 2021-11-11 9:34 ` Jaroslav Kysela
2021-11-11 9:55 ` Jaroslav Kysela
2021-11-11 10:13 ` Takashi Iwai
1 sibling, 2 replies; 9+ messages in thread
From: Jaroslav Kysela @ 2021-11-11 9:34 UTC (permalink / raw)
To: shumingf, broonie, tiwai, lgirdwood
Cc: oder_chiou, jack.yu, alsa-devel, lars, derek.fang, Yijun.Shen, flove
On 11. 11. 21 10:19, shumingf@realtek.com wrote:
> From: Shuming Fan <shumingf@realtek.com>
>
> Add the profile name to let userspace pick correct UCM profile
It's no longer necessary to force the card names in the drivers. UCM can match
the USB vendor / device IDs from the 'components' string, too.
I think that we should abandon this way of the UCM configuration selection for
new devices with device IDs. The kernel already exports necessary information
to select the right UCM configuration in the user space.
Jaroslav
>
> Signed-off-by: Shuming Fan <shumingf@realtek.com>
> ---
> sound/usb/card.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/usb/card.c b/sound/usb/card.c
> index 1764b9302d46..9c67ecbe710e 100644
> --- a/sound/usb/card.c
> +++ b/sound/usb/card.c
> @@ -398,6 +398,10 @@ static const struct usb_audio_device_name usb_audio_names[] = {
> PROFILE_NAME(0x0bda, 0x4014, "Dell", "WD15 Dock", "Dell-WD15-Dock"),
> /* Dell WD19 Dock */
> PROFILE_NAME(0x0bda, 0x402e, "Dell", "WD19 Dock", "Dell-WD15-Dock"),
> + /* Dell Desktop - Front */
> + PROFILE_NAME(0x0bda, 0x4c54, "Dell", "Desktop", "Dell-Desktop-Front"),
> + /* Dell Desktop - Rear */
> + PROFILE_NAME(0x0bda, 0x4c55, "Dell", "Desktop", "Dell-Desktop-Rear"),
>
> DEVICE_NAME(0x0ccd, 0x0028, "TerraTec", "Aureon5.1MkII"),
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: usb-audio: add the profile name of Dell desktop
2021-11-11 9:34 ` Jaroslav Kysela
@ 2021-11-11 9:55 ` Jaroslav Kysela
2021-11-11 9:58 ` Shuming [范書銘]
2021-11-11 10:40 ` Shuming [范書銘]
2021-11-11 10:13 ` Takashi Iwai
1 sibling, 2 replies; 9+ messages in thread
From: Jaroslav Kysela @ 2021-11-11 9:55 UTC (permalink / raw)
To: shumingf, broonie, tiwai, lgirdwood
Cc: oder_chiou, jack.yu, alsa-devel, lars, derek.fang, Yijun.Shen, flove
On 11. 11. 21 10:34, Jaroslav Kysela wrote:
> On 11. 11. 21 10:19, shumingf@realtek.com wrote:
>> From: Shuming Fan <shumingf@realtek.com>
>>
>> Add the profile name to let userspace pick correct UCM profile
>
> It's no longer necessary to force the card names in the drivers. UCM can match
> the USB vendor / device IDs from the 'components' string, too.
>
> I think that we should abandon this way of the UCM configuration selection for
> new devices with device IDs. The kernel already exports necessary information
> to select the right UCM configuration in the user space.
Untested example:
https://github.com/perexg/alsa-ucm-conf/commit/74ced65440b5011bbec1680b2804c8a9c82b5152
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] ALSA: usb-audio: add the profile name of Dell desktop
2021-11-11 9:55 ` Jaroslav Kysela
@ 2021-11-11 9:58 ` Shuming [范書銘]
2021-11-11 10:40 ` Shuming [范書銘]
1 sibling, 0 replies; 9+ messages in thread
From: Shuming [范書銘] @ 2021-11-11 9:58 UTC (permalink / raw)
To: Jaroslav Kysela, broonie, tiwai, lgirdwood
Cc: Oder Chiou, Jack Yu, alsa-devel, lars,
Derek [方德義], Yijun.Shen, Flove(HsinFu)
Hi Jaroslav,
> On 11. 11. 21 10:34, Jaroslav Kysela wrote:
> > On 11. 11. 21 10:19, shumingf@realtek.com wrote:
> >> From: Shuming Fan <shumingf@realtek.com>
> >>
> >> Add the profile name to let userspace pick correct UCM profile
> >
> > It's no longer necessary to force the card names in the drivers. UCM
> > can match the USB vendor / device IDs from the 'components' string, too.
> >
> > I think that we should abandon this way of the UCM configuration
> > selection for new devices with device IDs. The kernel already exports
> > necessary information to select the right UCM configuration in the user
> space.
>
> Untested example:
>
> https://github.com/perexg/alsa-ucm-conf/commit/74ced65440b5011bbec1680
> b2804c8a9c82b5152
>
> Jaroslav
Thanks a lot. I will take your example to test.
> --
> Jaroslav Kysela <perex@perex.cz>
> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: usb-audio: add the profile name of Dell desktop
2021-11-11 9:34 ` Jaroslav Kysela
2021-11-11 9:55 ` Jaroslav Kysela
@ 2021-11-11 10:13 ` Takashi Iwai
1 sibling, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2021-11-11 10:13 UTC (permalink / raw)
To: Jaroslav Kysela
Cc: oder_chiou, jack.yu, alsa-devel, lars, lgirdwood, broonie,
derek.fang, shumingf, Yijun.Shen, flove
On Thu, 11 Nov 2021 10:34:52 +0100,
Jaroslav Kysela wrote:
>
> On 11. 11. 21 10:19, shumingf@realtek.com wrote:
> > From: Shuming Fan <shumingf@realtek.com>
> >
> > Add the profile name to let userspace pick correct UCM profile
>
> It's no longer necessary to force the card names in the drivers. UCM
> can match the USB vendor / device IDs from the 'components' string,
> too.
>
> I think that we should abandon this way of the UCM configuration
> selection for new devices with device IDs. The kernel already exports
> necessary information to select the right UCM configuration in the
> user space.
Sounds reasonable. Less changes in kernel, better :)
Thanks!
Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] ALSA: usb-audio: add the profile name of Dell desktop
2021-11-11 9:55 ` Jaroslav Kysela
2021-11-11 9:58 ` Shuming [范書銘]
@ 2021-11-11 10:40 ` Shuming [范書銘]
2021-11-11 10:44 ` Hui Wang
1 sibling, 1 reply; 9+ messages in thread
From: Shuming [范書銘] @ 2021-11-11 10:40 UTC (permalink / raw)
To: Jaroslav Kysela, broonie, tiwai, lgirdwood
Cc: Oder Chiou, Jack Yu, alsa-devel, lars, Hui Wang,
Derek [方德義], Yijun.Shen, Flove(HsinFu)
Hi Jaroslav,
> > >> Add the profile name to let userspace pick correct UCM profile
> > >
> > > It's no longer necessary to force the card names in the drivers. UCM
> > > can match the USB vendor / device IDs from the 'components' string, too.
> > >
> > > I think that we should abandon this way of the UCM configuration
> > > selection for new devices with device IDs. The kernel already
> > > exports necessary information to select the right UCM configuration
> > > in the user
> > space.
> >
> > Untested example:
> >
> >
> https://github.com/perexg/alsa-ucm-conf/commit/74ced65440b5011bbec1680
> > b2804c8a9c82b5152
> >
> > Jaroslav
>
> Thanks a lot. I will take your example to test.
I had tested with USB-Audio.conf that the system seems not to apply the UCM config.
The related info of the test machine shows below.
root@Latitude-5410:/usr/share/alsa/ucm2/USB-Audio# cat /proc/asound/cards
0 [PCH ]: HDA-Intel - HDA Intel PCH
HDA Intel PCH at 0xcc338000 irq 153
1 [Rear ]: USB-Audio - USB audio Rear
Generic USB audio Rear at usb-0000:00:14.0-2.2, high speed
2 [FRONT ]: USB-Audio - USB audio FRONT
Generic USB audio FRONT at usb-0000:00:14.0-2.1, high speed
root@Latitude-5410:/usr/share/alsa/ucm2/USB-Audio# alsaucm --version
alsaucm: version 1.2.2
root@Latitude-5410:/usr/share/alsa/ucm2/USB-Audio# lsusb
Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 002 Device 002: ID 8564:4000 Transcend Information, Inc. RDF8
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 003: ID 0a5c:5842 Broadcom Corp. 58200
Bus 001 Device 002: ID 0bda:5532 Realtek Semiconductor Corp. Integrated_Webcam_HD
Bus 001 Device 008: ID 04f3:0235 Elan Microelectronics Corp. Optical Mouse
Bus 001 Device 007: ID 1c4f:0002 SiGma Micro Keyboard TRACER Gamma Ivory
Bus 001 Device 006: ID 0bda:4c55 Realtek Semiconductor Corp. USB2.0 Hub
Bus 001 Device 009: ID 0bda:4c54 Realtek Semiconductor Corp.
May I ask you to give me some suggestions?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: usb-audio: add the profile name of Dell desktop
2021-11-11 10:40 ` Shuming [范書銘]
@ 2021-11-11 10:44 ` Hui Wang
2021-11-11 11:20 ` Jaroslav Kysela
0 siblings, 1 reply; 9+ messages in thread
From: Hui Wang @ 2021-11-11 10:44 UTC (permalink / raw)
To: Shuming [范書銘],
Jaroslav Kysela, broonie, tiwai, lgirdwood
Cc: Oder Chiou, Jack Yu, alsa-devel, lars,
Derek [方德義], Yijun.Shen, Flove(HsinFu)
On 11/11/21 6:40 PM, Shuming [范書銘] wrote:
> Hi Jaroslav,
>
>>>>> Add the profile name to let userspace pick correct UCM profile
>>>> It's no longer necessary to force the card names in the drivers. UCM
>>>> can match the USB vendor / device IDs from the 'components' string, too.
>>>>
>>>> I think that we should abandon this way of the UCM configuration
>>>> selection for new devices with device IDs. The kernel already
>>>> exports necessary information to select the right UCM configuration
>>>> in the user
>>> space.
>>>
>>> Untested example:
>>>
>>>
>> https://github.com/perexg/alsa-ucm-conf/commit/74ced65440b5011bbec1680
>>> b2804c8a9c82b5152
>>>
>>> Jaroslav
>> Thanks a lot. I will take your example to test.
> I had tested with USB-Audio.conf that the system seems not to apply the UCM config.
>
> The related info of the test machine shows below.
> root@Latitude-5410:/usr/share/alsa/ucm2/USB-Audio# cat /proc/asound/cards
> 0 [PCH ]: HDA-Intel - HDA Intel PCH
> HDA Intel PCH at 0xcc338000 irq 153
> 1 [Rear ]: USB-Audio - USB audio Rear
> Generic USB audio Rear at usb-0000:00:14.0-2.2, high speed
> 2 [FRONT ]: USB-Audio - USB audio FRONT
> Generic USB audio FRONT at usb-0000:00:14.0-2.1, high speed
>
> root@Latitude-5410:/usr/share/alsa/ucm2/USB-Audio# alsaucm --version
> alsaucm: version 1.2.2
>
> root@Latitude-5410:/usr/share/alsa/ucm2/USB-Audio# lsusb
> Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
> Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> Bus 002 Device 002: ID 8564:4000 Transcend Information, Inc. RDF8
> Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
> Bus 001 Device 003: ID 0a5c:5842 Broadcom Corp. 58200
> Bus 001 Device 002: ID 0bda:5532 Realtek Semiconductor Corp. Integrated_Webcam_HD
> Bus 001 Device 008: ID 04f3:0235 Elan Microelectronics Corp. Optical Mouse
> Bus 001 Device 007: ID 1c4f:0002 SiGma Micro Keyboard TRACER Gamma Ivory
> Bus 001 Device 006: ID 0bda:4c55 Realtek Semiconductor Corp. USB2.0 Hub
> Bus 001 Device 009: ID 0bda:4c54 Realtek Semiconductor Corp.
>
> May I ask you to give me some suggestions?
Looks like the alsa-lib in the ubuntu 20.04 doesn't support it.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ALSA: usb-audio: add the profile name of Dell desktop
2021-11-11 10:44 ` Hui Wang
@ 2021-11-11 11:20 ` Jaroslav Kysela
0 siblings, 0 replies; 9+ messages in thread
From: Jaroslav Kysela @ 2021-11-11 11:20 UTC (permalink / raw)
To: Hui Wang, Shuming [范書銘], broonie, tiwai, lgirdwood
Cc: Oder Chiou, Jack Yu, alsa-devel, lars,
Derek [方德義], Yijun.Shen, Flove(HsinFu)
On 11. 11. 21 11:44, Hui Wang wrote:
>
> On 11/11/21 6:40 PM, Shuming [范書銘] wrote:
>> Hi Jaroslav,
>>
>>>>>> Add the profile name to let userspace pick correct UCM profile
>>>>> It's no longer necessary to force the card names in the drivers. UCM
>>>>> can match the USB vendor / device IDs from the 'components' string, too.
>>>>>
>>>>> I think that we should abandon this way of the UCM configuration
>>>>> selection for new devices with device IDs. The kernel already
>>>>> exports necessary information to select the right UCM configuration
>>>>> in the user
>>>> space.
>>>>
>>>> Untested example:
>>>>
>>>>
>>> https://github.com/perexg/alsa-ucm-conf/commit/74ced65440b5011bbec1680
>>>> b2804c8a9c82b5152
>>>>
>>>> Jaroslav
>>> Thanks a lot. I will take your example to test.
>> I had tested with USB-Audio.conf that the system seems not to apply the UCM config.
>>
>> The related info of the test machine shows below.
>> root@Latitude-5410:/usr/share/alsa/ucm2/USB-Audio# cat /proc/asound/cards
>> 0 [PCH ]: HDA-Intel - HDA Intel PCH
>> HDA Intel PCH at 0xcc338000 irq 153
>> 1 [Rear ]: USB-Audio - USB audio Rear
>> Generic USB audio Rear at usb-0000:00:14.0-2.2, high speed
>> 2 [FRONT ]: USB-Audio - USB audio FRONT
>> Generic USB audio FRONT at usb-0000:00:14.0-2.1, high speed
>>
>> root@Latitude-5410:/usr/share/alsa/ucm2/USB-Audio# alsaucm --version
>> alsaucm: version 1.2.2
>>
>> root@Latitude-5410:/usr/share/alsa/ucm2/USB-Audio# lsusb
>> Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
>> Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
>> Bus 002 Device 002: ID 8564:4000 Transcend Information, Inc. RDF8
>> Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
>> Bus 001 Device 003: ID 0a5c:5842 Broadcom Corp. 58200
>> Bus 001 Device 002: ID 0bda:5532 Realtek Semiconductor Corp. Integrated_Webcam_HD
>> Bus 001 Device 008: ID 04f3:0235 Elan Microelectronics Corp. Optical Mouse
>> Bus 001 Device 007: ID 1c4f:0002 SiGma Micro Keyboard TRACER Gamma Ivory
>> Bus 001 Device 006: ID 0bda:4c55 Realtek Semiconductor Corp. USB2.0 Hub
>> Bus 001 Device 009: ID 0bda:4c54 Realtek Semiconductor Corp.
>>
>> May I ask you to give me some suggestions?
> Looks like the alsa-lib in the ubuntu 20.04 doesn't support it.
I cannot comment specific distribution packages. It seems that alsa-lib-1.2.2
in Ubuntu has many later UCM upstream changes, but I cannot verify, if it's
enough for this file. I would recommend to use upstream alsa-lib and
alsa-ucm-conf 1.2.5 or later (from the repository) for tests.
Also, please, create an issue or pull request on github for this problem:
https://github.com/alsa-project/alsa-ucm-conf/issues
We can resolve it there.
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-11-11 11:22 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 9:19 [PATCH] ALSA: usb-audio: add the profile name of Dell desktop shumingf
2021-11-11 9:23 ` Takashi Iwai
2021-11-11 9:34 ` Jaroslav Kysela
2021-11-11 9:55 ` Jaroslav Kysela
2021-11-11 9:58 ` Shuming [范書銘]
2021-11-11 10:40 ` Shuming [范書銘]
2021-11-11 10:44 ` Hui Wang
2021-11-11 11:20 ` Jaroslav Kysela
2021-11-11 10:13 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.