* [PATCH] pci: ptm: remove error message at boot
@ 2021-08-11 18:59 Jakub Kicinski
2021-08-11 22:29 ` David E. Box
2021-08-20 21:10 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-08-11 18:59 UTC (permalink / raw)
To: bhelgaas; +Cc: david.e.box, linux-pci, rafael.j.wysocki, Jakub Kicinski
Since commit 39850ed51062 ("PCI/PTM: Save/restore Precision
Time Measurement Capability for suspend/resume") devices
which have PTM capability but don't enable it see this
message on calls to pci_save_state():
"no suspend buffer for PTM"
Drop the message, it's perfectly fine not to use a capability.
Fixes: 39850ed51062 ("PCI/PTM: Save/restore Precision Time Measurement Capability for suspend/resume")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
drivers/pci/pcie/ptm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pci/pcie/ptm.c b/drivers/pci/pcie/ptm.c
index 95d4eef2c9e8..4810faa67f52 100644
--- a/drivers/pci/pcie/ptm.c
+++ b/drivers/pci/pcie/ptm.c
@@ -60,10 +60,8 @@ void pci_save_ptm_state(struct pci_dev *dev)
return;
save_state = pci_find_saved_ext_cap(dev, PCI_EXT_CAP_ID_PTM);
- if (!save_state) {
- pci_err(dev, "no suspend buffer for PTM\n");
+ if (!save_state)
return;
- }
cap = (u16 *)&save_state->cap.data[0];
pci_read_config_word(dev, ptm + PCI_PTM_CTRL, cap);
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pci: ptm: remove error message at boot
2021-08-11 18:59 [PATCH] pci: ptm: remove error message at boot Jakub Kicinski
@ 2021-08-11 22:29 ` David E. Box
2021-08-20 21:10 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: David E. Box @ 2021-08-11 22:29 UTC (permalink / raw)
To: Jakub Kicinski, bhelgaas; +Cc: linux-pci, rafael.j.wysocki
On Wed, 2021-08-11 at 11:59 -0700, Jakub Kicinski wrote:
> Since commit 39850ed51062 ("PCI/PTM: Save/restore Precision
> Time Measurement Capability for suspend/resume") devices
> which have PTM capability but don't enable it see this
> message on calls to pci_save_state():
>
> "no suspend buffer for PTM"
>
> Drop the message, it's perfectly fine not to use a capability.
Ack. Thanks.
>
> Fixes: 39850ed51062 ("PCI/PTM: Save/restore Precision Time
> Measurement Capability for suspend/resume")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> drivers/pci/pcie/ptm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/pcie/ptm.c b/drivers/pci/pcie/ptm.c
> index 95d4eef2c9e8..4810faa67f52 100644
> --- a/drivers/pci/pcie/ptm.c
> +++ b/drivers/pci/pcie/ptm.c
> @@ -60,10 +60,8 @@ void pci_save_ptm_state(struct pci_dev *dev)
> return;
>
> save_state = pci_find_saved_ext_cap(dev, PCI_EXT_CAP_ID_PTM);
> - if (!save_state) {
> - pci_err(dev, "no suspend buffer for PTM\n");
> + if (!save_state)
> return;
> - }
>
> cap = (u16 *)&save_state->cap.data[0];
> pci_read_config_word(dev, ptm + PCI_PTM_CTRL, cap);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pci: ptm: remove error message at boot
2021-08-11 18:59 [PATCH] pci: ptm: remove error message at boot Jakub Kicinski
2021-08-11 22:29 ` David E. Box
@ 2021-08-20 21:10 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2021-08-20 21:10 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: bhelgaas, david.e.box, linux-pci, rafael.j.wysocki
On Wed, Aug 11, 2021 at 11:59:55AM -0700, Jakub Kicinski wrote:
> Since commit 39850ed51062 ("PCI/PTM: Save/restore Precision
> Time Measurement Capability for suspend/resume") devices
> which have PTM capability but don't enable it see this
> message on calls to pci_save_state():
>
> "no suspend buffer for PTM"
>
> Drop the message, it's perfectly fine not to use a capability.
>
> Fixes: 39850ed51062 ("PCI/PTM: Save/restore Precision Time Measurement Capability for suspend/resume")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Applied to pci/misc for v5.15, thanks!
I fixed your subject line to match previous ones and converted David's
informal ack to an actual "Acked-by".
> ---
> drivers/pci/pcie/ptm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/pcie/ptm.c b/drivers/pci/pcie/ptm.c
> index 95d4eef2c9e8..4810faa67f52 100644
> --- a/drivers/pci/pcie/ptm.c
> +++ b/drivers/pci/pcie/ptm.c
> @@ -60,10 +60,8 @@ void pci_save_ptm_state(struct pci_dev *dev)
> return;
>
> save_state = pci_find_saved_ext_cap(dev, PCI_EXT_CAP_ID_PTM);
> - if (!save_state) {
> - pci_err(dev, "no suspend buffer for PTM\n");
> + if (!save_state)
> return;
> - }
>
> cap = (u16 *)&save_state->cap.data[0];
> pci_read_config_word(dev, ptm + PCI_PTM_CTRL, cap);
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-20 21:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-11 18:59 [PATCH] pci: ptm: remove error message at boot Jakub Kicinski
2021-08-11 22:29 ` David E. Box
2021-08-20 21:10 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.