All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] vhost-vdpa: don't initialize backend_features
@ 2021-06-02  3:31 Jason Wang
  2021-06-02  3:31 ` [PATCH 2/2] vhost-vdpa: remove the unused vhost_vdpa_get_acked_features() Jason Wang
  2021-06-02  7:38 ` [PATCH 1/2] vhost-vdpa: don't initialize backend_features Gautam Dawar
  0 siblings, 2 replies; 8+ messages in thread
From: Jason Wang @ 2021-06-02  3:31 UTC (permalink / raw)
  To: mst, qemu-devel; +Cc: Jason Wang, lulu, gdawar, qemu-stable

We used to initialize backend_features during vhost_vdpa_init()
regardless whether or not it was supported by vhost. This will lead
the unsupported features like VIRTIO_F_IN_ORDER to be included and set
to the vhost-vdpa during vhost_dev_start. Because the
VIRTIO_F_IN_ORDER is not supported by vhost-vdpa so it won't be
advertised to guest which will break the datapath.

Fix this by not initializing the backend_features, so the
acked_features could be built only from guest features via
vhost_net_ack_features().

Fixes: 108a64818e69b ("vhost-vdpa: introduce vhost-vdpa backend")
Cc: qemu-stable@nongnu.org
Cc: Gautam Dawar <gdawar@xilinx.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 hw/virtio/vhost-vdpa.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 01d2101d09..5fe43a4eb5 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -275,15 +275,12 @@ static void vhost_vdpa_add_status(struct vhost_dev *dev, uint8_t status)
 static int vhost_vdpa_init(struct vhost_dev *dev, void *opaque)
 {
     struct vhost_vdpa *v;
-    uint64_t features;
     assert(dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_VDPA);
     trace_vhost_vdpa_init(dev, opaque);
 
     v = opaque;
     v->dev = dev;
     dev->opaque =  opaque ;
-    vhost_vdpa_call(dev, VHOST_GET_FEATURES, &features);
-    dev->backend_features = features;
     v->listener = vhost_vdpa_memory_listener;
     v->msg_type = VHOST_IOTLB_MSG_V2;
 
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-06-08  2:36 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02  3:31 [PATCH 1/2] vhost-vdpa: don't initialize backend_features Jason Wang
2021-06-02  3:31 ` [PATCH 2/2] vhost-vdpa: remove the unused vhost_vdpa_get_acked_features() Jason Wang
2021-06-05 17:19   ` Gautam Dawar
2021-06-08  2:36     ` Jason Wang
2021-06-02  7:38 ` [PATCH 1/2] vhost-vdpa: don't initialize backend_features Gautam Dawar
2021-06-02  8:48   ` Jason Wang
2021-06-04  9:10     ` Gautam Dawar
2021-06-08  2:34       ` Jason Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.