All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel List <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Hugh Dickins <hughd@google.com>,
	Andi Kleen <andi@firstfloor.org>, Mel Gorman <mel@csn.ul.ie>
Subject: Re: [PATCH] compaction: fix COMPACTPAGEFAILED counting
Date: Mon, 23 Aug 2010 12:17:31 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1008231217100.9840@router.home> (raw)
In-Reply-To: <20100823170610.GB2304@barrios-desktop>

On Tue, 24 Aug 2010, Minchan Kim wrote:

> On Mon, Aug 23, 2010 at 11:41:49AM -0500, Christoph Lameter wrote:
> > On Tue, 24 Aug 2010, Minchan Kim wrote
> >
> > > This patch introude new argument 'cleanup' to migrate_pages.
> > > Only if we set 1 to 'cleanup', migrate_page will clean up the lists.
> > > Otherwise, caller need to clean up the lists so it has a chance to postprocess
> > > the pages.
> >
> > Could we simply make migrate_pages simply not do any cleanup?
> > Caller has to call putback_lru_pages()?
> >
> Hmm. maybe I misunderstood your point.
> Your point is that let's make whole caller of migrate_pagse has a responsibility
> of clean up the list?

Yes. All callers would be responsible for cleanup.



WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel List <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Hugh Dickins <hughd@google.com>,
	Andi Kleen <andi@firstfloor.org>, Mel Gorman <mel@csn.ul.ie>
Subject: Re: [PATCH] compaction: fix COMPACTPAGEFAILED counting
Date: Mon, 23 Aug 2010 12:17:31 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1008231217100.9840@router.home> (raw)
In-Reply-To: <20100823170610.GB2304@barrios-desktop>

On Tue, 24 Aug 2010, Minchan Kim wrote:

> On Mon, Aug 23, 2010 at 11:41:49AM -0500, Christoph Lameter wrote:
> > On Tue, 24 Aug 2010, Minchan Kim wrote
> >
> > > This patch introude new argument 'cleanup' to migrate_pages.
> > > Only if we set 1 to 'cleanup', migrate_page will clean up the lists.
> > > Otherwise, caller need to clean up the lists so it has a chance to postprocess
> > > the pages.
> >
> > Could we simply make migrate_pages simply not do any cleanup?
> > Caller has to call putback_lru_pages()?
> >
> Hmm. maybe I misunderstood your point.
> Your point is that let's make whole caller of migrate_pagse has a responsibility
> of clean up the list?

Yes. All callers would be responsible for cleanup.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-08-23 17:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-23 16:15 [PATCH] compaction: fix COMPACTPAGEFAILED counting Minchan Kim
2010-08-23 16:15 ` Minchan Kim
2010-08-23 16:41 ` Christoph Lameter
2010-08-23 16:41   ` Christoph Lameter
2010-08-23 17:03   ` Minchan Kim
2010-08-23 17:03     ` Minchan Kim
2010-08-23 17:06   ` Minchan Kim
2010-08-23 17:06     ` Minchan Kim
2010-08-23 17:17     ` Christoph Lameter [this message]
2010-08-23 17:17       ` Christoph Lameter
2010-08-24  1:19       ` Minchan Kim
2010-08-24  1:19         ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1008231217100.9840@router.home \
    --to=cl@linux.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan.kim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.