From: David Rientjes <rientjes@google.com>
To: Mike Galbraith <efault@gmx.de>
Cc: Tejun Heo <htejun@gmail.com>, Li Zefan <lizf@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Paul Menage <paul@paulmenage.org>
Subject: Re: [patch] cpusets: allow PF_THREAD_BOUND kworkers to escape from a cpuset
Date: Fri, 23 Sep 2011 13:20:51 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1109231304310.11347@chino.kir.corp.google.com> (raw)
In-Reply-To: <1316788392.6544.33.camel@marge.simson.net>
On Fri, 23 Sep 2011, Mike Galbraith wrote:
> I don't see why it's a kworker code problem. The kworker code couldn't
> care less about cpusets. But I don't care who fixes it or how.
>
The problem is that PF_THREAD_BOUND means that nothing other than the task
itself may change the set of allowed cpus to be different. For this
reason, they have always been declined to be moved amongst cpusets because
even though their bound cpu may be a subset of the cpuset's cpumask at the
time of attach, that cpuset mask may subsequently change and therefore try
to force the PF_THREAD_BOUND off the cpu it is bound to resulting in an
inconsistency between the cpuset's mask and an attached task's mask.
Allowing a PF_THREAD_BOUND thread to move to the root cpuset isn't so much
of a problem because it's guaranteed to never exclude the bound cpu, but
the problem already exists if the kworker is in the child cpuset and
userspace attempts to change the mems of that cpuset to be disjoint. That
results in an inconsistency because the scheduler will refuse it.
> cpusets: disallow moving kthreadd into a cpuset.
>
> If kthreadd is moved into a cpuset, it's child may then acquire
> PF_THREAD_BOUND and become trapped, making it's cpuset immortal.
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
>
> diff --git a/kernel/cpuset.c b/kernel/cpuset.c
> index 10131fd..0d9cd04 100644
> --- a/kernel/cpuset.c
> +++ b/kernel/cpuset.c
> @@ -59,6 +59,7 @@
> #include <linux/mutex.h>
> #include <linux/workqueue.h>
> #include <linux/cgroup.h>
> +#include <linux/kthread.h>
>
> /*
> * Workqueue for cpuset related tasks.
> @@ -1382,9 +1383,10 @@ static int cpuset_can_attach(struct cgroup_subsys *ss, struct cgroup *cont,
> * set of allowed nodes is unnecessary. Thus, cpusets are not
> * applicable for such threads. This prevents checking for success of
> * set_cpus_allowed_ptr() on all attached tasks before cpus_allowed may
> - * be changed.
> + * be changed. We also disallow attaching kthreadd, to prevent it's
> + * child from becoming trapped should it then acquire PF_THREAD_BOUND.
> */
> - if (tsk->flags & PF_THREAD_BOUND)
> + if (tsk->flags & PF_THREAD_BOUND || tsk == kthreadd_task)
> return -EINVAL;
>
> return 0;
I like this much better, let's wait to hear from Tejun because he may
shead some light on whether PF_THREAD_BOUND is really necessary for
kworkers at all times.
Thanks.
next prev parent reply other threads:[~2011-09-23 20:20 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 6:21 [patch] cpusets: allow PF_THREAD_BOUND kworkers to escape from a cpuset Mike Galbraith
2011-09-23 7:00 ` Li Zefan
2011-09-23 7:19 ` Mike Galbraith
2011-09-23 9:12 ` David Rientjes
2011-09-23 9:42 ` Mike Galbraith
2011-09-23 10:53 ` Mike Galbraith
2011-09-23 13:27 ` David Rientjes
2011-09-23 14:33 ` Mike Galbraith
2011-09-23 18:16 ` Mike Galbraith
2011-09-23 20:20 ` David Rientjes [this message]
2011-09-24 3:21 ` Tejun Heo
2011-10-10 5:34 ` Mike Galbraith
2011-10-10 8:03 ` [patch] cpusets, cgroups: disallow attaching kthreadd Mike Galbraith
2011-10-10 16:43 ` Tejun Heo
2011-10-11 2:31 ` Mike Galbraith
2011-10-11 14:08 ` Peter Zijlstra
2011-10-11 16:57 ` Mike Galbraith
2011-10-12 1:22 ` David Rientjes
2011-10-12 1:45 ` Mike Galbraith
2011-10-12 1:20 ` David Rientjes
2011-10-18 8:10 ` patch] " Mike Galbraith
2011-10-18 8:16 ` David Rientjes
2011-10-18 8:42 ` Peter Zijlstra
2011-10-18 8:47 ` Mike Galbraith
2011-10-18 9:06 ` Peter Zijlstra
2011-10-18 9:23 ` Mike Galbraith
2011-10-18 10:11 ` Mike Galbraith
2011-10-18 20:38 ` David Rientjes
2011-10-19 4:00 ` Mike Galbraith
2011-10-19 4:53 ` Paul Menage
2011-10-19 4:56 ` Paul Menage
2011-10-19 5:28 ` Mike Galbraith
2011-10-19 7:50 ` Peter Zijlstra
2011-10-19 19:47 ` David Rientjes
2011-10-20 10:32 ` Peter Zijlstra
2011-10-20 21:24 ` David Rientjes
2011-10-19 4:57 ` Paul Menage
2011-10-19 5:24 ` [patch-final] " Mike Galbraith
2011-10-19 7:54 ` Peter Zijlstra
2011-10-19 8:00 ` Paul Menage
2011-10-19 8:21 ` Mike Galbraith
2011-10-26 20:27 ` David Rientjes
2011-11-10 20:51 ` David Rientjes
2011-12-06 20:13 ` David Rientjes
2011-12-06 22:47 ` Andrew Morton
2011-12-06 23:53 ` David Rientjes
2011-12-07 0:05 ` Andrew Morton
2011-12-07 3:18 ` [resubmit] " Mike Galbraith
2011-12-07 4:36 ` Mike Galbraith
2011-12-07 22:03 ` David Rientjes
2011-12-14 20:16 ` Andrew Morton
2011-12-15 2:50 ` David Rientjes
2012-01-06 22:06 ` Andrew Morton
2012-01-07 6:34 ` Mike Galbraith
2012-01-07 7:59 ` Andrew Morton
2011-12-07 22:01 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1109231304310.11347@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=efault@gmx.de \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=paul@paulmenage.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.