All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Mike Galbraith <efault@gmx.de>
Cc: Paul Menage <paul@paulmenage.org>,
	LKML <linux-kernel@vger.kernel.org>, Tejun Heo <htejun@gmail.com>,
	Li Zefan <lizf@cn.fujitsu.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [patch-final] Re: patch] cpusets, cgroups: disallow attaching kthreadd
Date: Tue, 6 Dec 2011 15:53:47 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1112061547530.15884@chino.kir.corp.google.com> (raw)
In-Reply-To: <20111206144721.7b1d473d.akpm@linux-foundation.org>

On Tue, 6 Dec 2011, Andrew Morton wrote:

> > Ping #2?
> > 
> 
> Why am I being pinged about scheduler patches?  My sole contribution
> to this one is to point out that "its"->possessive and "it's"->"it is".
> 

It touches two areas and there's probably a counter argument on the 
otherside about wanting to apply cpuset patches, which typically go 
through -mm.  It's a patch that, as the changelog indicates, fixes cpusets 
from becoming immortal if their set of tasks can never be emptied.  Would 
you like the change separated into kernel/cpuset.c and kernel/sched.c 
portions each referring to each other?

> Also, Peter has said
> 
> : I really think that if we want to restrain userspace from doing
> : something stupid we might as well do something that makes sense, and
> : that is mandate kthreadd stays in the root group at all times for
> : everybody.
> 
> which appears to be what the patch already did, so I'm confused again.
> 

Yes, that's what the patch does.  I'm not sure that Peter's explanation 
above is any better than what Mike wrote in the changelog, though, the 
changelog states why allowing kthreadd to move to a cpuset is actually 
troublesome.

> It's time for a fresh resend, IMO.
> 

Mike, would you mind resending the patch for the fourth or fifth time?  If 
not, I'll rebase it.

  reply	other threads:[~2011-12-06 23:53 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23  6:21 [patch] cpusets: allow PF_THREAD_BOUND kworkers to escape from a cpuset Mike Galbraith
2011-09-23  7:00 ` Li Zefan
2011-09-23  7:19   ` Mike Galbraith
2011-09-23  9:12     ` David Rientjes
2011-09-23  9:42       ` Mike Galbraith
2011-09-23 10:53         ` Mike Galbraith
2011-09-23 13:27           ` David Rientjes
2011-09-23 14:33             ` Mike Galbraith
2011-09-23 18:16               ` Mike Galbraith
2011-09-23 20:20               ` David Rientjes
2011-09-24  3:21                 ` Tejun Heo
2011-10-10  5:34               ` Mike Galbraith
2011-10-10  8:03                 ` [patch] cpusets, cgroups: disallow attaching kthreadd Mike Galbraith
2011-10-10 16:43                   ` Tejun Heo
2011-10-11  2:31                     ` Mike Galbraith
2011-10-11 14:08                     ` Peter Zijlstra
2011-10-11 16:57                       ` Mike Galbraith
2011-10-12  1:22                         ` David Rientjes
2011-10-12  1:45                           ` Mike Galbraith
2011-10-12  1:20                       ` David Rientjes
2011-10-18  8:10                   ` patch] " Mike Galbraith
2011-10-18  8:16                     ` David Rientjes
2011-10-18  8:42                     ` Peter Zijlstra
2011-10-18  8:47                       ` Mike Galbraith
2011-10-18  9:06                         ` Peter Zijlstra
2011-10-18  9:23                           ` Mike Galbraith
2011-10-18 10:11                             ` Mike Galbraith
2011-10-18 20:38                               ` David Rientjes
2011-10-19  4:00                                 ` Mike Galbraith
2011-10-19  4:53                                   ` Paul Menage
2011-10-19  4:56                                     ` Paul Menage
2011-10-19  5:28                                       ` Mike Galbraith
2011-10-19  7:50                                 ` Peter Zijlstra
2011-10-19 19:47                                   ` David Rientjes
2011-10-20 10:32                                     ` Peter Zijlstra
2011-10-20 21:24                                       ` David Rientjes
2011-10-19  4:57                     ` Paul Menage
2011-10-19  5:24                       ` [patch-final] " Mike Galbraith
2011-10-19  7:54                         ` Peter Zijlstra
2011-10-19  8:00                           ` Paul Menage
2011-10-19  8:21                           ` Mike Galbraith
2011-10-26 20:27                         ` David Rientjes
2011-11-10 20:51                           ` David Rientjes
2011-12-06 20:13                             ` David Rientjes
2011-12-06 22:47                               ` Andrew Morton
2011-12-06 23:53                                 ` David Rientjes [this message]
2011-12-07  0:05                                   ` Andrew Morton
2011-12-07  3:18                                   ` [resubmit] " Mike Galbraith
2011-12-07  4:36                                     ` Mike Galbraith
2011-12-07 22:03                                       ` David Rientjes
2011-12-14 20:16                                         ` Andrew Morton
2011-12-15  2:50                                           ` David Rientjes
2012-01-06 22:06                                       ` Andrew Morton
2012-01-07  6:34                                         ` Mike Galbraith
2012-01-07  7:59                                           ` Andrew Morton
2011-12-07 22:01                                     ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1112061547530.15884@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=efault@gmx.de \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=paul@paulmenage.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.