From: Paul Walmsley <paul@pwsan.com>
To: "Mark A. Greer" <mgreer@animalcreek.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
khilman@ti.com
Subject: Re: [PATCH 08/12] arm: omap3: am35x: Fix clockdomain dependencies
Date: Wed, 11 Apr 2012 16:04:44 -0600 (MDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1204111555360.29473@utopia.booyaka.com> (raw)
In-Reply-To: <20120411215513.GA31197@animalcreek.com>
On Wed, 11 Apr 2012, Mark A. Greer wrote:
> On Wed, Apr 11, 2012 at 03:44:38PM -0600, Paul Walmsley wrote:
>
> > Looks like there are an extra set of commas here, maybe just use:
> >
> > static struct clkdm_dep gfx_sgx_am35x_wkdeps[] = {
> > { .clkdm_name = "mpu_clkdm" },
> > { .clkdm_name = "wkup_clkdm" },
> > { NULL },
>
> Yes, there are extra commas but they come from the code I'm copying
> and removing iva2_clkdm from. I was keeping things consistent so I
> kept the commas. Given that, do you still want them removed?
> (I'm indifferent.)
Yes please. I realize it's a minor issue, but I'd like to keep the format
of these files internally consistent.
- Paul
WARNING: multiple messages have this Message-ID (diff)
From: paul@pwsan.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/12] arm: omap3: am35x: Fix clockdomain dependencies
Date: Wed, 11 Apr 2012 16:04:44 -0600 (MDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1204111555360.29473@utopia.booyaka.com> (raw)
In-Reply-To: <20120411215513.GA31197@animalcreek.com>
On Wed, 11 Apr 2012, Mark A. Greer wrote:
> On Wed, Apr 11, 2012 at 03:44:38PM -0600, Paul Walmsley wrote:
>
> > Looks like there are an extra set of commas here, maybe just use:
> >
> > static struct clkdm_dep gfx_sgx_am35x_wkdeps[] = {
> > { .clkdm_name = "mpu_clkdm" },
> > { .clkdm_name = "wkup_clkdm" },
> > { NULL },
>
> Yes, there are extra commas but they come from the code I'm copying
> and removing iva2_clkdm from. I was keeping things consistent so I
> kept the commas. Given that, do you still want them removed?
> (I'm indifferent.)
Yes please. I realize it's a minor issue, but I'd like to keep the format
of these files internally consistent.
- Paul
next prev parent reply other threads:[~2012-04-11 22:04 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 19:05 arm: omap3: am35x: Powerdomain, EMIF4, etc. fixups Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 01/12] arm: omap3: Only access IVA if one exists Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 02/12] arm: omap3: Only sleep during cpu_idle if I/O wake-ups work Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 21:38 ` Paul Walmsley
2012-04-11 21:38 ` Paul Walmsley
2012-04-11 23:42 ` Jon Hunter
2012-04-11 23:42 ` Jon Hunter
2012-04-13 0:13 ` Mark A. Greer
2012-04-13 0:13 ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 03/12] arm: omap3: Only sleep in cpuidle driver " Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 21:37 ` Paul Walmsley
2012-04-11 21:37 ` Paul Walmsley
2012-04-11 22:23 ` Mark A. Greer
2012-04-11 22:23 ` Mark A. Greer
2012-04-11 22:47 ` Paul Walmsley
2012-04-11 22:47 ` Paul Walmsley
2012-04-11 23:08 ` Mark A. Greer
2012-04-11 23:08 ` Mark A. Greer
2012-04-24 20:51 ` Mark A. Greer
2012-04-24 20:51 ` Mark A. Greer
2012-04-24 23:25 ` Mark A. Greer
2012-04-24 23:25 ` Mark A. Greer
2012-04-27 21:12 ` Kevin Hilman
2012-04-27 21:12 ` Kevin Hilman
2012-04-27 21:55 ` Mark A. Greer
2012-04-27 21:55 ` Mark A. Greer
2012-04-30 21:34 ` Mark A. Greer
2012-04-30 21:34 ` Mark A. Greer
2012-04-30 22:00 ` Kevin Hilman
2012-04-30 22:00 ` Kevin Hilman
2012-04-30 22:18 ` Mark A. Greer
2012-04-30 22:18 ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 04/12] arm: omap3: am35x: Don't mark missing features as present Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 05/12] arm: omap3: am35x: Add PWROFF feature Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 22:46 ` Kevin Hilman
2012-04-11 22:46 ` Kevin Hilman
2012-04-11 23:11 ` Mark A. Greer
2012-04-11 23:11 ` Mark A. Greer
2012-04-24 4:36 ` Mark A. Greer
2012-04-24 4:36 ` Mark A. Greer
2012-04-27 21:07 ` Kevin Hilman
2012-04-27 21:07 ` Kevin Hilman
2012-04-30 22:08 ` Mark A. Greer
2012-04-30 22:08 ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 06/12] arm: omap3: am35x: Add full PWRDM_POWER_INACTIVE support Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 20:56 ` Jean Pihet
2012-04-11 20:56 ` Jean Pihet
2012-04-11 21:08 ` Paul Walmsley
2012-04-11 21:08 ` Paul Walmsley
2012-04-11 21:14 ` Mark A. Greer
2012-04-11 21:14 ` Mark A. Greer
2012-04-11 21:15 ` Jean Pihet
2012-04-11 21:15 ` Jean Pihet
2012-04-11 21:12 ` Mark A. Greer
2012-04-11 21:12 ` Mark A. Greer
2012-04-11 22:17 ` Paul Walmsley
2012-04-11 22:17 ` Paul Walmsley
2012-04-11 19:05 ` [PATCH 07/12] arm: omap3: am35x: Set proper powerdomain states Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 21:53 ` Paul Walmsley
2012-04-11 21:53 ` Paul Walmsley
2012-04-11 22:40 ` Mark A. Greer
2012-04-11 22:40 ` Mark A. Greer
2012-04-12 0:24 ` Jon Hunter
2012-04-12 0:24 ` Jon Hunter
2012-04-12 2:19 ` Mark A. Greer
2012-04-12 2:19 ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 08/12] arm: omap3: am35x: Fix clockdomain dependencies Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 21:44 ` Paul Walmsley
2012-04-11 21:44 ` Paul Walmsley
2012-04-11 21:55 ` Mark A. Greer
2012-04-11 21:55 ` Mark A. Greer
2012-04-11 22:04 ` Paul Walmsley [this message]
2012-04-11 22:04 ` Paul Walmsley
2012-04-11 22:49 ` Mark A. Greer
2012-04-11 22:49 ` Mark A. Greer
2012-04-11 23:49 ` Paul Walmsley
2012-04-11 23:49 ` Paul Walmsley
2012-04-12 2:23 ` Mark A. Greer
2012-04-12 2:23 ` Mark A. Greer
2012-04-12 2:29 ` Paul Walmsley
2012-04-12 2:29 ` Paul Walmsley
2012-04-12 23:00 ` Mark A. Greer
2012-04-12 23:00 ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 09/12] arm: omap3: am35x: Add SDRC EMIF4 feature Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 21:29 ` Paul Walmsley
2012-04-11 21:29 ` Paul Walmsley
2012-04-11 22:50 ` Mark A. Greer
2012-04-11 22:50 ` Mark A. Greer
2012-04-11 22:56 ` Paul Walmsley
2012-04-11 22:56 ` Paul Walmsley
2012-04-11 23:23 ` Mark A. Greer
2012-04-11 23:23 ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 10/12] arm: omap3: am35x: Add minimal EMIF4 support Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 21:31 ` Paul Walmsley
2012-04-11 21:31 ` Paul Walmsley
2012-04-11 23:22 ` Mark A. Greer
2012-04-11 23:22 ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 11/12] arm: omap3: am35x: Add do_wfi routine for EMIF4 submodules Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 22:35 ` Kevin Hilman
2012-04-11 22:35 ` Kevin Hilman
2012-04-11 23:26 ` Mark A. Greer
2012-04-11 23:26 ` Mark A. Greer
2012-04-11 22:36 ` Paul Walmsley
2012-04-11 22:36 ` Paul Walmsley
2012-04-13 0:12 ` Mark A. Greer
2012-04-13 0:12 ` Mark A. Greer
2012-04-11 22:54 ` Paul Walmsley
2012-04-11 22:54 ` Paul Walmsley
2012-04-11 19:05 ` [PATCH 12/12] arm: omap3: am35x: Register davinci_mdio before davinci_emac Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 21:24 ` Paul Walmsley
2012-04-11 21:24 ` Paul Walmsley
2012-04-11 22:00 ` Mark A. Greer
2012-04-11 22:00 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1204111555360.29473@utopia.booyaka.com \
--to=paul@pwsan.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mgreer@animalcreek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.