All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: "Mark A. Greer" <mgreer@animalcreek.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	khilman@ti.com
Subject: Re: [PATCH 06/12] arm: omap3: am35x: Add full PWRDM_POWER_INACTIVE support
Date: Wed, 11 Apr 2012 16:17:25 -0600 (MDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1204111615140.29473@utopia.booyaka.com> (raw)
In-Reply-To: <1334171147-7517-7-git-send-email-mgreer@animalcreek.com>

On Wed, 11 Apr 2012, Mark A. Greer wrote:

> From: "Mark A. Greer" <mgreer@animalcreek.com>
> 
> The am35x family of SoCs only support PWRDM_POWER_ON
> and PWRDM_POWER_INACTIVE power states. This causes
> an issue in some areas of the OMAP3 power-related
> code because of assumptions that PWRDM_POWER_RET
> and/or PWRDM_POWER_OFF are always valid states.
> 
> To get am35x SoCs to work properly, add missing support
> for PWRDM_POWER_INACTIVE and remove assumptions that
> PWRDM_POWER_RET and PWRDM_POWER_OFF are always valid states.
> 
> Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>

Same comments here as on "arm: omap3: am35x: Set proper powerdomain 
states" -- does it even make sense for us to separate out INACTIVE at all 
in this case?  Seems like AM3517/3505 supports powerdomains ON, and that's 
it.  Seems like we can't program INACTIVE to the POWERSTATE bits, nor can 
we read it from those bits?


- Paul

WARNING: multiple messages have this Message-ID (diff)
From: paul@pwsan.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/12] arm: omap3: am35x: Add full PWRDM_POWER_INACTIVE support
Date: Wed, 11 Apr 2012 16:17:25 -0600 (MDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1204111615140.29473@utopia.booyaka.com> (raw)
In-Reply-To: <1334171147-7517-7-git-send-email-mgreer@animalcreek.com>

On Wed, 11 Apr 2012, Mark A. Greer wrote:

> From: "Mark A. Greer" <mgreer@animalcreek.com>
> 
> The am35x family of SoCs only support PWRDM_POWER_ON
> and PWRDM_POWER_INACTIVE power states. This causes
> an issue in some areas of the OMAP3 power-related
> code because of assumptions that PWRDM_POWER_RET
> and/or PWRDM_POWER_OFF are always valid states.
> 
> To get am35x SoCs to work properly, add missing support
> for PWRDM_POWER_INACTIVE and remove assumptions that
> PWRDM_POWER_RET and PWRDM_POWER_OFF are always valid states.
> 
> Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>

Same comments here as on "arm: omap3: am35x: Set proper powerdomain 
states" -- does it even make sense for us to separate out INACTIVE at all 
in this case?  Seems like AM3517/3505 supports powerdomains ON, and that's 
it.  Seems like we can't program INACTIVE to the POWERSTATE bits, nor can 
we read it from those bits?


- Paul

  parent reply	other threads:[~2012-04-11 22:17 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 19:05 arm: omap3: am35x: Powerdomain, EMIF4, etc. fixups Mark A. Greer
2012-04-11 19:05 ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 01/12] arm: omap3: Only access IVA if one exists Mark A. Greer
2012-04-11 19:05   ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 02/12] arm: omap3: Only sleep during cpu_idle if I/O wake-ups work Mark A. Greer
2012-04-11 19:05   ` Mark A. Greer
2012-04-11 21:38   ` Paul Walmsley
2012-04-11 21:38     ` Paul Walmsley
2012-04-11 23:42   ` Jon Hunter
2012-04-11 23:42     ` Jon Hunter
2012-04-13  0:13     ` Mark A. Greer
2012-04-13  0:13       ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 03/12] arm: omap3: Only sleep in cpuidle driver " Mark A. Greer
2012-04-11 19:05   ` Mark A. Greer
2012-04-11 21:37   ` Paul Walmsley
2012-04-11 21:37     ` Paul Walmsley
2012-04-11 22:23     ` Mark A. Greer
2012-04-11 22:23       ` Mark A. Greer
2012-04-11 22:47       ` Paul Walmsley
2012-04-11 22:47         ` Paul Walmsley
2012-04-11 23:08         ` Mark A. Greer
2012-04-11 23:08           ` Mark A. Greer
2012-04-24 20:51     ` Mark A. Greer
2012-04-24 20:51       ` Mark A. Greer
2012-04-24 23:25       ` Mark A. Greer
2012-04-24 23:25         ` Mark A. Greer
2012-04-27 21:12         ` Kevin Hilman
2012-04-27 21:12           ` Kevin Hilman
2012-04-27 21:55           ` Mark A. Greer
2012-04-27 21:55             ` Mark A. Greer
2012-04-30 21:34           ` Mark A. Greer
2012-04-30 21:34             ` Mark A. Greer
2012-04-30 22:00             ` Kevin Hilman
2012-04-30 22:00               ` Kevin Hilman
2012-04-30 22:18               ` Mark A. Greer
2012-04-30 22:18                 ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 04/12] arm: omap3: am35x: Don't mark missing features as present Mark A. Greer
2012-04-11 19:05   ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 05/12] arm: omap3: am35x: Add PWROFF feature Mark A. Greer
2012-04-11 19:05   ` Mark A. Greer
2012-04-11 22:46   ` Kevin Hilman
2012-04-11 22:46     ` Kevin Hilman
2012-04-11 23:11     ` Mark A. Greer
2012-04-11 23:11       ` Mark A. Greer
2012-04-24  4:36     ` Mark A. Greer
2012-04-24  4:36       ` Mark A. Greer
2012-04-27 21:07       ` Kevin Hilman
2012-04-27 21:07         ` Kevin Hilman
2012-04-30 22:08         ` Mark A. Greer
2012-04-30 22:08           ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 06/12] arm: omap3: am35x: Add full PWRDM_POWER_INACTIVE support Mark A. Greer
2012-04-11 19:05   ` Mark A. Greer
2012-04-11 20:56   ` Jean Pihet
2012-04-11 20:56     ` Jean Pihet
2012-04-11 21:08     ` Paul Walmsley
2012-04-11 21:08       ` Paul Walmsley
2012-04-11 21:14       ` Mark A. Greer
2012-04-11 21:14         ` Mark A. Greer
2012-04-11 21:15         ` Jean Pihet
2012-04-11 21:15           ` Jean Pihet
2012-04-11 21:12     ` Mark A. Greer
2012-04-11 21:12       ` Mark A. Greer
2012-04-11 22:17   ` Paul Walmsley [this message]
2012-04-11 22:17     ` Paul Walmsley
2012-04-11 19:05 ` [PATCH 07/12] arm: omap3: am35x: Set proper powerdomain states Mark A. Greer
2012-04-11 19:05   ` Mark A. Greer
2012-04-11 21:53   ` Paul Walmsley
2012-04-11 21:53     ` Paul Walmsley
2012-04-11 22:40     ` Mark A. Greer
2012-04-11 22:40       ` Mark A. Greer
2012-04-12  0:24       ` Jon Hunter
2012-04-12  0:24         ` Jon Hunter
2012-04-12  2:19         ` Mark A. Greer
2012-04-12  2:19           ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 08/12] arm: omap3: am35x: Fix clockdomain dependencies Mark A. Greer
2012-04-11 19:05   ` Mark A. Greer
2012-04-11 21:44   ` Paul Walmsley
2012-04-11 21:44     ` Paul Walmsley
2012-04-11 21:55     ` Mark A. Greer
2012-04-11 21:55       ` Mark A. Greer
2012-04-11 22:04       ` Paul Walmsley
2012-04-11 22:04         ` Paul Walmsley
2012-04-11 22:49         ` Mark A. Greer
2012-04-11 22:49           ` Mark A. Greer
2012-04-11 23:49           ` Paul Walmsley
2012-04-11 23:49             ` Paul Walmsley
2012-04-12  2:23             ` Mark A. Greer
2012-04-12  2:23               ` Mark A. Greer
2012-04-12  2:29               ` Paul Walmsley
2012-04-12  2:29                 ` Paul Walmsley
2012-04-12 23:00                 ` Mark A. Greer
2012-04-12 23:00                   ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 09/12] arm: omap3: am35x: Add SDRC EMIF4 feature Mark A. Greer
2012-04-11 19:05   ` Mark A. Greer
2012-04-11 21:29   ` Paul Walmsley
2012-04-11 21:29     ` Paul Walmsley
2012-04-11 22:50     ` Mark A. Greer
2012-04-11 22:50       ` Mark A. Greer
2012-04-11 22:56   ` Paul Walmsley
2012-04-11 22:56     ` Paul Walmsley
2012-04-11 23:23     ` Mark A. Greer
2012-04-11 23:23       ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 10/12] arm: omap3: am35x: Add minimal EMIF4 support Mark A. Greer
2012-04-11 19:05   ` Mark A. Greer
2012-04-11 21:31   ` Paul Walmsley
2012-04-11 21:31     ` Paul Walmsley
2012-04-11 23:22     ` Mark A. Greer
2012-04-11 23:22       ` Mark A. Greer
2012-04-11 19:05 ` [PATCH 11/12] arm: omap3: am35x: Add do_wfi routine for EMIF4 submodules Mark A. Greer
2012-04-11 19:05   ` Mark A. Greer
2012-04-11 22:35   ` Kevin Hilman
2012-04-11 22:35     ` Kevin Hilman
2012-04-11 23:26     ` Mark A. Greer
2012-04-11 23:26       ` Mark A. Greer
2012-04-11 22:36   ` Paul Walmsley
2012-04-11 22:36     ` Paul Walmsley
2012-04-13  0:12     ` Mark A. Greer
2012-04-13  0:12       ` Mark A. Greer
2012-04-11 22:54   ` Paul Walmsley
2012-04-11 22:54     ` Paul Walmsley
2012-04-11 19:05 ` [PATCH 12/12] arm: omap3: am35x: Register davinci_mdio before davinci_emac Mark A. Greer
2012-04-11 19:05   ` Mark A. Greer
2012-04-11 21:24   ` Paul Walmsley
2012-04-11 21:24     ` Paul Walmsley
2012-04-11 22:00     ` Mark A. Greer
2012-04-11 22:00       ` Mark A. Greer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1204111615140.29473@utopia.booyaka.com \
    --to=paul@pwsan.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mgreer@animalcreek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.