All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Govindraj.R" <govindraj.raja@ti.com>,
	Kevin Hilman <khilman@ti.com>
Subject: Re: [PATCH] ARM: OMAP: serial: Fix the ocp smart idlemode handling bug
Date: Tue, 17 Apr 2012 12:43:14 -0600 (MDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1204171241230.29048@utopia.booyaka.com> (raw)
In-Reply-To: <1334339704-4554-1-git-send-email-santosh.shilimkar@ti.com>

On Fri, 13 Apr 2012, Santosh Shilimkar wrote:

> The current serial UART code, while fidling with ocp idlemode bits,
> forget about the smart idle wakeup bit even if it is supported by
> UART IP block. This will lead to missing the module wakeup on OMAP's
> where the smart idle wakeup is supported.
> 
> This was the root cause of the console sluggishness issue, I have been
> observing on OMAP4 devices and also can be potential reason for some
> other UART wakeup issues.
> 
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Govindraj.R <govindraj.raja@ti.com>
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>

Reviewed-by: Paul Walmsley <paul@pwsan.com>

Of course, in the long term, these idlemode tweaking functions need to go 
through some kind of omap_bus/omap_device abstraction, since platform_data 
function pointers are going away with the DT conversion.  But since a 
decent omap_bus/omap_device is still a ways off, this is an important 
interim step.


- Paul

WARNING: multiple messages have this Message-ID (diff)
From: paul@pwsan.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: serial: Fix the ocp smart idlemode handling bug
Date: Tue, 17 Apr 2012 12:43:14 -0600 (MDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1204171241230.29048@utopia.booyaka.com> (raw)
In-Reply-To: <1334339704-4554-1-git-send-email-santosh.shilimkar@ti.com>

On Fri, 13 Apr 2012, Santosh Shilimkar wrote:

> The current serial UART code, while fidling with ocp idlemode bits,
> forget about the smart idle wakeup bit even if it is supported by
> UART IP block. This will lead to missing the module wakeup on OMAP's
> where the smart idle wakeup is supported.
> 
> This was the root cause of the console sluggishness issue, I have been
> observing on OMAP4 devices and also can be potential reason for some
> other UART wakeup issues.
> 
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Govindraj.R <govindraj.raja@ti.com>
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>

Reviewed-by: Paul Walmsley <paul@pwsan.com>

Of course, in the long term, these idlemode tweaking functions need to go 
through some kind of omap_bus/omap_device abstraction, since platform_data 
function pointers are going away with the DT conversion.  But since a 
decent omap_bus/omap_device is still a ways off, this is an important 
interim step.


- Paul

  parent reply	other threads:[~2012-04-17 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13 17:55 [PATCH] ARM: OMAP: serial: Fix the ocp smart idlemode handling bug Santosh Shilimkar
2012-04-13 17:55 ` Santosh Shilimkar
2012-04-16 10:05 ` Raja, Govindraj
2012-04-16 10:05   ` Raja, Govindraj
2012-04-17 18:43 ` Paul Walmsley [this message]
2012-04-17 18:43   ` Paul Walmsley
2012-04-17 22:20 ` Kevin Hilman
2012-04-17 22:20   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1204171241230.29048@utopia.booyaka.com \
    --to=paul@pwsan.com \
    --cc=govindraj.raja@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.