* [PATCH] ARM: OMAP: serial: Fix the ocp smart idlemode handling bug
@ 2012-04-13 17:55 ` Santosh Shilimkar
0 siblings, 0 replies; 8+ messages in thread
From: Santosh Shilimkar @ 2012-04-13 17:55 UTC (permalink / raw)
To: linux-arm-kernel
The current serial UART code, while fidling with ocp idlemode bits,
forget about the smart idle wakeup bit even if it is supported by
UART IP block. This will lead to missing the module wakeup on OMAP's
where the smart idle wakeup is supported.
This was the root cause of the console sluggishness issue, I have been
observing on OMAP4 devices and also can be potential reason for some
other UART wakeup issues.
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Govindraj.R <govindraj.raja@ti.com>
Cc: Kevin Hilman <khilman@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>
---
arch/arm/mach-omap2/serial.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
index c9503a7..b28aae1 100644
--- a/arch/arm/mach-omap2/serial.c
+++ b/arch/arm/mach-omap2/serial.c
@@ -108,8 +108,14 @@ static void omap_uart_set_noidle(struct platform_device *pdev)
static void omap_uart_set_smartidle(struct platform_device *pdev)
{
struct omap_device *od = to_omap_device(pdev);
+ u8 idlemode;
- omap_hwmod_set_slave_idlemode(od->hwmods[0], HWMOD_IDLEMODE_SMART);
+ if (od->hwmods[0]->class->sysc->idlemodes & SIDLE_SMART_WKUP)
+ idlemode = HWMOD_IDLEMODE_SMART_WKUP;
+ else
+ idlemode = HWMOD_IDLEMODE_SMART;
+
+ omap_hwmod_set_slave_idlemode(od->hwmods[0], idlemode);
}
#else
--
1.7.5.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: OMAP: serial: Fix the ocp smart idlemode handling bug
2012-04-13 17:55 ` Santosh Shilimkar
@ 2012-04-16 10:05 ` Raja, Govindraj
-1 siblings, 0 replies; 8+ messages in thread
From: Raja, Govindraj @ 2012-04-16 10:05 UTC (permalink / raw)
To: Santosh Shilimkar
Cc: linux-omap, linux-arm-kernel, Kevin Hilman, Paul Walmsley
On Fri, Apr 13, 2012 at 11:25 PM, Santosh Shilimkar
<santosh.shilimkar@ti.com> wrote:
> The current serial UART code, while fidling with ocp idlemode bits,
> forget about the smart idle wakeup bit even if it is supported by
> UART IP block. This will lead to missing the module wakeup on OMAP's
> where the smart idle wakeup is supported.
>
> This was the root cause of the console sluggishness issue, I have been
> observing on OMAP4 devices and also can be potential reason for some
> other UART wakeup issues.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Govindraj.R <govindraj.raja@ti.com>
Acked-by: Govindraj.R <govindraj.raja@ti.com>
Adding to git://gitorious.org/linux-3-x/omap-serial.git for_3.4/uart_fixes
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> ---
> arch/arm/mach-omap2/serial.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
> index c9503a7..b28aae1 100644
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> @@ -108,8 +108,14 @@ static void omap_uart_set_noidle(struct platform_device *pdev)
> static void omap_uart_set_smartidle(struct platform_device *pdev)
> {
> struct omap_device *od = to_omap_device(pdev);
> + u8 idlemode;
>
> - omap_hwmod_set_slave_idlemode(od->hwmods[0], HWMOD_IDLEMODE_SMART);
> + if (od->hwmods[0]->class->sysc->idlemodes & SIDLE_SMART_WKUP)
> + idlemode = HWMOD_IDLEMODE_SMART_WKUP;
> + else
> + idlemode = HWMOD_IDLEMODE_SMART;
> +
> + omap_hwmod_set_slave_idlemode(od->hwmods[0], idlemode);
> }
>
> #else
> --
> 1.7.5.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] ARM: OMAP: serial: Fix the ocp smart idlemode handling bug
@ 2012-04-16 10:05 ` Raja, Govindraj
0 siblings, 0 replies; 8+ messages in thread
From: Raja, Govindraj @ 2012-04-16 10:05 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Apr 13, 2012 at 11:25 PM, Santosh Shilimkar
<santosh.shilimkar@ti.com> wrote:
> The current serial UART code, while fidling with ocp idlemode bits,
> forget about the smart idle wakeup bit even if it is supported by
> UART IP block. This will lead to missing the module wakeup on OMAP's
> where the smart idle wakeup is supported.
>
> This was the root cause of the console sluggishness issue, I have been
> observing on OMAP4 devices and also can be potential reason for some
> other UART wakeup issues.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Govindraj.R <govindraj.raja@ti.com>
Acked-by: Govindraj.R <govindraj.raja@ti.com>
Adding to git://gitorious.org/linux-3-x/omap-serial.git for_3.4/uart_fixes
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> ---
> ?arch/arm/mach-omap2/serial.c | ? ?8 +++++++-
> ?1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
> index c9503a7..b28aae1 100644
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> @@ -108,8 +108,14 @@ static void omap_uart_set_noidle(struct platform_device *pdev)
> ?static void omap_uart_set_smartidle(struct platform_device *pdev)
> ?{
> ? ? ? ?struct omap_device *od = to_omap_device(pdev);
> + ? ? ? u8 idlemode;
>
> - ? ? ? omap_hwmod_set_slave_idlemode(od->hwmods[0], HWMOD_IDLEMODE_SMART);
> + ? ? ? if (od->hwmods[0]->class->sysc->idlemodes & SIDLE_SMART_WKUP)
> + ? ? ? ? ? ? ? idlemode = HWMOD_IDLEMODE_SMART_WKUP;
> + ? ? ? else
> + ? ? ? ? ? ? ? idlemode = HWMOD_IDLEMODE_SMART;
> +
> + ? ? ? omap_hwmod_set_slave_idlemode(od->hwmods[0], idlemode);
> ?}
>
> ?#else
> --
> 1.7.5.4
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: OMAP: serial: Fix the ocp smart idlemode handling bug
2012-04-13 17:55 ` Santosh Shilimkar
@ 2012-04-17 18:43 ` Paul Walmsley
-1 siblings, 0 replies; 8+ messages in thread
From: Paul Walmsley @ 2012-04-17 18:43 UTC (permalink / raw)
To: Santosh Shilimkar; +Cc: linux-omap, linux-arm-kernel, Govindraj.R, Kevin Hilman
On Fri, 13 Apr 2012, Santosh Shilimkar wrote:
> The current serial UART code, while fidling with ocp idlemode bits,
> forget about the smart idle wakeup bit even if it is supported by
> UART IP block. This will lead to missing the module wakeup on OMAP's
> where the smart idle wakeup is supported.
>
> This was the root cause of the console sluggishness issue, I have been
> observing on OMAP4 devices and also can be potential reason for some
> other UART wakeup issues.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Govindraj.R <govindraj.raja@ti.com>
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
Reviewed-by: Paul Walmsley <paul@pwsan.com>
Of course, in the long term, these idlemode tweaking functions need to go
through some kind of omap_bus/omap_device abstraction, since platform_data
function pointers are going away with the DT conversion. But since a
decent omap_bus/omap_device is still a ways off, this is an important
interim step.
- Paul
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: OMAP: serial: Fix the ocp smart idlemode handling bug
@ 2012-04-17 18:43 ` Paul Walmsley
0 siblings, 0 replies; 8+ messages in thread
From: Paul Walmsley @ 2012-04-17 18:43 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 13 Apr 2012, Santosh Shilimkar wrote:
> The current serial UART code, while fidling with ocp idlemode bits,
> forget about the smart idle wakeup bit even if it is supported by
> UART IP block. This will lead to missing the module wakeup on OMAP's
> where the smart idle wakeup is supported.
>
> This was the root cause of the console sluggishness issue, I have been
> observing on OMAP4 devices and also can be potential reason for some
> other UART wakeup issues.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Govindraj.R <govindraj.raja@ti.com>
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
Reviewed-by: Paul Walmsley <paul@pwsan.com>
Of course, in the long term, these idlemode tweaking functions need to go
through some kind of omap_bus/omap_device abstraction, since platform_data
function pointers are going away with the DT conversion. But since a
decent omap_bus/omap_device is still a ways off, this is an important
interim step.
- Paul
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: OMAP: serial: Fix the ocp smart idlemode handling bug
2012-04-13 17:55 ` Santosh Shilimkar
@ 2012-04-17 22:20 ` Kevin Hilman
-1 siblings, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2012-04-17 22:20 UTC (permalink / raw)
To: Santosh Shilimkar
Cc: linux-omap, linux-arm-kernel, Govindraj.R, Paul Walmsley
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> The current serial UART code, while fidling with ocp idlemode bits,
> forget about the smart idle wakeup bit even if it is supported by
> UART IP block. This will lead to missing the module wakeup on OMAP's
> where the smart idle wakeup is supported.
>
> This was the root cause of the console sluggishness issue, I have been
> observing on OMAP4 devices and also can be potential reason for some
> other UART wakeup issues.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Govindraj.R <govindraj.raja@ti.com>
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
Acked-by: Kevin Hilman <khilman@ti.com>
> ---
> arch/arm/mach-omap2/serial.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
> index c9503a7..b28aae1 100644
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> @@ -108,8 +108,14 @@ static void omap_uart_set_noidle(struct platform_device *pdev)
> static void omap_uart_set_smartidle(struct platform_device *pdev)
> {
> struct omap_device *od = to_omap_device(pdev);
> + u8 idlemode;
>
> - omap_hwmod_set_slave_idlemode(od->hwmods[0], HWMOD_IDLEMODE_SMART);
> + if (od->hwmods[0]->class->sysc->idlemodes & SIDLE_SMART_WKUP)
> + idlemode = HWMOD_IDLEMODE_SMART_WKUP;
> + else
> + idlemode = HWMOD_IDLEMODE_SMART;
> +
> + omap_hwmod_set_slave_idlemode(od->hwmods[0], idlemode);
> }
>
> #else
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] ARM: OMAP: serial: Fix the ocp smart idlemode handling bug
@ 2012-04-17 22:20 ` Kevin Hilman
0 siblings, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2012-04-17 22:20 UTC (permalink / raw)
To: linux-arm-kernel
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> The current serial UART code, while fidling with ocp idlemode bits,
> forget about the smart idle wakeup bit even if it is supported by
> UART IP block. This will lead to missing the module wakeup on OMAP's
> where the smart idle wakeup is supported.
>
> This was the root cause of the console sluggishness issue, I have been
> observing on OMAP4 devices and also can be potential reason for some
> other UART wakeup issues.
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Govindraj.R <govindraj.raja@ti.com>
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
Acked-by: Kevin Hilman <khilman@ti.com>
> ---
> arch/arm/mach-omap2/serial.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
> index c9503a7..b28aae1 100644
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> @@ -108,8 +108,14 @@ static void omap_uart_set_noidle(struct platform_device *pdev)
> static void omap_uart_set_smartidle(struct platform_device *pdev)
> {
> struct omap_device *od = to_omap_device(pdev);
> + u8 idlemode;
>
> - omap_hwmod_set_slave_idlemode(od->hwmods[0], HWMOD_IDLEMODE_SMART);
> + if (od->hwmods[0]->class->sysc->idlemodes & SIDLE_SMART_WKUP)
> + idlemode = HWMOD_IDLEMODE_SMART_WKUP;
> + else
> + idlemode = HWMOD_IDLEMODE_SMART;
> +
> + omap_hwmod_set_slave_idlemode(od->hwmods[0], idlemode);
> }
>
> #else
^ permalink raw reply [flat|nested] 8+ messages in thread