From: David Rientjes <rientjes@google.com>
To: Glauber Costa <glommer@parallels.com>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Pekka Enberg <penberg@kernel.org>, Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Christoph Lameter <cl@linux.com>,
devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com,
Tejun Heo <tj@kernel.org>, Pekka Enberg <penberg@cs.helsinki.fi>,
Suleiman Souhlal <suleiman@google.com>,
Frederic Weisbecker <fweisbec@redhat.com>
Subject: Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs
Date: Mon, 25 Jun 2012 21:57:54 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206252157000.30072@chino.kir.corp.google.com> (raw)
In-Reply-To: <1340633728-12785-12-git-send-email-glommer@parallels.com>
On Mon, 25 Jun 2012, Glauber Costa wrote:
> diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h
> index ccc1899..914ec07 100644
> --- a/include/linux/thread_info.h
> +++ b/include/linux/thread_info.h
> @@ -61,6 +61,12 @@ extern long do_no_restart_syscall(struct restart_block *parm);
> # define THREADINFO_GFP (GFP_KERNEL | __GFP_NOTRACK)
> #endif
>
> +#ifdef CONFIG_CGROUP_MEM_RES_CTLR_KMEM
> +# define THREADINFO_GFP_ACCOUNTED (THREADINFO_GFP | __GFP_KMEMCG)
> +#else
> +# define THREADINFO_GFP_ACCOUNTED (THREADINFO_GFP)
> +#endif
> +
This type of requirement is going to become nasty very quickly if nobody
can use __GFP_KMEMCG without testing for CONFIG_CGROUP_MEM_RES_CTLR_KMEM.
Perhaps define __GFP_KMEMCG to be 0x0 if it's not enabled, similar to how
kmemcheck does?
WARNING: multiple messages have this Message-ID (diff)
From: David Rientjes <rientjes@google.com>
To: Glauber Costa <glommer@parallels.com>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Pekka Enberg <penberg@kernel.org>, Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Christoph Lameter <cl@linux.com>,
devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com,
Tejun Heo <tj@kernel.org>, Pekka Enberg <penberg@cs.helsinki.fi>,
Suleiman Souhlal <suleiman@google.com>,
Frederic Weisbecker <fweisbec@redhat.com>
Subject: Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs
Date: Mon, 25 Jun 2012 21:57:54 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206252157000.30072@chino.kir.corp.google.com> (raw)
In-Reply-To: <1340633728-12785-12-git-send-email-glommer@parallels.com>
On Mon, 25 Jun 2012, Glauber Costa wrote:
> diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h
> index ccc1899..914ec07 100644
> --- a/include/linux/thread_info.h
> +++ b/include/linux/thread_info.h
> @@ -61,6 +61,12 @@ extern long do_no_restart_syscall(struct restart_block *parm);
> # define THREADINFO_GFP (GFP_KERNEL | __GFP_NOTRACK)
> #endif
>
> +#ifdef CONFIG_CGROUP_MEM_RES_CTLR_KMEM
> +# define THREADINFO_GFP_ACCOUNTED (THREADINFO_GFP | __GFP_KMEMCG)
> +#else
> +# define THREADINFO_GFP_ACCOUNTED (THREADINFO_GFP)
> +#endif
> +
This type of requirement is going to become nasty very quickly if nobody
can use __GFP_KMEMCG without testing for CONFIG_CGROUP_MEM_RES_CTLR_KMEM.
Perhaps define __GFP_KMEMCG to be 0x0 if it's not enabled, similar to how
kmemcheck does?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-26 4:57 UTC|newest]
Thread overview: 238+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 14:15 [PATCH 00/11] kmem controller for memcg: stripped down version Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 01/11] memcg: Make it possible to use the stock for more than one page Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 17:44 ` Tejun Heo
2012-06-25 17:44 ` Tejun Heo
2012-06-25 17:44 ` Tejun Heo
2012-06-25 22:29 ` Glauber Costa
2012-06-25 22:29 ` Glauber Costa
2012-06-25 22:33 ` Tejun Heo
2012-06-25 22:33 ` Tejun Heo
2012-06-26 4:01 ` David Rientjes
2012-06-26 4:01 ` David Rientjes
2012-06-25 14:15 ` [PATCH 02/11] memcg: Reclaim when more than one page needed Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 23:33 ` Suleiman Souhlal
2012-06-25 23:33 ` Suleiman Souhlal
2012-06-26 8:39 ` Glauber Costa
2012-06-26 8:39 ` Glauber Costa
2012-06-27 16:16 ` Suleiman Souhlal
2012-06-27 16:16 ` Suleiman Souhlal
2012-06-27 16:16 ` Suleiman Souhlal
2012-06-26 4:09 ` David Rientjes
2012-06-26 4:09 ` David Rientjes
2012-06-26 7:12 ` Glauber Costa
2012-06-26 7:12 ` Glauber Costa
2012-06-26 7:12 ` Glauber Costa
2012-06-26 8:54 ` David Rientjes
2012-06-26 8:54 ` David Rientjes
2012-06-26 8:54 ` David Rientjes
2012-06-26 9:08 ` Glauber Costa
2012-06-26 9:08 ` Glauber Costa
2012-06-26 9:17 ` David Rientjes
2012-06-26 9:17 ` David Rientjes
2012-06-26 9:23 ` Glauber Costa
2012-06-26 9:23 ` Glauber Costa
2012-06-27 10:03 ` Glauber Costa
2012-06-27 10:03 ` Glauber Costa
2012-06-27 19:48 ` David Rientjes
2012-06-27 19:48 ` David Rientjes
2012-06-27 19:48 ` David Rientjes
2012-06-27 20:47 ` Glauber Costa
2012-06-27 20:47 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 03/11] memcg: change defines to an enum Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-26 4:11 ` David Rientjes
2012-06-26 4:11 ` David Rientjes
2012-06-26 8:28 ` Glauber Costa
2012-06-26 8:28 ` Glauber Costa
2012-06-26 9:01 ` David Rientjes
2012-06-26 9:01 ` David Rientjes
2012-06-26 9:01 ` David Rientjes
2012-06-25 14:15 ` [PATCH 04/11] kmem slab accounting basic infrastructure Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-26 4:22 ` David Rientjes
2012-06-26 4:22 ` David Rientjes
2012-06-26 7:09 ` Glauber Costa
2012-06-26 7:09 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 05/11] Add a __GFP_KMEMCG flag Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-26 4:25 ` David Rientjes
2012-06-26 4:25 ` David Rientjes
2012-06-26 7:08 ` Glauber Costa
2012-06-26 7:08 ` Glauber Costa
2012-06-26 9:03 ` David Rientjes
2012-06-26 9:03 ` David Rientjes
2012-06-25 14:15 ` [PATCH 06/11] memcg: kmem controller infrastructure Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 18:06 ` Tejun Heo
2012-06-25 18:06 ` Tejun Heo
2012-06-25 18:06 ` Tejun Heo
2012-06-25 22:28 ` Glauber Costa
2012-06-25 22:28 ` Glauber Costa
2012-06-25 23:17 ` Andrew Morton
2012-06-25 23:17 ` Andrew Morton
2012-06-25 23:17 ` Andrew Morton
2012-06-26 14:40 ` Glauber Costa
2012-06-26 14:40 ` Glauber Costa
2012-06-26 15:01 ` Glauber Costa
2012-06-26 15:01 ` Glauber Costa
2012-06-26 15:01 ` Glauber Costa
2012-06-26 18:01 ` Andrew Morton
2012-06-26 18:01 ` Andrew Morton
2012-06-26 18:01 ` Andrew Morton
2012-06-26 18:08 ` Tejun Heo
2012-06-26 18:08 ` Tejun Heo
2012-06-26 18:08 ` Tejun Heo
2012-06-26 18:14 ` Glauber Costa
2012-06-26 18:14 ` Glauber Costa
2012-06-26 19:20 ` Andrew Morton
2012-06-26 19:20 ` Andrew Morton
2012-06-26 15:29 ` Glauber Costa
2012-06-26 15:29 ` Glauber Costa
2012-06-26 15:29 ` Glauber Costa
2012-06-26 9:12 ` David Rientjes
2012-06-26 9:12 ` David Rientjes
2012-06-26 9:12 ` David Rientjes
2012-06-26 9:17 ` Glauber Costa
2012-06-26 9:17 ` Glauber Costa
2012-06-26 9:17 ` Glauber Costa
2012-06-27 4:01 ` David Rientjes
2012-06-27 4:01 ` David Rientjes
2012-06-27 9:33 ` Glauber Costa
2012-06-27 9:33 ` Glauber Costa
2012-06-27 9:33 ` Glauber Costa
2012-06-27 19:46 ` David Rientjes
2012-06-27 19:46 ` David Rientjes
2012-06-25 14:15 ` [PATCH 07/11] mm: Allocate kernel pages to the right memcg Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 18:07 ` Tejun Heo
2012-06-25 18:07 ` Tejun Heo
2012-06-25 22:27 ` Glauber Costa
2012-06-25 22:27 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 08/11] memcg: disable kmem code when not in use Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-26 5:51 ` Kamezawa Hiroyuki
2012-06-26 5:51 ` Kamezawa Hiroyuki
2012-06-25 14:15 ` [PATCH 09/11] memcg: propagate kmem limiting information to children Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 18:29 ` Tejun Heo
2012-06-25 18:29 ` Tejun Heo
2012-06-25 22:36 ` Glauber Costa
2012-06-25 22:36 ` Glauber Costa
2012-06-25 22:36 ` Glauber Costa
2012-06-25 22:49 ` Tejun Heo
2012-06-25 22:49 ` Tejun Heo
2012-06-25 22:49 ` Tejun Heo
2012-06-25 23:21 ` Andrew Morton
2012-06-25 23:21 ` Andrew Morton
2012-06-26 5:23 ` David Rientjes
2012-06-26 5:23 ` David Rientjes
2012-06-25 23:23 ` Andrew Morton
2012-06-25 23:23 ` Andrew Morton
2012-06-26 5:24 ` David Rientjes
2012-06-26 5:24 ` David Rientjes
2012-06-26 5:31 ` Andrew Morton
2012-06-26 5:31 ` Andrew Morton
2012-06-26 5:31 ` Andrew Morton
2012-06-26 7:23 ` Glauber Costa
2012-06-26 7:23 ` Glauber Costa
2012-06-26 7:23 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 10/11] memcg: allow a memcg with kmem charges to be destructed Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 18:34 ` Tejun Heo
2012-06-25 18:34 ` Tejun Heo
2012-06-25 22:25 ` Glauber Costa
2012-06-25 22:25 ` Glauber Costa
2012-06-25 22:25 ` Glauber Costa
2012-06-26 5:59 ` Kamezawa Hiroyuki
2012-06-26 5:59 ` Kamezawa Hiroyuki
2012-06-26 7:21 ` Glauber Costa
2012-06-26 7:21 ` Glauber Costa
2012-06-26 7:21 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 16:55 ` Frederic Weisbecker
2012-06-25 16:55 ` Frederic Weisbecker
2012-06-25 18:38 ` Tejun Heo
2012-06-25 18:38 ` Tejun Heo
2012-06-25 18:38 ` Tejun Heo
2012-06-25 20:57 ` Frederic Weisbecker
2012-06-25 20:57 ` Frederic Weisbecker
2012-06-25 20:57 ` Frederic Weisbecker
2012-06-26 12:48 ` Glauber Costa
2012-06-26 12:48 ` Glauber Costa
2012-06-26 12:48 ` Glauber Costa
2012-06-26 13:38 ` Frederic Weisbecker
2012-06-26 13:38 ` Frederic Weisbecker
2012-06-26 13:38 ` Frederic Weisbecker
2012-06-26 13:37 ` Glauber Costa
2012-06-26 13:37 ` Glauber Costa
2012-06-26 13:37 ` Glauber Costa
2012-06-26 13:44 ` Frederic Weisbecker
2012-06-26 13:44 ` Frederic Weisbecker
2012-06-26 13:44 ` Frederic Weisbecker
2012-06-26 4:57 ` David Rientjes [this message]
2012-06-26 4:57 ` David Rientjes
2012-06-26 5:35 ` Kamezawa Hiroyuki
2012-06-26 5:35 ` Kamezawa Hiroyuki
2012-06-26 5:35 ` Kamezawa Hiroyuki
2012-06-26 7:23 ` Glauber Costa
2012-06-26 7:23 ` Glauber Costa
2012-06-26 7:23 ` Glauber Costa
2012-06-26 8:45 ` David Rientjes
2012-06-26 8:45 ` David Rientjes
2012-06-26 8:45 ` David Rientjes
2012-06-26 8:44 ` Glauber Costa
2012-06-26 8:44 ` Glauber Costa
2012-06-26 8:44 ` Glauber Costa
2012-06-26 9:05 ` David Rientjes
2012-06-26 9:05 ` David Rientjes
2012-06-25 23:27 ` [PATCH 00/11] kmem controller for memcg: stripped down version Andrew Morton
2012-06-25 23:27 ` Andrew Morton
2012-06-26 7:17 ` Glauber Costa
2012-06-26 7:17 ` Glauber Costa
2012-06-26 21:55 ` Andrew Morton
2012-06-26 21:55 ` Andrew Morton
2012-06-26 21:55 ` Andrew Morton
2012-06-27 1:08 ` David Rientjes
2012-06-27 1:08 ` David Rientjes
2012-06-27 8:39 ` Glauber Costa
2012-06-27 8:39 ` Glauber Costa
2012-06-27 8:39 ` Glauber Costa
2012-06-27 9:29 ` Fork bomb limitation in memcg WAS: " Glauber Costa
2012-06-27 9:29 ` Glauber Costa
2012-06-27 9:29 ` Glauber Costa
2012-06-27 12:29 ` Frederic Weisbecker
2012-06-27 12:29 ` Frederic Weisbecker
2012-06-27 12:28 ` Glauber Costa
2012-06-27 12:28 ` Glauber Costa
2012-06-27 12:35 ` Frederic Weisbecker
2012-06-27 12:35 ` Frederic Weisbecker
2012-06-27 19:38 ` David Rientjes
2012-06-27 19:38 ` David Rientjes
2012-06-27 19:38 ` David Rientjes
2012-06-28 9:01 ` Glauber Costa
2012-06-28 9:01 ` Glauber Costa
2012-06-28 22:25 ` Andrew Morton
2012-06-28 22:25 ` Andrew Morton
2012-07-03 11:38 ` Glauber Costa
2012-07-03 11:38 ` Glauber Costa
2012-07-03 11:38 ` Glauber Costa
2012-07-12 15:40 ` Frederic Weisbecker
2012-07-12 15:40 ` Frederic Weisbecker
2012-08-07 13:59 ` Glauber Costa
2012-08-07 13:59 ` Glauber Costa
2012-08-07 13:59 ` Glauber Costa
2012-08-08 14:15 ` Glauber Costa
2012-08-08 14:15 ` Glauber Costa
2012-08-08 14:15 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1206252157000.30072@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=devel@openvz.org \
--cc=fweisbec@gmail.com \
--cc=fweisbec@redhat.com \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@kernel.org \
--cc=suleiman@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.