From: David Rientjes <rientjes@google.com>
To: Glauber Costa <glommer@parallels.com>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Pekka Enberg <penberg@kernel.org>, Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Christoph Lameter <cl@linux.com>,
devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com,
Tejun Heo <tj@kernel.org>, Suleiman Souhlal <suleiman@google.com>
Subject: Re: [PATCH 02/11] memcg: Reclaim when more than one page needed.
Date: Wed, 27 Jun 2012 12:48:41 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206271246380.22162@chino.kir.corp.google.com> (raw)
In-Reply-To: <4FEADA55.4060409@parallels.com>
On Wed, 27 Jun 2012, Glauber Costa wrote:
> > @@ -2206,7 +2214,7 @@ static int mem_cgroup_do_charge(struct mem_cgroup
> > *memcg, gfp_t gfp_mask,
> > > * unlikely to succeed so close to the limit, and we fall back
> > > * to regular pages anyway in case of failure.
> > > */
> > > - if (nr_pages == 1 && ret)
> > > + if (nr_pages <= NR_PAGES_TO_RETRY && ret)
> > > return CHARGE_RETRY;
>
> Changed to costly order.
>
1 << PAGE_ALLOC_COSTLY_ORDER was the suggestion.
> One more thing. The original version of this patch included
> a cond_resched() here, that was also removed. From my re-reading
> of the code in page_alloc.c and vmscan.c now, I tend to think
> this is indeed not needed, since any cond_resched()s that might
> be needed to ensure the safety of the code will be properly
> inserted by the reclaim code itself, so there is no need for us
> to include any when we signal that a retry is needed.
>
For __GFP_WAIT, that sounds like a safe guarantee.
WARNING: multiple messages have this Message-ID (diff)
From: David Rientjes <rientjes@google.com>
To: Glauber Costa <glommer@parallels.com>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Pekka Enberg <penberg@kernel.org>, Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Christoph Lameter <cl@linux.com>,
devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com,
Tejun Heo <tj@kernel.org>, Suleiman Souhlal <suleiman@google.com>
Subject: Re: [PATCH 02/11] memcg: Reclaim when more than one page needed.
Date: Wed, 27 Jun 2012 12:48:41 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206271246380.22162@chino.kir.corp.google.com> (raw)
In-Reply-To: <4FEADA55.4060409@parallels.com>
On Wed, 27 Jun 2012, Glauber Costa wrote:
> > @@ -2206,7 +2214,7 @@ static int mem_cgroup_do_charge(struct mem_cgroup
> > *memcg, gfp_t gfp_mask,
> > > * unlikely to succeed so close to the limit, and we fall back
> > > * to regular pages anyway in case of failure.
> > > */
> > > - if (nr_pages == 1 && ret)
> > > + if (nr_pages <= NR_PAGES_TO_RETRY && ret)
> > > return CHARGE_RETRY;
>
> Changed to costly order.
>
1 << PAGE_ALLOC_COSTLY_ORDER was the suggestion.
> One more thing. The original version of this patch included
> a cond_resched() here, that was also removed. From my re-reading
> of the code in page_alloc.c and vmscan.c now, I tend to think
> this is indeed not needed, since any cond_resched()s that might
> be needed to ensure the safety of the code will be properly
> inserted by the reclaim code itself, so there is no need for us
> to include any when we signal that a retry is needed.
>
For __GFP_WAIT, that sounds like a safe guarantee.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Frederic Weisbecker
<fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Pekka Enberg <penberg-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>,
devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org,
kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Suleiman Souhlal
<suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 02/11] memcg: Reclaim when more than one page needed.
Date: Wed, 27 Jun 2012 12:48:41 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206271246380.22162@chino.kir.corp.google.com> (raw)
In-Reply-To: <4FEADA55.4060409-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
On Wed, 27 Jun 2012, Glauber Costa wrote:
> > @@ -2206,7 +2214,7 @@ static int mem_cgroup_do_charge(struct mem_cgroup
> > *memcg, gfp_t gfp_mask,
> > > * unlikely to succeed so close to the limit, and we fall back
> > > * to regular pages anyway in case of failure.
> > > */
> > > - if (nr_pages == 1 && ret)
> > > + if (nr_pages <= NR_PAGES_TO_RETRY && ret)
> > > return CHARGE_RETRY;
>
> Changed to costly order.
>
1 << PAGE_ALLOC_COSTLY_ORDER was the suggestion.
> One more thing. The original version of this patch included
> a cond_resched() here, that was also removed. From my re-reading
> of the code in page_alloc.c and vmscan.c now, I tend to think
> this is indeed not needed, since any cond_resched()s that might
> be needed to ensure the safety of the code will be properly
> inserted by the reclaim code itself, so there is no need for us
> to include any when we signal that a retry is needed.
>
For __GFP_WAIT, that sounds like a safe guarantee.
next prev parent reply other threads:[~2012-06-27 19:48 UTC|newest]
Thread overview: 238+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 14:15 [PATCH 00/11] kmem controller for memcg: stripped down version Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 01/11] memcg: Make it possible to use the stock for more than one page Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 17:44 ` Tejun Heo
2012-06-25 17:44 ` Tejun Heo
2012-06-25 17:44 ` Tejun Heo
2012-06-25 22:29 ` Glauber Costa
2012-06-25 22:29 ` Glauber Costa
2012-06-25 22:33 ` Tejun Heo
2012-06-25 22:33 ` Tejun Heo
2012-06-26 4:01 ` David Rientjes
2012-06-26 4:01 ` David Rientjes
2012-06-25 14:15 ` [PATCH 02/11] memcg: Reclaim when more than one page needed Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 23:33 ` Suleiman Souhlal
2012-06-25 23:33 ` Suleiman Souhlal
2012-06-26 8:39 ` Glauber Costa
2012-06-26 8:39 ` Glauber Costa
2012-06-27 16:16 ` Suleiman Souhlal
2012-06-27 16:16 ` Suleiman Souhlal
2012-06-27 16:16 ` Suleiman Souhlal
2012-06-26 4:09 ` David Rientjes
2012-06-26 4:09 ` David Rientjes
2012-06-26 7:12 ` Glauber Costa
2012-06-26 7:12 ` Glauber Costa
2012-06-26 7:12 ` Glauber Costa
2012-06-26 8:54 ` David Rientjes
2012-06-26 8:54 ` David Rientjes
2012-06-26 8:54 ` David Rientjes
2012-06-26 9:08 ` Glauber Costa
2012-06-26 9:08 ` Glauber Costa
2012-06-26 9:17 ` David Rientjes
2012-06-26 9:17 ` David Rientjes
2012-06-26 9:23 ` Glauber Costa
2012-06-26 9:23 ` Glauber Costa
2012-06-27 10:03 ` Glauber Costa
2012-06-27 10:03 ` Glauber Costa
2012-06-27 19:48 ` David Rientjes [this message]
2012-06-27 19:48 ` David Rientjes
2012-06-27 19:48 ` David Rientjes
2012-06-27 20:47 ` Glauber Costa
2012-06-27 20:47 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 03/11] memcg: change defines to an enum Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-26 4:11 ` David Rientjes
2012-06-26 4:11 ` David Rientjes
2012-06-26 8:28 ` Glauber Costa
2012-06-26 8:28 ` Glauber Costa
2012-06-26 9:01 ` David Rientjes
2012-06-26 9:01 ` David Rientjes
2012-06-26 9:01 ` David Rientjes
2012-06-25 14:15 ` [PATCH 04/11] kmem slab accounting basic infrastructure Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-26 4:22 ` David Rientjes
2012-06-26 4:22 ` David Rientjes
2012-06-26 7:09 ` Glauber Costa
2012-06-26 7:09 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 05/11] Add a __GFP_KMEMCG flag Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-26 4:25 ` David Rientjes
2012-06-26 4:25 ` David Rientjes
2012-06-26 7:08 ` Glauber Costa
2012-06-26 7:08 ` Glauber Costa
2012-06-26 9:03 ` David Rientjes
2012-06-26 9:03 ` David Rientjes
2012-06-25 14:15 ` [PATCH 06/11] memcg: kmem controller infrastructure Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 18:06 ` Tejun Heo
2012-06-25 18:06 ` Tejun Heo
2012-06-25 18:06 ` Tejun Heo
2012-06-25 22:28 ` Glauber Costa
2012-06-25 22:28 ` Glauber Costa
2012-06-25 23:17 ` Andrew Morton
2012-06-25 23:17 ` Andrew Morton
2012-06-25 23:17 ` Andrew Morton
2012-06-26 14:40 ` Glauber Costa
2012-06-26 14:40 ` Glauber Costa
2012-06-26 15:01 ` Glauber Costa
2012-06-26 15:01 ` Glauber Costa
2012-06-26 15:01 ` Glauber Costa
2012-06-26 18:01 ` Andrew Morton
2012-06-26 18:01 ` Andrew Morton
2012-06-26 18:01 ` Andrew Morton
2012-06-26 18:08 ` Tejun Heo
2012-06-26 18:08 ` Tejun Heo
2012-06-26 18:08 ` Tejun Heo
2012-06-26 18:14 ` Glauber Costa
2012-06-26 18:14 ` Glauber Costa
2012-06-26 19:20 ` Andrew Morton
2012-06-26 19:20 ` Andrew Morton
2012-06-26 15:29 ` Glauber Costa
2012-06-26 15:29 ` Glauber Costa
2012-06-26 15:29 ` Glauber Costa
2012-06-26 9:12 ` David Rientjes
2012-06-26 9:12 ` David Rientjes
2012-06-26 9:12 ` David Rientjes
2012-06-26 9:17 ` Glauber Costa
2012-06-26 9:17 ` Glauber Costa
2012-06-26 9:17 ` Glauber Costa
2012-06-27 4:01 ` David Rientjes
2012-06-27 4:01 ` David Rientjes
2012-06-27 9:33 ` Glauber Costa
2012-06-27 9:33 ` Glauber Costa
2012-06-27 9:33 ` Glauber Costa
2012-06-27 19:46 ` David Rientjes
2012-06-27 19:46 ` David Rientjes
2012-06-25 14:15 ` [PATCH 07/11] mm: Allocate kernel pages to the right memcg Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 18:07 ` Tejun Heo
2012-06-25 18:07 ` Tejun Heo
2012-06-25 22:27 ` Glauber Costa
2012-06-25 22:27 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 08/11] memcg: disable kmem code when not in use Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-26 5:51 ` Kamezawa Hiroyuki
2012-06-26 5:51 ` Kamezawa Hiroyuki
2012-06-25 14:15 ` [PATCH 09/11] memcg: propagate kmem limiting information to children Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 18:29 ` Tejun Heo
2012-06-25 18:29 ` Tejun Heo
2012-06-25 22:36 ` Glauber Costa
2012-06-25 22:36 ` Glauber Costa
2012-06-25 22:36 ` Glauber Costa
2012-06-25 22:49 ` Tejun Heo
2012-06-25 22:49 ` Tejun Heo
2012-06-25 22:49 ` Tejun Heo
2012-06-25 23:21 ` Andrew Morton
2012-06-25 23:21 ` Andrew Morton
2012-06-26 5:23 ` David Rientjes
2012-06-26 5:23 ` David Rientjes
2012-06-25 23:23 ` Andrew Morton
2012-06-25 23:23 ` Andrew Morton
2012-06-26 5:24 ` David Rientjes
2012-06-26 5:24 ` David Rientjes
2012-06-26 5:31 ` Andrew Morton
2012-06-26 5:31 ` Andrew Morton
2012-06-26 5:31 ` Andrew Morton
2012-06-26 7:23 ` Glauber Costa
2012-06-26 7:23 ` Glauber Costa
2012-06-26 7:23 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 10/11] memcg: allow a memcg with kmem charges to be destructed Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 18:34 ` Tejun Heo
2012-06-25 18:34 ` Tejun Heo
2012-06-25 22:25 ` Glauber Costa
2012-06-25 22:25 ` Glauber Costa
2012-06-25 22:25 ` Glauber Costa
2012-06-26 5:59 ` Kamezawa Hiroyuki
2012-06-26 5:59 ` Kamezawa Hiroyuki
2012-06-26 7:21 ` Glauber Costa
2012-06-26 7:21 ` Glauber Costa
2012-06-26 7:21 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 16:55 ` Frederic Weisbecker
2012-06-25 16:55 ` Frederic Weisbecker
2012-06-25 18:38 ` Tejun Heo
2012-06-25 18:38 ` Tejun Heo
2012-06-25 18:38 ` Tejun Heo
2012-06-25 20:57 ` Frederic Weisbecker
2012-06-25 20:57 ` Frederic Weisbecker
2012-06-25 20:57 ` Frederic Weisbecker
2012-06-26 12:48 ` Glauber Costa
2012-06-26 12:48 ` Glauber Costa
2012-06-26 12:48 ` Glauber Costa
2012-06-26 13:38 ` Frederic Weisbecker
2012-06-26 13:38 ` Frederic Weisbecker
2012-06-26 13:38 ` Frederic Weisbecker
2012-06-26 13:37 ` Glauber Costa
2012-06-26 13:37 ` Glauber Costa
2012-06-26 13:37 ` Glauber Costa
2012-06-26 13:44 ` Frederic Weisbecker
2012-06-26 13:44 ` Frederic Weisbecker
2012-06-26 13:44 ` Frederic Weisbecker
2012-06-26 4:57 ` David Rientjes
2012-06-26 4:57 ` David Rientjes
2012-06-26 5:35 ` Kamezawa Hiroyuki
2012-06-26 5:35 ` Kamezawa Hiroyuki
2012-06-26 5:35 ` Kamezawa Hiroyuki
2012-06-26 7:23 ` Glauber Costa
2012-06-26 7:23 ` Glauber Costa
2012-06-26 7:23 ` Glauber Costa
2012-06-26 8:45 ` David Rientjes
2012-06-26 8:45 ` David Rientjes
2012-06-26 8:45 ` David Rientjes
2012-06-26 8:44 ` Glauber Costa
2012-06-26 8:44 ` Glauber Costa
2012-06-26 8:44 ` Glauber Costa
2012-06-26 9:05 ` David Rientjes
2012-06-26 9:05 ` David Rientjes
2012-06-25 23:27 ` [PATCH 00/11] kmem controller for memcg: stripped down version Andrew Morton
2012-06-25 23:27 ` Andrew Morton
2012-06-26 7:17 ` Glauber Costa
2012-06-26 7:17 ` Glauber Costa
2012-06-26 21:55 ` Andrew Morton
2012-06-26 21:55 ` Andrew Morton
2012-06-26 21:55 ` Andrew Morton
2012-06-27 1:08 ` David Rientjes
2012-06-27 1:08 ` David Rientjes
2012-06-27 8:39 ` Glauber Costa
2012-06-27 8:39 ` Glauber Costa
2012-06-27 8:39 ` Glauber Costa
2012-06-27 9:29 ` Fork bomb limitation in memcg WAS: " Glauber Costa
2012-06-27 9:29 ` Glauber Costa
2012-06-27 9:29 ` Glauber Costa
2012-06-27 12:29 ` Frederic Weisbecker
2012-06-27 12:29 ` Frederic Weisbecker
2012-06-27 12:28 ` Glauber Costa
2012-06-27 12:28 ` Glauber Costa
2012-06-27 12:35 ` Frederic Weisbecker
2012-06-27 12:35 ` Frederic Weisbecker
2012-06-27 19:38 ` David Rientjes
2012-06-27 19:38 ` David Rientjes
2012-06-27 19:38 ` David Rientjes
2012-06-28 9:01 ` Glauber Costa
2012-06-28 9:01 ` Glauber Costa
2012-06-28 22:25 ` Andrew Morton
2012-06-28 22:25 ` Andrew Morton
2012-07-03 11:38 ` Glauber Costa
2012-07-03 11:38 ` Glauber Costa
2012-07-03 11:38 ` Glauber Costa
2012-07-12 15:40 ` Frederic Weisbecker
2012-07-12 15:40 ` Frederic Weisbecker
2012-08-07 13:59 ` Glauber Costa
2012-08-07 13:59 ` Glauber Costa
2012-08-07 13:59 ` Glauber Costa
2012-08-08 14:15 ` Glauber Costa
2012-08-08 14:15 ` Glauber Costa
2012-08-08 14:15 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1206271246380.22162@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=devel@openvz.org \
--cc=fweisbec@gmail.com \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=penberg@kernel.org \
--cc=suleiman@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.