From: Paul Walmsley <paul@pwsan.com>
To: "Bedia, Vaibhav" <vaibhav.bedia@ti.com>
Cc: "N, Mugunthan V" <mugunthanvnm@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Cousson, Benoit" <b-cousson@ti.com>,
"Hilman, Kevin" <khilman@ti.com>
Subject: RE: how to specify dma_mask and coherent_dma_mask in hwmod
Date: Thu, 28 Jun 2012 10:32:46 -0600 (MDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206281031510.2338@utopia.booyaka.com> (raw)
In-Reply-To: <B5906170F1614E41A8A28DE3B8D121433EAED713@DBDE01.ent.ti.com>
On Thu, 28 Jun 2012, Bedia, Vaibhav wrote:
> On Thu, Jun 28, 2012 at 21:22:54, Paul Walmsley wrote:
> [...]
> >
> > dma_mask and coherent_dma_mask can be specified during
> > device creation. See usb_musb_init() in arch/arm/mach-omap2/usb-musb.c
> > for an example.
> >
>
> Thanks for pointing this out. Should omap_device_build() start handling this
> or would that be an overkill?
If both dma_mask and coherent_dma_mask are always 0xffffffff on all OMAPs
and we can set that safely even for devices that don't use it, then yeah
it sounds like we should set it.
Care to send a patch?
- Paul
WARNING: multiple messages have this Message-ID (diff)
From: paul@pwsan.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: how to specify dma_mask and coherent_dma_mask in hwmod
Date: Thu, 28 Jun 2012 10:32:46 -0600 (MDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206281031510.2338@utopia.booyaka.com> (raw)
In-Reply-To: <B5906170F1614E41A8A28DE3B8D121433EAED713@DBDE01.ent.ti.com>
On Thu, 28 Jun 2012, Bedia, Vaibhav wrote:
> On Thu, Jun 28, 2012 at 21:22:54, Paul Walmsley wrote:
> [...]
> >
> > dma_mask and coherent_dma_mask can be specified during
> > device creation. See usb_musb_init() in arch/arm/mach-omap2/usb-musb.c
> > for an example.
> >
>
> Thanks for pointing this out. Should omap_device_build() start handling this
> or would that be an overkill?
If both dma_mask and coherent_dma_mask are always 0xffffffff on all OMAPs
and we can set that safely even for devices that don't use it, then yeah
it sounds like we should set it.
Care to send a patch?
- Paul
next prev parent reply other threads:[~2012-06-28 16:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 5:41 how to specify dma_mask and coherent_dma_mask in hwmod N, Mugunthan V
2012-06-27 5:41 ` N, Mugunthan V
2012-06-28 15:27 ` Bedia, Vaibhav
2012-06-28 15:27 ` Bedia, Vaibhav
2012-06-28 15:52 ` Paul Walmsley
2012-06-28 15:52 ` Paul Walmsley
2012-06-28 16:31 ` Bedia, Vaibhav
2012-06-28 16:31 ` Bedia, Vaibhav
2012-06-28 16:32 ` Paul Walmsley [this message]
2012-06-28 16:32 ` Paul Walmsley
2012-06-28 16:42 ` Bedia, Vaibhav
2012-06-28 16:42 ` Bedia, Vaibhav
2012-06-29 11:23 ` Bedia, Vaibhav
2012-06-29 11:23 ` Bedia, Vaibhav
2012-07-02 7:16 ` N, Mugunthan V
2012-07-02 7:16 ` N, Mugunthan V
2012-07-04 9:28 ` Paul Walmsley
2012-07-04 9:28 ` Paul Walmsley
2012-06-28 15:56 ` ABRAHAM, KISHON VIJAY
2012-06-28 15:56 ` ABRAHAM, KISHON VIJAY
2012-06-28 15:58 ` ABRAHAM, KISHON VIJAY
2012-06-28 15:58 ` ABRAHAM, KISHON VIJAY
-- strict thread matches above, loose matches on Subject: below --
2012-06-07 16:22 N, Mugunthan V
2012-06-07 16:22 ` N, Mugunthan V
2012-07-04 9:41 ` Russell King - ARM Linux
2012-07-04 9:41 ` Russell King - ARM Linux
2012-07-04 11:47 ` N, Mugunthan V
2012-07-04 11:47 ` N, Mugunthan V
2012-07-04 13:25 ` Russell King - ARM Linux
2012-07-04 13:25 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1206281031510.2338@utopia.booyaka.com \
--to=paul@pwsan.com \
--cc=b-cousson@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=vaibhav.bedia@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.