All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@mips.com>
To: Joe Perches <joe@perches.com>
Cc: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
	<linux-mips@linux-mips.org>,
	Dragan Cecavac <dragan.cecavac@mips.com>,
	Aleksandar Markovic <aleksandar.markovic@mips.com>,
	Douglas Leung <douglas.leung@mips.com>,
	Goran Ferenc <goran.ferenc@mips.com>,
	James Hogan <james.hogan@mips.com>,
	James Hogan <jhogan@kernel.org>, <linux-kernel@vger.kernel.org>,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	Miodrag Dinic <miodrag.dinic@mips.com>,
	Paul Burton <paul.burton@imgtec.com>,
	Paul Burton <paul.burton@mips.com>,
	Petar Jovanovic <petar.jovanovic@mips.com>,
	Raghu Gandham <raghu.gandham@mips.com>,
	Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo
Date: Fri, 20 Oct 2017 22:46:44 +0100	[thread overview]
Message-ID: <alpine.DEB.2.00.1710202245400.3886@tp.orcam.me.uk> (raw)
In-Reply-To: <1508533736.30181.7.camel@perches.com>

On Fri, 20 Oct 2017, Joe Perches wrote:

> > > That's somewhat unpleasant code as it formats a fmt string
> > > and the compiler can not verify fmt and args.
> > > 
> > > Perhaps something like the below is preferable:
> > 
> >  Hmm, what problem exactly are you trying to solve with code that has 
> > worked just fine for 16 years now?
> 
> The compiler cannot verify fmt and args.

 You have stated that already.  Why is that a problem?

  Maciej

WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@mips.com>
To: Joe Perches <joe@perches.com>
Cc: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
	linux-mips@linux-mips.org,
	Dragan Cecavac <dragan.cecavac@mips.com>,
	Aleksandar Markovic <aleksandar.markovic@mips.com>,
	Douglas Leung <douglas.leung@mips.com>,
	Goran Ferenc <goran.ferenc@mips.com>,
	James Hogan <james.hogan@mips.com>,
	James Hogan <jhogan@kernel.org>,
	linux-kernel@vger.kernel.org,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	Miodrag Dinic <miodrag.dinic@mips.com>,
	Paul Burton <paul.burton@imgtec.com>,
	Paul Burton <paul.burton@mips.com>,
	Petar Jovanovic <petar.jovanovic@mips.com>,
	Raghu Gandham <raghu.gandham@mips.com>,
	Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo
Date: Fri, 20 Oct 2017 22:46:44 +0100	[thread overview]
Message-ID: <alpine.DEB.2.00.1710202245400.3886@tp.orcam.me.uk> (raw)
Message-ID: <20171020214644.gMLzszGSP09nMKIaZW4MZPyGyyYMUjTRCSpN0vEr1Bg@z> (raw)
In-Reply-To: <1508533736.30181.7.camel@perches.com>

On Fri, 20 Oct 2017, Joe Perches wrote:

> > > That's somewhat unpleasant code as it formats a fmt string
> > > and the compiler can not verify fmt and args.
> > > 
> > > Perhaps something like the below is preferable:
> > 
> >  Hmm, what problem exactly are you trying to solve with code that has 
> > worked just fine for 16 years now?
> 
> The compiler cannot verify fmt and args.

 You have stated that already.  Why is that a problem?

  Maciej

  reply	other threads:[~2017-10-20 22:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-20 14:20 [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo Aleksandar Markovic
2017-10-20 15:17 ` Joe Perches
2017-10-20 20:52   ` Maciej W. Rozycki
2017-10-20 20:52     ` Maciej W. Rozycki
2017-10-20 21:08     ` Joe Perches
2017-10-20 21:46       ` Maciej W. Rozycki [this message]
2017-10-20 21:46         ` Maciej W. Rozycki
2017-10-20 23:09         ` Joe Perches
2017-10-20 20:47 ` Maciej W. Rozycki
2017-10-20 20:47   ` Maciej W. Rozycki
2017-10-20 23:56   ` David Daney
2017-10-23  7:54     ` Miodrag Dinic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1710202245400.3886@tp.orcam.me.uk \
    --to=macro@mips.com \
    --cc=aleksandar.markovic@mips.com \
    --cc=aleksandar.markovic@rt-rk.com \
    --cc=douglas.leung@mips.com \
    --cc=dragan.cecavac@mips.com \
    --cc=goran.ferenc@mips.com \
    --cc=james.hogan@mips.com \
    --cc=jhogan@kernel.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@linux-mips.org \
    --cc=miodrag.dinic@mips.com \
    --cc=paul.burton@imgtec.com \
    --cc=paul.burton@mips.com \
    --cc=petar.jovanovic@mips.com \
    --cc=raghu.gandham@mips.com \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.