From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>,
bitbake-devel@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 20/20] fetch: allow regexps in mirror protocol
Date: Wed, 27 Jun 2012 10:59:44 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1206271059080.19635@oneiric> (raw)
In-Reply-To: <1340808774-24884-1-git-send-email-enrico.scholz@sigma-chemnitz.de>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1673 bytes --]
On Wed, 27 Jun 2012, Enrico Scholz wrote:
> Last mirror rewrite caused a regression not accepting
>
> .*://.*/.* file://${DL_DIR}/../local/
>
> like specifications anymore. Patch restores old behavior by using regexp
> matching when checking protocol.
>
> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
> ---
> lib/bb/fetch2/__init__.py | 2 +-
> 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
>
> diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
> index 6f3d88c..75ce01b 100644
> --- a/lib/bb/fetch2/__init__.py
> +++ b/lib/bb/fetch2/__init__.py
> @@ -207,7 +207,7 @@ def uri_replace(ud, uri_find, uri_replace, d):
> elif loc == 0:
> # Principle of least surprise. We could end up with https matching against http and
> # generating "files://" urls if we use the regexp engine below.
> - if i != uri_decoded[loc]:
> + if not re.match(i, uri_decoded[loc]):
> return None
> result_decoded[loc] = uri_replace_decoded[loc]
> elif (re.match(i, uri_decoded[loc])):
> --
> 1.7.10.2
that certainly seems to have solved my issue with using
"own-mirrors".
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
WARNING: multiple messages have this Message-ID (diff)
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>,
bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 20/20] fetch: allow regexps in mirror protocol
Date: Wed, 27 Jun 2012 10:59:44 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1206271059080.19635@oneiric> (raw)
In-Reply-To: <1340808774-24884-1-git-send-email-enrico.scholz@sigma-chemnitz.de>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1673 bytes --]
On Wed, 27 Jun 2012, Enrico Scholz wrote:
> Last mirror rewrite caused a regression not accepting
>
> .*://.*/.* file://${DL_DIR}/../local/
>
> like specifications anymore. Patch restores old behavior by using regexp
> matching when checking protocol.
>
> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
> ---
> lib/bb/fetch2/__init__.py | 2 +-
> 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
>
> diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
> index 6f3d88c..75ce01b 100644
> --- a/lib/bb/fetch2/__init__.py
> +++ b/lib/bb/fetch2/__init__.py
> @@ -207,7 +207,7 @@ def uri_replace(ud, uri_find, uri_replace, d):
> elif loc == 0:
> # Principle of least surprise. We could end up with https matching against http and
> # generating "files://" urls if we use the regexp engine below.
> - if i != uri_decoded[loc]:
> + if not re.match(i, uri_decoded[loc]):
> return None
> result_decoded[loc] = uri_replace_decoded[loc]
> elif (re.match(i, uri_decoded[loc])):
> --
> 1.7.10.2
that certainly seems to have solved my issue with using
"own-mirrors".
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next prev parent reply other threads:[~2012-06-27 15:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 14:34 [PATCH] fetch2: Add new mirror syntax to simplify mirror specifications Richard Purdie
2012-06-26 17:31 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: " Martin Jansa
2012-06-26 17:31 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: [bitbake-devel] " Martin Jansa
2012-06-27 10:34 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: " Richard Purdie
2012-06-27 10:34 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: [bitbake-devel] " Richard Purdie
2012-06-27 11:06 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: " Martin Jansa
2012-06-27 11:06 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: [bitbake-devel] " Martin Jansa
2012-06-27 14:52 ` [PATCH 20/20] fetch: allow regexps in mirror protocol Enrico Scholz
2012-06-27 14:59 ` Robert P. J. Day [this message]
2012-06-27 14:59 ` Robert P. J. Day
2012-06-27 20:35 ` Richard Purdie
2012-06-27 20:35 ` [bitbake-devel] " Richard Purdie
2012-06-28 0:18 ` Enrico Scholz
2012-06-28 0:18 ` [bitbake-devel] " Enrico Scholz
2012-06-28 0:27 ` Enrico Scholz
2012-06-28 0:27 ` [bitbake-devel] " Enrico Scholz
2012-06-28 11:42 ` Richard Purdie
2012-06-28 11:42 ` [bitbake-devel] " Richard Purdie
2012-06-28 11:43 ` Richard Purdie
2012-06-28 11:43 ` [bitbake-devel] " Richard Purdie
2012-06-27 14:54 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: [bitbake-devel] [PATCH] fetch2: Add new mirror syntax to simplify mirror specifications Enrico Scholz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1206271059080.19635@oneiric \
--to=rpjday@crashcourse.ca \
--cc=bitbake-devel@lists.openembedded.org \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.