From: Enrico Scholz <enrico.scholz@sigma-chemnitz.de> To: Richard Purdie <richard.purdie@linuxfoundation.org> Cc: bitbake-devel@lists.openembedded.org, openembedded-core@lists.openembedded.org Subject: Re: [PATCH 20/20] fetch: allow regexps in mirror protocol Date: Thu, 28 Jun 2012 02:18:10 +0200 [thread overview] Message-ID: <lyr4t0e1bx.fsf@ensc-virt.intern.sigma-chemnitz.de> (raw) In-Reply-To: <1340829332.23146.86.camel@ted> (Richard Purdie's message of "Wed, 27 Jun 2012 21:35:32 +0100") Richard Purdie <richard.purdie@linuxfoundation.org> writes: >> # Principle of least surprise. We could end up with https matching against http and >> # generating "files://" urls if we use the regexp engine below. >> - if i != uri_decoded[loc]: >> + if not re.match(i, uri_decoded[loc]): >> return None >> result_decoded[loc] = uri_replace_decoded[loc] >> elif (re.match(i, uri_decoded[loc])): > > I'm not picking on you (Enrico) here, there is a problem with my change > and we probably should revert my change in this area. > > However the above patch fails "bitbake-selftest" and introduces a > regression. selftest fails here in | ERROR: test_gitfetch_premirror3 (bb.tests.fetch.FetcherTest) | CalledProcessError: Command 'git clone git://git.openembedded.org/bitbake /tmp/tmpt_dDVD/sourcemirror.git 2> /dev/null' returned non-zero exit status 128 and | FAIL: test_urilist2 (bb.tests.fetch.FetcherTest) | AssertionError: Lists differ: ['file:///somepath/downloads/b... != ['file:///someotherpath/downlo... | - ['file:///somepath/downloads/bitbake-1.0.tar.gz', | - 'file:///someotherpath/downloads/bitbake-1.0.tar.gz'] | ? ^ | | + ['file:///someotherpath/downloads/bitbake-1.0.tar.gz'] | ? ^ (I am some days behind current bitbake master, so these might be fixed in the meantime) Nothing which seems to be related to the patch. > The trouble is its sees: > > https://.*/.* file:///someplace/ > > but returns a url like files:// which the fetcher doesn't understand. > Suggestions on how to fix this are welcome. I do not see how my patch can cause such a rewrite. The troublesome 're.sub()' is done in a branch for loc != 0 only and won't be applied on the protocol part. Enrico
WARNING: multiple messages have this Message-ID (diff)
From: Enrico Scholz <enrico.scholz@sigma-chemnitz.de> To: Richard Purdie <richard.purdie@linuxfoundation.org> Cc: bitbake-devel@lists.openembedded.org, openembedded-core@lists.openembedded.org Subject: Re: [bitbake-devel] [PATCH 20/20] fetch: allow regexps in mirror protocol Date: Thu, 28 Jun 2012 02:18:10 +0200 [thread overview] Message-ID: <lyr4t0e1bx.fsf@ensc-virt.intern.sigma-chemnitz.de> (raw) In-Reply-To: <1340829332.23146.86.camel@ted> (Richard Purdie's message of "Wed, 27 Jun 2012 21:35:32 +0100") Richard Purdie <richard.purdie@linuxfoundation.org> writes: >> # Principle of least surprise. We could end up with https matching against http and >> # generating "files://" urls if we use the regexp engine below. >> - if i != uri_decoded[loc]: >> + if not re.match(i, uri_decoded[loc]): >> return None >> result_decoded[loc] = uri_replace_decoded[loc] >> elif (re.match(i, uri_decoded[loc])): > > I'm not picking on you (Enrico) here, there is a problem with my change > and we probably should revert my change in this area. > > However the above patch fails "bitbake-selftest" and introduces a > regression. selftest fails here in | ERROR: test_gitfetch_premirror3 (bb.tests.fetch.FetcherTest) | CalledProcessError: Command 'git clone git://git.openembedded.org/bitbake /tmp/tmpt_dDVD/sourcemirror.git 2> /dev/null' returned non-zero exit status 128 and | FAIL: test_urilist2 (bb.tests.fetch.FetcherTest) | AssertionError: Lists differ: ['file:///somepath/downloads/b... != ['file:///someotherpath/downlo... | - ['file:///somepath/downloads/bitbake-1.0.tar.gz', | - 'file:///someotherpath/downloads/bitbake-1.0.tar.gz'] | ? ^ | | + ['file:///someotherpath/downloads/bitbake-1.0.tar.gz'] | ? ^ (I am some days behind current bitbake master, so these might be fixed in the meantime) Nothing which seems to be related to the patch. > The trouble is its sees: > > https://.*/.* file:///someplace/ > > but returns a url like files:// which the fetcher doesn't understand. > Suggestions on how to fix this are welcome. I do not see how my patch can cause such a rewrite. The troublesome 're.sub()' is done in a branch for loc != 0 only and won't be applied on the protocol part. Enrico
next prev parent reply other threads:[~2012-06-28 0:29 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-06-21 14:34 [PATCH] fetch2: Add new mirror syntax to simplify mirror specifications Richard Purdie 2012-06-26 17:31 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: " Martin Jansa 2012-06-26 17:31 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: [bitbake-devel] " Martin Jansa 2012-06-27 10:34 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: " Richard Purdie 2012-06-27 10:34 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: [bitbake-devel] " Richard Purdie 2012-06-27 11:06 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: " Martin Jansa 2012-06-27 11:06 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: [bitbake-devel] " Martin Jansa 2012-06-27 14:52 ` [PATCH 20/20] fetch: allow regexps in mirror protocol Enrico Scholz 2012-06-27 14:59 ` [OE-core] " Robert P. J. Day 2012-06-27 14:59 ` Robert P. J. Day 2012-06-27 20:35 ` Richard Purdie 2012-06-27 20:35 ` [bitbake-devel] " Richard Purdie 2012-06-28 0:18 ` Enrico Scholz [this message] 2012-06-28 0:18 ` Enrico Scholz 2012-06-28 0:27 ` Enrico Scholz 2012-06-28 0:27 ` [bitbake-devel] " Enrico Scholz 2012-06-28 11:42 ` Richard Purdie 2012-06-28 11:42 ` [bitbake-devel] " Richard Purdie 2012-06-28 11:43 ` Richard Purdie 2012-06-28 11:43 ` [bitbake-devel] " Richard Purdie 2012-06-27 14:54 ` (PRE)MIRRORS doesn't work with https?$:// anymore Was: [bitbake-devel] [PATCH] fetch2: Add new mirror syntax to simplify mirror specifications Enrico Scholz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=lyr4t0e1bx.fsf@ensc-virt.intern.sigma-chemnitz.de \ --to=enrico.scholz@sigma-chemnitz.de \ --cc=bitbake-devel@lists.openembedded.org \ --cc=openembedded-core@lists.openembedded.org \ --cc=richard.purdie@linuxfoundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.