All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
	Cody P Schafer <cody@linux.vnet.ibm.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [patch v2] mm, pcp: allow restoring percpu_pagelist_fraction default
Date: Thu, 5 Jun 2014 13:55:28 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.02.1406051354420.18119@chino.kir.corp.google.com> (raw)
In-Reply-To: <FB428F94-91FA-4E4F-8DA3-060C3C41F261@linuxhacker.ru>

On Wed, 4 Jun 2014, Oleg Drokin wrote:

> Minor nitpick I guess, but ret cannot be anything but 0 here I think (until somebody changes the way proc_dointvec_minmax for write=true operates)?
> 

We need to return 0 regardless of whether proc_dointvec_minmax() changes 
in the future, the patch is correct.

WARNING: multiple messages have this Message-ID (diff)
From: David Rientjes <rientjes@google.com>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
	Cody P Schafer <cody@linux.vnet.ibm.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [patch v2] mm, pcp: allow restoring percpu_pagelist_fraction default
Date: Thu, 5 Jun 2014 13:55:28 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.02.1406051354420.18119@chino.kir.corp.google.com> (raw)
In-Reply-To: <FB428F94-91FA-4E4F-8DA3-060C3C41F261@linuxhacker.ru>

On Wed, 4 Jun 2014, Oleg Drokin wrote:

> Minor nitpick I guess, but ret cannot be anything but 0 here I think (until somebody changes the way proc_dointvec_minmax for write=true operates)?
> 

We need to return 0 regardless of whether proc_dointvec_minmax() changes 
in the future, the patch is correct.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-06-05 20:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-04  1:28 [PATCH] sysctl: Fix division by zero in percpu_pagelist_fraction handler Oleg Drokin
2014-05-04  2:32 ` Greg Kroah-Hartman
2014-06-03  1:40 ` David Rientjes
2014-06-03  2:12   ` Oleg Drokin
2014-06-03  3:57     ` David Rientjes
2014-06-03  4:17       ` Oleg Drokin
2014-06-04  1:22         ` [patch] mm, pcp: allow restoring percpu_pagelist_fraction default David Rientjes
2014-06-04  1:22           ` David Rientjes
2014-06-04  2:19           ` Oleg Drokin
2014-06-04  2:19             ` Oleg Drokin
2014-06-05  0:34             ` [patch v2] " David Rientjes
2014-06-05  0:34               ` David Rientjes
2014-06-05  0:46               ` Oleg Drokin
2014-06-05  0:46                 ` Oleg Drokin
2014-06-05 20:55                 ` David Rientjes [this message]
2014-06-05 20:55                   ` David Rientjes
2014-06-12  0:47               ` [patch v3] " David Rientjes
2014-06-12  0:47                 ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1406051354420.18119@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=cody@linux.vnet.ibm.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=green@linuxhacker.ru \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=rdunlap@infradead.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.