From: Julia Lawall <julia.lawall@lip6.fr> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Julia Lawall <Julia.Lawall@lip6.fr>, Thomas Winischhofer <thomas@winischhofer.net>, Joe Perches <joe@perches.com>, "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Linux Fbdev development list <linux-fbdev@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 6/7] video: fbdev: sis: delete double assignment Date: Sun, 24 Aug 2014 20:40:50 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.02.1408242040020.2066@localhost6.localdomain6> (raw) In-Reply-To: <CAMuHMdVERt9XBN5OW8QqT_PvQVHd6xgnCdjRpiSNp7ZSEgXWSg@mail.gmail.com> On Sun, 24 Aug 2014, Geert Uytterhoeven wrote: > On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > > --- > > The patches in this series do not depend on each other. > > > > This changes the semantics of the code and is not tested. > > Hence I think you should change the subject of the patch, so it's obvious > some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment". Do you want me to resend this patch with the new subject, or just keep it in mind for the future? thanks, julia > > > drivers/video/fbdev/sis/init301.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/video/fbdev/sis/init301.c b/drivers/video/fbdev/sis/init301.c > > index a89e3ca..295e0de 100644 > > --- a/drivers/video/fbdev/sis/init301.c > > +++ b/drivers/video/fbdev/sis/init301.c > > @@ -1714,7 +1714,7 @@ SiS_GetLCDResInfo(struct SiS_Private *SiS_Pr, unsigned short ModeNo, unsigned sh > > SiS_Pr->PanelVCLKIdx315 = VCLK81_315; /* ? */ > > } else { > > SiS_Pr->PanelHT = 1688; SiS_Pr->PanelVT = 802; > > - SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRS = 112; > > + SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRE = 112; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Julia Lawall <Julia.Lawall@lip6.fr>, Thomas Winischhofer <thomas@winischhofer.net>, Joe Perches <joe@perches.com>, "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Linux Fbdev development list <linux-fbdev@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 6/7] video: fbdev: sis: delete double assignment Date: Sun, 24 Aug 2014 18:40:50 +0000 [thread overview] Message-ID: <alpine.DEB.2.02.1408242040020.2066@localhost6.localdomain6> (raw) In-Reply-To: <CAMuHMdVERt9XBN5OW8QqT_PvQVHd6xgnCdjRpiSNp7ZSEgXWSg@mail.gmail.com> On Sun, 24 Aug 2014, Geert Uytterhoeven wrote: > On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > > --- > > The patches in this series do not depend on each other. > > > > This changes the semantics of the code and is not tested. > > Hence I think you should change the subject of the patch, so it's obvious > some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment". Do you want me to resend this patch with the new subject, or just keep it in mind for the future? thanks, julia > > > drivers/video/fbdev/sis/init301.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/video/fbdev/sis/init301.c b/drivers/video/fbdev/sis/init301.c > > index a89e3ca..295e0de 100644 > > --- a/drivers/video/fbdev/sis/init301.c > > +++ b/drivers/video/fbdev/sis/init301.c > > @@ -1714,7 +1714,7 @@ SiS_GetLCDResInfo(struct SiS_Private *SiS_Pr, unsigned short ModeNo, unsigned sh > > SiS_Pr->PanelVCLKIdx315 = VCLK81_315; /* ? */ > > } else { > > SiS_Pr->PanelHT = 1688; SiS_Pr->PanelVT = 802; > > - SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRS = 112; > > + SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRE = 112; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2014-08-24 18:40 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-23 18:33 [PATCH 0/7] delete double assignment Julia Lawall 2014-08-23 18:33 ` Julia Lawall 2014-08-23 18:33 ` [PATCH 1/7] video: fbdev: riva: " Julia Lawall 2014-08-23 18:33 ` Julia Lawall 2014-08-23 18:33 ` [PATCH 2/7] video: fbdev: intelfb: " Julia Lawall 2014-08-23 18:33 ` Julia Lawall 2014-08-26 10:56 ` Tomi Valkeinen 2014-08-26 10:56 ` Tomi Valkeinen 2014-08-23 18:33 ` [PATCH 3/7] serial: vr41xx_siu: " Julia Lawall 2014-08-23 18:33 ` Julia Lawall 2014-08-23 18:33 ` [PATCH 4/7] MIPS: BCM63xx: " Julia Lawall 2014-08-23 18:33 ` Julia Lawall 2014-08-25 11:27 ` Ralf Baechle 2014-08-25 11:27 ` Ralf Baechle 2014-08-25 19:09 ` Jonas Gorski 2014-08-25 19:09 ` Jonas Gorski 2014-08-23 18:33 ` [PATCH 5/7] wusb: " Julia Lawall 2014-08-23 18:33 ` Julia Lawall 2014-08-23 18:33 ` [PATCH 6/7] video: fbdev: sis: " Julia Lawall 2014-08-23 18:33 ` Julia Lawall 2014-08-24 18:21 ` Geert Uytterhoeven 2014-08-24 18:21 ` Geert Uytterhoeven 2014-08-24 18:40 ` Julia Lawall [this message] 2014-08-24 18:40 ` Julia Lawall 2014-08-25 11:36 ` Geert Uytterhoeven 2014-08-25 11:36 ` Geert Uytterhoeven 2014-08-26 10:51 ` Tomi Valkeinen 2014-08-26 10:51 ` Tomi Valkeinen 2014-08-23 18:33 ` [PATCH 7/7] MIPS: Alchemy: au1200fb: " Julia Lawall 2014-08-23 18:33 ` Julia Lawall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.02.1408242040020.2066@localhost6.localdomain6 \ --to=julia.lawall@lip6.fr \ --cc=geert@linux-m68k.org \ --cc=joe@perches.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=plagnioj@jcrosoft.com \ --cc=thomas@winischhofer.net \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.