From: Julia Lawall <julia.lawall@lip6.fr>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
linux-wireless <linux-wireless@vger.kernel.org>,
kernel-janitors@vger.kernel.org, linux@rasmusvillemoes.dk,
Joe Perches <joe@perches.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
linux-mtd@lists.infradead.org, linux-samsung-soc@vger.kernel.org,
"Mailing List, Arm" <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, netdev <netdev@vger.kernel.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 0/20] fix misspelling of current function in string
Date: Mon, 8 Dec 2014 07:43:16 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1412080738210.2100@localhost6.localdomain6> (raw)
In-Reply-To: <CAGRGNgWDJqV=XD+6q26Ma=m1sEi1kvLWsjq6=RjRVSFTxow0Qg@mail.gmail.com>
On Mon, 8 Dec 2014, Julian Calaby wrote:
> Hi Julia,
>
> On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> > These patches replace what appears to be a reference to the name of the
> > current function but is misspelled in some way by either the name of the
> > function itself, or by %s and then __func__ in an argument list.
>
> Would there be any value in doing this for _all_ cases where the
> function name is written in a format string?
Probably. But there are a lot of them. Even for the misspellings, I have
only don about 1/3 of the cases.
On the other hand, the misspelling have to be checked carefully, because a
misspelling of one thing could be the correct spelling of the thing thst
was actually intended.
Joe, however, points out that a lot of these prints are just for function
tracing, and could be removed. I worked on another semantic patch that
tries to do that. It might be better to remove those prints completely,
rather than sending one patch to transform them and then one patch to
remove them after that. That is why for this series I did only the ones
where there was actually a problem.
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
linux-samsung-soc@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
linux@rasmusvillemoes.dk,
linux-wireless <linux-wireless@vger.kernel.org>,
intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Julia Lawall <Julia.Lawall@lip6.fr>,
netdev <netdev@vger.kernel.org>,
linux-mtd@lists.infradead.org, linux-pci@vger.kernel.org,
Joe Perches <joe@perches.com>,
"Mailing List, Arm" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/20] fix misspelling of current function in string
Date: Mon, 8 Dec 2014 07:43:16 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1412080738210.2100@localhost6.localdomain6> (raw)
In-Reply-To: <CAGRGNgWDJqV=XD+6q26Ma=m1sEi1kvLWsjq6=RjRVSFTxow0Qg@mail.gmail.com>
On Mon, 8 Dec 2014, Julian Calaby wrote:
> Hi Julia,
>
> On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> > These patches replace what appears to be a reference to the name of the
> > current function but is misspelled in some way by either the name of the
> > function itself, or by %s and then __func__ in an argument list.
>
> Would there be any value in doing this for _all_ cases where the
> function name is written in a format string?
Probably. But there are a lot of them. Even for the misspellings, I have
only don about 1/3 of the cases.
On the other hand, the misspelling have to be checked carefully, because a
misspelling of one thing could be the correct spelling of the thing thst
was actually intended.
Joe, however, points out that a lot of these prints are just for function
tracing, and could be removed. I worked on another semantic patch that
tries to do that. It might be better to remove those prints completely,
rather than sending one patch to transform them and then one patch to
remove them after that. That is why for this series I did only the ones
where there was actually a problem.
julia
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
linux-samsung-soc@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
linux@rasmusvillemoes.dk,
linux-wireless <linux-wireless@vger.kernel.org>,
intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Julia Lawall <Julia.Lawall@lip6.fr>,
netdev <netdev@vger.kernel.org>,
linux-mtd@lists.infradead.org, linux-pci@vger.kernel.org,
Joe Perches <joe@perches.com>,
"Mailing List, Arm" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/20] fix misspelling of current function in string
Date: Mon, 08 Dec 2014 06:43:16 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1412080738210.2100@localhost6.localdomain6> (raw)
In-Reply-To: <CAGRGNgWDJqV=XD+6q26Ma=m1sEi1kvLWsjq6=RjRVSFTxow0Qg@mail.gmail.com>
On Mon, 8 Dec 2014, Julian Calaby wrote:
> Hi Julia,
>
> On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> > These patches replace what appears to be a reference to the name of the
> > current function but is misspelled in some way by either the name of the
> > function itself, or by %s and then __func__ in an argument list.
>
> Would there be any value in doing this for _all_ cases where the
> function name is written in a format string?
Probably. But there are a lot of them. Even for the misspellings, I have
only don about 1/3 of the cases.
On the other hand, the misspelling have to be checked carefully, because a
misspelling of one thing could be the correct spelling of the thing thst
was actually intended.
Joe, however, points out that a lot of these prints are just for function
tracing, and could be removed. I worked on another semantic patch that
tries to do that. It might be better to remove those prints completely,
rather than sending one patch to transform them and then one patch to
remove them after that. That is why for this series I did only the ones
where there was actually a problem.
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
linux-samsung-soc@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
linux@rasmusvillemoes.dk,
linux-wireless <linux-wireless@vger.kernel.org>,
intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Julia Lawall <Julia.Lawall@lip6.fr>,
netdev <netdev@vger.kernel.org>,
linux-mtd@lists.infradead.org, linux-pci@vger.kernel.org,
Joe Perches <joe@perches.com>,
"Mailing List, Arm" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/20] fix misspelling of current function in string
Date: Mon, 8 Dec 2014 07:43:16 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1412080738210.2100@localhost6.localdomain6> (raw)
In-Reply-To: <CAGRGNgWDJqV=XD+6q26Ma=m1sEi1kvLWsjq6=RjRVSFTxow0Qg@mail.gmail.com>
On Mon, 8 Dec 2014, Julian Calaby wrote:
> Hi Julia,
>
> On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> > These patches replace what appears to be a reference to the name of the
> > current function but is misspelled in some way by either the name of the
> > function itself, or by %s and then __func__ in an argument list.
>
> Would there be any value in doing this for _all_ cases where the
> function name is written in a format string?
Probably. But there are a lot of them. Even for the misspellings, I have
only don about 1/3 of the cases.
On the other hand, the misspelling have to be checked carefully, because a
misspelling of one thing could be the correct spelling of the thing thst
was actually intended.
Joe, however, points out that a lot of these prints are just for function
tracing, and could be removed. I worked on another semantic patch that
tries to do that. It might be better to remove those prints completely,
rather than sending one patch to transform them and then one patch to
remove them after that. That is why for this series I did only the ones
where there was actually a problem.
julia
WARNING: multiple messages have this Message-ID (diff)
From: julia.lawall@lip6.fr (Julia Lawall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/20] fix misspelling of current function in string
Date: Mon, 8 Dec 2014 07:43:16 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1412080738210.2100@localhost6.localdomain6> (raw)
In-Reply-To: <CAGRGNgWDJqV=XD+6q26Ma=m1sEi1kvLWsjq6=RjRVSFTxow0Qg@mail.gmail.com>
On Mon, 8 Dec 2014, Julian Calaby wrote:
> Hi Julia,
>
> On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> > These patches replace what appears to be a reference to the name of the
> > current function but is misspelled in some way by either the name of the
> > function itself, or by %s and then __func__ in an argument list.
>
> Would there be any value in doing this for _all_ cases where the
> function name is written in a format string?
Probably. But there are a lot of them. Even for the misspellings, I have
only don about 1/3 of the cases.
On the other hand, the misspelling have to be checked carefully, because a
misspelling of one thing could be the correct spelling of the thing thst
was actually intended.
Joe, however, points out that a lot of these prints are just for function
tracing, and could be removed. I worked on another semantic patch that
tries to do that. It might be better to remove those prints completely,
rather than sending one patch to transform them and then one patch to
remove them after that. That is why for this series I did only the ones
where there was actually a problem.
julia
next prev parent reply other threads:[~2014-12-08 6:43 UTC|newest]
Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-07 19:20 [PATCH 0/20] fix misspelling of current function in string Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 19:20 ` [PATCH 1/20] mtd: s3c2410: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 22:48 ` Richard Weinberger
2014-12-07 22:48 ` Richard Weinberger
2014-12-07 22:48 ` Richard Weinberger
2014-12-07 22:48 ` Richard Weinberger
2014-12-07 22:48 ` Richard Weinberger
2014-12-08 7:11 ` Julia Lawall
2014-12-08 7:11 ` Julia Lawall
2014-12-08 7:11 ` Julia Lawall
2014-12-08 7:11 ` Julia Lawall
2014-12-08 7:11 ` Julia Lawall
2014-12-08 9:16 ` Richard Weinberger
2014-12-08 9:16 ` Richard Weinberger
2014-12-08 9:16 ` Richard Weinberger
2014-12-08 9:16 ` Richard Weinberger
2014-12-08 9:16 ` Richard Weinberger
2015-02-06 11:28 ` Brian Norris
2015-02-06 11:28 ` Brian Norris
2015-02-06 11:28 ` Brian Norris
2015-02-06 11:28 ` Brian Norris
2015-02-06 11:28 ` Brian Norris
2014-12-07 19:20 ` [PATCH 2/20] PCI: keystone: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-08 15:14 ` Murali Karicheri
2014-12-08 15:14 ` Murali Karicheri
2014-12-08 15:14 ` Murali Karicheri
2015-01-09 18:31 ` Bjorn Helgaas
2015-01-09 18:31 ` Bjorn Helgaas
2015-01-09 18:31 ` Bjorn Helgaas
2014-12-07 19:20 ` [PATCH 3/20] PCI: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 20:41 ` Rasmus Villemoes
2014-12-07 20:41 ` Rasmus Villemoes
2014-12-07 20:43 ` Julia Lawall
2014-12-07 20:43 ` Julia Lawall
2014-12-07 19:20 ` [PATCH 4/20] dmfe: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 20:34 ` Grant Grundler
2014-12-07 20:34 ` Grant Grundler
2014-12-09 21:14 ` David Miller
2014-12-09 21:14 ` David Miller
2014-12-07 19:20 ` [PATCH 5/20] isdn: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-09 21:14 ` David Miller
2014-12-09 21:14 ` David Miller
2014-12-07 19:20 ` [PATCH 6/20] TTY: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-08 8:49 ` Jiri Slaby
2014-12-08 8:49 ` Jiri Slaby
2014-12-08 9:18 ` Joe Perches
2014-12-08 9:18 ` Joe Perches
2014-12-08 9:50 ` Jiri Slaby
2014-12-08 9:50 ` Jiri Slaby
2014-12-07 19:20 ` [PATCH 7/20] drm/i915: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-08 10:24 ` Jani Nikula
2014-12-08 10:24 ` Jani Nikula
2014-12-08 14:15 ` Daniel Vetter
2014-12-08 14:15 ` Daniel Vetter
2014-12-08 14:15 ` Daniel Vetter
2014-12-07 19:20 ` [PATCH 8/20] USB: isp1760: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 20:41 ` Jeremiah Mahler
2014-12-07 20:41 ` Jeremiah Mahler
2014-12-07 20:45 ` Julia Lawall
2014-12-07 20:45 ` Julia Lawall
2014-12-07 20:48 ` Jeremiah Mahler
2014-12-07 19:20 ` [PATCH 9/20] drivers/scsi: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 19:20 ` [PATCH 10/20] uli526x: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 20:48 ` Grant Grundler
2014-12-07 20:48 ` Grant Grundler
2014-12-07 20:59 ` [PATCH 10/20 v2] " Julia Lawall
2014-12-07 20:59 ` Julia Lawall
2014-12-09 21:14 ` [PATCH 10/20] " David Miller
2014-12-09 21:14 ` David Miller
2014-12-07 19:20 ` [PATCH 11/20] vme: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 19:20 ` [PATCH 12/20] hp100: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 20:44 ` Jeremiah Mahler
2014-12-07 20:44 ` Jeremiah Mahler
2014-12-09 21:13 ` David Miller
2014-12-09 21:13 ` David Miller
2014-12-09 21:14 ` David Miller
2014-12-09 21:14 ` David Miller
2014-12-07 19:20 ` [PATCH 13/20] zd1211rw: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 19:20 ` [PATCH 14/20] chelsio: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-09 21:13 ` David Miller
2014-12-09 21:13 ` David Miller
2014-12-09 21:14 ` David Miller
2014-12-09 21:14 ` David Miller
2014-12-07 19:20 ` [PATCH 15/20] hostap_cs: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 19:20 ` [PATCH 16/20] rtlwifi: rtl8821ae: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 19:20 ` [PATCH 17/20] drm/i2c: tda998x: " Julia Lawall
2014-12-07 19:20 ` Julia Lawall
2014-12-07 19:21 ` [PATCH 18/20] usb: gadget: " Julia Lawall
2014-12-07 19:21 ` Julia Lawall
2014-12-07 19:21 ` [PATCH 19/20] TTY: " Julia Lawall
2014-12-07 19:21 ` Julia Lawall
2014-12-07 20:54 ` Jeremiah Mahler
2014-12-07 20:54 ` Jeremiah Mahler
2014-12-07 21:05 ` Julia Lawall
2014-12-07 21:05 ` Julia Lawall
2014-12-07 19:21 ` [PATCH 20/20] drm/radeon: " Julia Lawall
2014-12-07 19:21 ` Julia Lawall
2014-12-08 15:44 ` Alex Deucher
2014-12-08 15:44 ` Alex Deucher
2014-12-08 15:44 ` Alex Deucher
2014-12-08 16:17 ` Julia Lawall
2014-12-08 16:17 ` Julia Lawall
2014-12-07 23:44 ` [PATCH 0/20] " Julian Calaby
2014-12-07 23:44 ` Julian Calaby
2014-12-07 23:44 ` Julian Calaby
2014-12-07 23:44 ` Julian Calaby
2014-12-08 6:43 ` Julia Lawall [this message]
2014-12-08 6:43 ` Julia Lawall
2014-12-08 6:43 ` Julia Lawall
2014-12-08 6:43 ` Julia Lawall
2014-12-08 6:43 ` Julia Lawall
2014-12-10 2:56 ` Julian Calaby
2014-12-10 2:56 ` Julian Calaby
2014-12-10 2:56 ` Julian Calaby
2014-12-10 2:56 ` Julian Calaby
2014-12-10 2:56 ` Julian Calaby
2014-12-08 3:55 ` Joe Perches
2014-12-08 3:55 ` Joe Perches
2014-12-08 3:55 ` Joe Perches
2014-12-08 3:55 ` Joe Perches
2014-12-08 3:55 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1412080738210.2100@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joe@perches.com \
--cc=julian.calaby@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.