[PATCH] Staging: rtl8712: Replace memcpy with ether_addr_copy

[PATCH] Staging: rtl8712: Replace memcpy with ether_addr_copy

[Vatika Harlalka]

Replace
Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
Use ether_addr_copy instead of memcpy(a, b, ETH_ALEN)

---
 drivers/staging/rtl8712/os_intfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index ebfb29e..e1b54fb 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -181,7 +181,7 @@ static int r871x_net_set_mac_address(struct net_device *pnetdev, void *p)
 	struct sockaddr *addr = p;
 
 	if (padapter->bup == false)
-		memcpy(pnetdev->dev_addr, addr->sa_data, ETH_ALEN);
+		ether_addr_copy(pnetdev->dev_addr, addr->sa_data);
 	return 0;
 }
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: rtl8712: Replace memcpy with ether_addr_copy

[Julia Lawall]

On Sat, 14 Mar 2015, Vatika Harlalka wrote:

> Replace
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> Use ether_addr_copy instead of memcpy(a, b, ETH_ALEN)

Something went wrong with the commit message.

Also eth_addr_copy requires alignment (Please note: dst & src must both
be aligned to u16).  You need to justify why this property holds.

julia

>
> ---
>  drivers/staging/rtl8712/os_intfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
> index ebfb29e..e1b54fb 100644
> --- a/drivers/staging/rtl8712/os_intfs.c
> +++ b/drivers/staging/rtl8712/os_intfs.c
> @@ -181,7 +181,7 @@ static int r871x_net_set_mac_address(struct net_device *pnetdev, void *p)
>  	struct sockaddr *addr = p;
>
>  	if (padapter->bup == false)
> -		memcpy(pnetdev->dev_addr, addr->sa_data, ETH_ALEN);
> +		ether_addr_copy(pnetdev->dev_addr, addr->sa_data);
>  	return 0;
>  }
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150314111518.GA12847%40akanksha.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] Staging: rtl8712: replace memcpy with ether_addr_copy

[Greg KH]

On Sat, Mar 14, 2015 at 04:17:04PM +0300, Haneen Mohammed wrote:
> This patch replace memcpy with ethe_addr_copy to address the following
> warning generated by checkpatch.pl: ""Prefer ether_addr_copy over memcpy
> if the Ethernet addresses are __aligned(2)"
> 
> Follwoing is the output of pahole for the relevant datastructures:
> 1- for  "iwe.u.ap_addr.sa_data" and "wrqu->ap_addr.sa_data"
> 
> struct sockaddr {
>         sa_family_t                sa_family;            /*     0     2
> */
>         char                       sa_data[14];          /*     2    14
> */

Your lines are wrapped here very oddly.  Please fix that up and resend.

thanks,

greg k-h